From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH] pack-objects: re-validate data we copy from elsewhere. Date: Sun, 3 Sep 2006 15:00:16 -0700 (PDT) Message-ID: References: <20060829165811.GB21729@spearce.org> <9e4733910608291037k2d9fb791v18abc19bdddf5e89@mail.gmail.com> <20060829175819.GE21729@spearce.org> <9e4733910608291155g782953bbv5df1b74878f4fcf1@mail.gmail.com> <20060829190548.GK21729@spearce.org> <9e4733910608291252q130fc723r945e6ab906ca6969@mail.gmail.com> <20060829232007.GC22935@spearce.org> <9e4733910608291807q9b896e4sdbfaa9e49de58c2b@mail.gmail.com> <20060830015122.GE22935@spearce.org> <9e4733910608291958l45c0257dla6e5ebd4176f7164@mail.gmail.com> <20060830031029.GA23967@spearce.org> <7vzmdmh2lu.fsf@assigned-by-dhcp.cox.net> <44F871BA.3070303@gmail.com> <7vveo741tc.fsf_-_@assigned-by-dhcp.cox.net> <7vd5ae3ox2.fsf@assigned-by-dhcp.cox.net> <7vslj8tydc.fsf@assigned-by-dhcp.cox.net> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: git@vger.kernel.org X-From: git-owner@vger.kernel.org Mon Sep 04 00:00:36 2006 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GK010-0001ja-H7 for gcvg-git@gmane.org; Mon, 04 Sep 2006 00:00:30 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750711AbWICWA1 (ORCPT ); Sun, 3 Sep 2006 18:00:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750765AbWICWA1 (ORCPT ); Sun, 3 Sep 2006 18:00:27 -0400 Received: from smtp.osdl.org ([65.172.181.4]:27851 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1750711AbWICWA0 (ORCPT ); Sun, 3 Sep 2006 18:00:26 -0400 Received: from shell0.pdx.osdl.net (fw.osdl.org [65.172.181.6]) by smtp.osdl.org (8.12.8/8.12.8) with ESMTP id k83M0JnW019209 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Sun, 3 Sep 2006 15:00:22 -0700 Received: from localhost (shell0.pdx.osdl.net [10.9.0.31]) by shell0.pdx.osdl.net (8.13.1/8.11.6) with ESMTP id k83M0GII031636; Sun, 3 Sep 2006 15:00:17 -0700 To: Junio C Hamano In-Reply-To: <7vslj8tydc.fsf@assigned-by-dhcp.cox.net> X-Spam-Status: No, hits=-2.473 required=5 tests=AWL,OSDL_HEADER_SUBJECT_BRACKETED,PATCH_SUBJECT_OSDL X-Spam-Checker-Version: SpamAssassin 2.63-osdl_revision__1.94__ X-MIMEDefang-Filter: osdl$Revision: 1.146 $ X-Scanned-By: MIMEDefang 2.36 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: On Sun, 3 Sep 2006, Junio C Hamano wrote: > > Quite bad. For the kernel archive of today (I usually am nearly > fully packed): Ok. Is it less painful if it just checks the zlib CRC (and that the SHA1 _exists_ for a delta - although I guess we check that indirectly by just accepting the delta in the first place)? That combination should still be a fairly strong check, of course. Then we could have something like [repack] check=[none|weak|default|strong] where the "none" check would be to just copy the data as-is, the "weak" (aka "default") would check just the CRC, and the strong one would unpack the whole object and check the SHA1.. Linus -- VGER BF report: U 0.5