Re: [patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers

[Nicolas Pitre <nico@cam.org>]

On Fri, 22 Dec 2006, pHilipp Zabel wrote:

> On 12/21/06, Andrew Morton <akpm@osdl.org> wrote:
> > On Wed, 20 Dec 2006 13:13:21 -0800
> > David Brownell <david-b@pacbell.net> wrote:
> >
> > > +#define gpio_get_value(gpio) \
> > > +     (GPLR & GPIO_GPIO(gpio))
> > > +
> > > +#define gpio_set_value(gpio,value) \
> > > +     ((value) ? (GPSR = GPIO_GPIO(gpio)) : (GPCR(gpio) =
> > > GPIO_GPIO(gpio)))
> >
> > likewise.
> 
> I have done the same to the SA1100 wrappers as to the PXA wrappers now.
> Maybe the non-inline functions in generic.c are overkill for those much
> simpler
> macros on SA...

I think the SA1x00 has no advantage of having out of line versions.  The 
function call will cost more than the inline version even if gpio is not 
constant.


Nicolas