From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2) Date: Mon, 29 Jan 2007 20:44:33 -0800 (PST) Message-ID: References: <20070127174230.GN6017@stusta.de> <20070128133344.214070@gmx.net> <1170051963.6454.7.camel@Homer.simpson.net> <45BE5AF0.3030005@cs.wisc.edu> <45BE864A.2050907@cs.wisc.edu> <45BE9774.20105@cs.wisc.edu> <45BE99A4.9080503@cs.wisc.edu> <45BEB292.7060008@cs.wisc.edu> <20070129190847.6ef1191f.akpm@osdl.org> <1170123518.2376.2.camel@max> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from smtp.osdl.org ([65.172.181.24]:42385 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965021AbXA3EzI (ORCPT ); Mon, 29 Jan 2007 23:55:08 -0500 In-Reply-To: <1170123518.2376.2.camel@max> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Mike Christie Cc: Andrew Morton , Mike Galbraith , Uwe Bugla , Adrian Bunk , gd@spherenet.de, alan@lxorguk.ukuu.org.uk, linux-ide@vger.kernel.org, B.Zolnierkiewicz@elka.pw.edu.pl, Jeff Garzik , Jens Axboe , James Bottomley , FUJITA Tomonori , Boaz Harrosh On Mon, 29 Jan 2007, Mike Christie wrote: > > Ok. here is a fix with the overflow check sg.c has. Patch > was made against Linus's tree and tested with nero. > > Userspace does not send us jiffies. Use msecs_to_jiffies > and check for overflow like sg.c > > Signed-off-by: Mike Christie Thanks. Fixed the ',' that Andrew pointed out, committed and pushed out. What a stupid bug. And I even _looked_ at that patch, since there weren't that many that changed anything in this area, and it looked just subtly right enough that no warning bells ever went off. Thanks to everybody, but especially Mike for showing us the errors of our ways. Linus