From: Jiri Kosina <jkosina@suse.cz>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 1/10] CRIS: local_irq_disable() is redundant after local_irq_save()
Date: Thu, 1 Feb 2007 16:35:46 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0702011612030.13648@jikos.suse.cz> (raw)
In-Reply-To: <Pine.LNX.4.64.0702011609090.13648@jikos.suse.cz>
From: Jiri Kosina <jkosina@suse.cz>
CRIS: local_irq_disable() is redundant after local_irq_save()
arch/cris/arch-v10/kernel/time.c::get_ns_in_jiffie() contains
local_irq_disable() call after local_irq_save(). This looks
redundant.
arch/cris/kernel/time.c::do_gettimeofday() contains
local_irq_disable() call after local_irq_save(). This looks
redundant.
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
arch/cris/arch-v10/kernel/time.c | 1 -
arch/cris/kernel/time.c | 1 -
2 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/cris/arch-v10/kernel/time.c b/arch/cris/arch-v10/kernel/time.c
index ebacf14..077e973 100644
--- a/arch/cris/arch-v10/kernel/time.c
+++ b/arch/cris/arch-v10/kernel/time.c
@@ -38,7 +38,6 @@ unsigned long get_ns_in_jiffie(void)
unsigned long flags;
local_irq_save(flags);
- local_irq_disable();
timer_count = *R_TIMER0_DATA;
presc_count = *R_TIM_PRESC_STATUS;
/* presc_count might be wrapped */
diff --git a/arch/cris/kernel/time.c b/arch/cris/kernel/time.c
index 0f9213c..22a1aa5 100644
--- a/arch/cris/kernel/time.c
+++ b/arch/cris/kernel/time.c
@@ -55,7 +55,6 @@ void do_gettimeofday(struct timeval *tv)
unsigned long flags;
signed long usec, sec;
local_irq_save(flags);
- local_irq_disable();
usec = do_gettimeoffset();
/*
next prev parent reply other threads:[~2007-02-01 15:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-01 15:35 [PATCH 0/10] fix usages of local_irq_save() and local_irq_disable() Jiri Kosina
2007-02-01 15:35 ` Jiri Kosina [this message]
2007-02-01 15:35 ` [PATCH 2/10] X86_64: local_irq_disable() is redundant after local_irq_save() Jiri Kosina
2007-02-01 15:36 ` [PATCH 3/10] POWERPC-86xx: " Jiri Kosina
2007-02-01 15:36 ` [PATCH 4/10] POWERPC-Powermac: " Jiri Kosina
2007-02-01 15:36 ` [PATCH 5/10] SCSI-BusLogic: " Jiri Kosina
2007-02-01 15:36 ` [PATCH 6/10] CHAR-Amiserial: turn local_save_flags() + local_irq_disable() into local_irq_save() Jiri Kosina
2007-02-01 15:36 ` [PATCH 7/10] " Jiri Kosina
2007-02-01 15:36 ` [PATCH 8/10] NET-3c59x: " Jiri Kosina
2007-02-01 15:36 ` [PATCH 9/10] CRIS: turn local_save_flags() + local_irq_disable() into local_irq_save() in headers Jiri Kosina
2007-02-01 15:36 ` [PATCH 10/10] CRIS: turn local_save_flags() + local_irq_disable() into local_irq_save() Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0702011612030.13648@jikos.suse.cz \
--to=jkosina@suse.cz \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.