stac92xx_parse_auto_config() can return 0 on error?

From: Jason Baron <jbaron@redhat.com>
To: alsa-devel@alsa-project.org
Cc: John Linville <linville@redhat.com>
Subject: stac92xx_parse_auto_config() can return 0 on error?
Date: Mon, 5 Feb 2007 16:40:57 -0500 (EST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0702051624060.26250@dhcp83-20.boston.redhat.com> (raw)

hi,

I just ran into a RHEL4 U5 beta kernel oops in snd_hda_input_mux_info(), 
because the 'imux' parameter pointer was NULL. I traced this back to 
stac92xx_parse_auto_config(), which can return 0, if 'line_outs' is not 
set, without having initialized the 'input_mux'.

The oops does not happen on the upstream kernel on this hardware b/c 
'line_outs' was set (additional code has been added since RHEL4 to set 
it). However, it still appears to me, that if 'line_outs' is not set, we 
should return an error code, and not 0.

thanks,

-Jason

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642