All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Roland McGrath <roland@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix cc-option-yn whitespace
Date: Wed, 7 Feb 2007 20:34:20 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0702072024330.8424@woody.linux-foundation.org> (raw)
In-Reply-To: <20070208033046.44D39180055@magilla.sf.frob.com>



On Wed, 7 Feb 2007, Roland McGrath wrote:

> This change:
> 
> 	commit 5de043f4bd11a9e0a3e8daec7d1905da575a76b7
> 	Author: Oleg Verych <olecom@flower.upol.cz>
> 	Date:   Tue Feb 6 02:18:21 2007 +0100
> 
> 	    [PATCH] kbuild: improve option checking, Kbuild.include cleanup
> 
> introduced leading whitespace in the results of cc-option-yn and such.
> This breaks some of their uses, like HAS_MTUNE in arch/i386/Makefile.cpu.

Yes.. It doesn't seem to happen with make-3.81, for some reason, and I 
don't see why the leading space happens. Maybe somebody with deep GNU make 
knowledge knows.

I committed the hopefully equivalent patch (that also removes the 
symlinking to /dev/null that Roman objected to).

			Linus

  reply	other threads:[~2007-02-08  4:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-08  3:30 [PATCH] fix cc-option-yn whitespace Roland McGrath
2007-02-08  4:34 ` Linus Torvalds [this message]
2007-02-08 20:06   ` Roland McGrath
2007-02-08 20:54     ` Oleg Verych

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0702072024330.8424@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.