From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752975AbXBJDpo (ORCPT ); Fri, 9 Feb 2007 22:45:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752976AbXBJDpo (ORCPT ); Fri, 9 Feb 2007 22:45:44 -0500 Received: from mail5.sea5.speakeasy.net ([69.17.117.7]:52480 "EHLO mail5.sea5.speakeasy.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752975AbXBJDpo (ORCPT ); Fri, 9 Feb 2007 22:45:44 -0500 Date: Fri, 9 Feb 2007 22:45:41 -0500 (EST) From: James Morris X-X-Sender: jmorris@d.namei To: Rusty Russell cc: lkml - Kernel Mailing List , Andi Kleen , Andrew Morton , virtualization Subject: Re: [PATCH 4 of 7] lguest: Config and headers In-Reply-To: <1171064515.15356.10.camel@localhost.localdomain> Message-ID: References: <1171033146.2718.157.camel@localhost.localdomain> <1171033383.2718.163.camel@localhost.localdomain> <1171033436.2718.165.camel@localhost.localdomain> <1171033484.2718.167.camel@localhost.localdomain> <1171033741.2718.172.camel@localhost.localdomain> <1171064515.15356.10.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 10 Feb 2007, Rusty Russell wrote: > Well it was the use of get_order() which triggered Andi's alarm bells, > so I went back to deriving it. This code is correct, however. + hype_pages = alloc_pages(GFP_KERNEL|__GFP_ZERO, HYPERVISOR_MAP_ORDER); + if (!hype_pages) + return -ENOMEM; This will try and allocate 2^16 pages. I guess we need a HYPERVISOR_PAGE_ORDER ? - James -- James Morris