All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Kosina <jkosina@suse.cz>
To: Julien BLACHE <jb@jblache.org>
Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Marcel Holtmann <marcel@holtmann.org>
Subject: Re: [PATCH] Fix USB vendor and product IDs endianness for USB HID devices
Date: Sun, 11 Feb 2007 18:24:50 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.64.0702111822190.22290@jikos.suse.cz> (raw)
In-Reply-To: <87k5yp90v1.fsf@sonic.technologeek.org>

On Sat, 10 Feb 2007, Julien BLACHE wrote:

> The generic HID layer changes introduced an endianness bug for USB HID
> devices.

Hi Julien,

this is obviously a bug, thanks for a fix, I queued it for upstream.

Two nitpicks:

- could you please submitpatches in standard conventions, so that they 
  could be applied directly using patch -p1 against toplevel of the kernel 
  tree (your patch was just against hid-core.c, but without any path)
- please inline patches in message and do not attach them, if possible

I will submit the patch to stable team.

Thanks,

-- 
Jiri Kosina
SUSE Labs

  reply	other threads:[~2007-02-11 17:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-10 21:08 [PATCH] Fix USB vendor and product IDs endianness for USB HID devices Julien BLACHE
2007-02-11 17:24 ` Jiri Kosina [this message]
2007-02-11 18:04   ` Julien BLACHE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0702111822190.22290@jikos.suse.cz \
    --to=jkosina@suse.cz \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@suse.de \
    --cc=jb@jblache.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.