All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@mindspring.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] removing R/W semaphore content from standard semaphore.h files
Date: Fri, 16 Feb 2007 19:10:19 +0000	[thread overview]
Message-ID: <Pine.LNX.4.64.0702161405230.3503@CPE00045a9c397f-CM001225dbafb6> (raw)


  if someone could clarify this, i'd appreciate it.  i recently
submitted a patch that removed any inclusions of "linux/rwsem.h" from
the semaphore.h files, since standard semaphore header files should
*not* be pulling in any R/W sem stuff -- the R/W semaphores now have
their own rwsem.h header file.

  however, some of the semaphore.h files contain the following macro
definition:

$ grep RW_LOCK_BIAS $(find . -name semaphore.h)
./include/asm-frv/semaphore.h:#define RW_LOCK_BIAS               0x01000000
./include/asm-m68knommu/semaphore.h:#define RW_LOCK_BIAS         0x01000000
./include/asm-m68k/semaphore.h:#define RW_LOCK_BIAS              0x01000000
./include/asm-h8300/semaphore.h:#define RW_LOCK_BIAS             0x01000000
./include/asm-cris/semaphore.h:#define RW_LOCK_BIAS              0x01000000

  for the same reason as above, i'm fairly certain that *those* macros
should be removed from the regular semaphore.h files.  what does that
macro represent?  and where should it *properly* be defined?  thanks.

rday

-- 
====================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
====================================
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

             reply	other threads:[~2007-02-16 19:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-16 19:10 Robert P. J. Day [this message]
2007-02-16 19:59 ` [KJ] removing R/W semaphore content from standard semaphore.h Randy Dunlap
2007-02-16 20:23 ` Robert P. J. Day
2007-02-16 20:28 ` Robert P. J. Day
2007-02-16 20:33 ` Randy Dunlap
2007-02-16 20:44 ` Robert P. J. Day
2007-02-16 21:45 ` Frederik Deweerdt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0702161405230.3503@CPE00045a9c397f-CM001225dbafb6 \
    --to=rpjday@mindspring.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.