From: Christoph Lameter <clameter@sgi.com>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
mcr@sandelman.ca
Subject: Re: [PATCH] slab: ensure cache_alloc_refill terminates
Date: Mon, 19 Feb 2007 21:05:27 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0702192102060.9934@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0702191020490.2085@sbz-30.cs.Helsinki.FI>
On Mon, 19 Feb 2007, Pekka J Enberg wrote:
> If slab->inuse is corrupted, cache_alloc_refill can enter an infinite
> loop as detailed by Michael Richardson in the following post:
> <http://lkml.org/lkml/2007/2/16/292>.
We have seen that corruption too.
> check_spinlock_acquired(cachep);
> +
> + /*
> + * The slab was either on partial or free list so
> + * there must be at least one object available for
> + * allocation.
> + */
> + BUG_ON(slabp->inuse >= cachep->num);
slabp->inuse is an integer and we have seen it become -1. The proposed
test will not catch those cases.
next prev parent reply other threads:[~2007-02-20 5:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-19 8:22 [PATCH] slab: ensure cache_alloc_refill terminates Pekka J Enberg
2007-02-19 8:48 ` KAMEZAWA Hiroyuki
2007-02-19 8:58 ` Pekka J Enberg
2007-02-20 5:05 ` Christoph Lameter [this message]
2007-02-21 8:30 Pekka J Enberg
2007-02-21 17:51 ` Christoph Lameter
2007-02-21 18:22 ` Pekka Enberg
2007-02-21 18:28 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0702192102060.9934@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcr@sandelman.ca \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.