All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Engelhardt <jengelh@computergmbh.de>
To: Patrick McHardy <kaber@trash.net>
Cc: Netfilter Developer Mailing List <netfilter-devel@lists.netfilter.org>
Subject: xt_connlimit 20070625
Date: Mon, 25 Jun 2007 13:11:49 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0706251309521.3137@fbirervta.pbzchgretzou.qr> (raw)
In-Reply-To: <467BAF07.6020502@trash.net>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 11814 bytes --]


On Jun 22 2007 13:14, Patrick McHardy wrote:

>As Pablo mentioned, you need to force 8 byte alignment to
>avoid 32/64 bit issues.
>
>list_for_each_entry_safe
>
>Please no assignments in comparisons.
>
>It should support other protocols as well. Also nothing guarantees that
>you're looking at a TCP connection here.
>
>You can remove this with list_for_each_entry_safe
>
>Thats just me I think, but I have an aversion to "rv" for return value.
>"err" or "ret"?
>
>Switching the two expressions seems more logical.
>
>Excessive debugging, also shouldn't use ifdef but pr_debug if
>absolutely necessary.
>
>list_for_each_entry_safe


Subject: Add the connlimit match from POM-NG

Along comes... the connlimit match that has been in POM-NG for a long time.
Plus:

    *	2007-06-02: works with 2.6.22, xtables'ified and all that

    *	2007-06-02: will request nf_conntrack_ipv4 upon load
	(otherwise it hotdrops every packet - a glitch that goes back
	to at least 2.6.20.2)

    *   2007-06-05: fixed: deadlock after OOM

    *   2007-06-05: any-protocol support

    *   2007-06-06: Using jhash, as suggested by Eric Dumazet.
        ( https://lists.netfilter.org/pipermail/netfilter-devel/2007-June/028056.html )


Signed-off-by: Jan Engelhardt <jengelh@gmx.de>

---
 include/linux/netfilter/xt_connlimit.h |   14 +
 net/netfilter/Kconfig                  |    7 
 net/netfilter/Makefile                 |    1 
 net/netfilter/xt_connlimit.c           |  278 +++++++++++++++++++++++++++++++++
 4 files changed, 300 insertions(+)

Index: linux-2.6.22/include/linux/netfilter/xt_connlimit.h
===================================================================
--- /dev/null
+++ linux-2.6.22/include/linux/netfilter/xt_connlimit.h
@@ -0,0 +1,14 @@
+#ifndef _XT_CONNLIMIT_H
+#define _XT_CONNLIMIT_H
+
+struct xt_connlimit_data;
+
+struct xt_connlimit_info {
+	u_int32_t mask;
+	unsigned int limit, inverse;
+
+	/* this needs to be at the end */
+	struct xt_connlimit_data __attribute__((aligned(8))) *data;
+};
+
+#endif /* _XT_CONNLIMIT_H */
Index: linux-2.6.22/net/netfilter/Kconfig
===================================================================
--- linux-2.6.22.orig/net/netfilter/Kconfig
+++ linux-2.6.22/net/netfilter/Kconfig
@@ -411,6 +411,13 @@ config NETFILTER_XT_MATCH_CONNBYTES
 	  If you want to compile it as a module, say M here and read
 	  <file:Documentation/kbuild/modules.txt>.  If unsure, say `N'.
 
+config NETFILTER_XT_MATCH_CONNLIMIT
+	tristate '"connlimit" match support"'
+	depends on NETFILTER_XTABLES && NF_CONNTRACK_IPV4
+	---help---
+	  This match allows you to match against the number of parallel TCP
+	  connections to a server per client IP address (or address block).
+
 config NETFILTER_XT_MATCH_CONNMARK
 	tristate  '"connmark" connection mark match support'
 	depends on NETFILTER_XTABLES
Index: linux-2.6.22/net/netfilter/Makefile
===================================================================
--- linux-2.6.22.orig/net/netfilter/Makefile
+++ linux-2.6.22/net/netfilter/Makefile
@@ -51,6 +51,7 @@ obj-$(CONFIG_NETFILTER_XT_TARGET_CONNSEC
 # matches
 obj-$(CONFIG_NETFILTER_XT_MATCH_COMMENT) += xt_comment.o
 obj-$(CONFIG_NETFILTER_XT_MATCH_CONNBYTES) += xt_connbytes.o
+obj-$(CONFIG_NETFILTER_XT_MATCH_CONNLIMIT) += xt_connlimit.o
 obj-$(CONFIG_NETFILTER_XT_MATCH_CONNMARK) += xt_connmark.o
 obj-$(CONFIG_NETFILTER_XT_MATCH_CONNTRACK) += xt_conntrack.o
 obj-$(CONFIG_NETFILTER_XT_MATCH_DCCP) += xt_dccp.o
Index: linux-2.6.22/net/netfilter/xt_connlimit.c
===================================================================
--- /dev/null
+++ linux-2.6.22/net/netfilter/xt_connlimit.c
@@ -0,0 +1,278 @@
+/*
+ * netfilter module to limit the number of parallel tcp
+ * connections per IP address.
+ *   (c) 2000 Gerd Knorr <kraxel@bytesex.org>
+ *   Nov 2002: Martin Bene <martin.bene@icomedias.com>:
+ *		only ignore TIME_WAIT or gone connections
+ *   Copyright © Jan Engelhardt <jengelh@gmx.de>, 2007
+ *
+ * based on ...
+ *
+ * Kernel module to match connection tracking information.
+ * GPL (C) 1999  Rusty Russell (rusty@rustcorp.com.au).
+ */
+#include <linux/in.h>
+#include <linux/ip.h>
+#include <linux/jhash.h>
+#include <linux/list.h>
+#include <linux/module.h>
+#include <linux/random.h>
+#include <linux/skbuff.h>
+#include <linux/spinlock.h>
+#include <linux/netfilter/nf_conntrack_tcp.h>
+#include <linux/netfilter/x_tables.h>
+#include <linux/netfilter/xt_connlimit.h>
+#include <net/netfilter/nf_conntrack.h>
+#include <net/netfilter/nf_conntrack_core.h>
+#include <net/netfilter/nf_conntrack_tuple.h>
+
+/* we will save the tuples of all connections we care about */
+struct xt_connlimit_conn {
+	struct list_head list;
+	struct nf_conntrack_tuple tuple;
+};
+
+struct xt_connlimit_data {
+	struct list_head iphash[256];
+	spinlock_t lock;
+};
+
+static u_int32_t connlimit_iphash_rnd;
+
+static inline unsigned int connlimit_iphash(u_int32_t addr)
+{
+	/*
+	 * Since iphash (in struct xt_connlimit_data) has 256 entries, we need
+	 * to "% 256" it. "& mask" works too, but _only_ if the iphash array
+	 * size is exactly a {power of two} minus 1.
+	 */
+	return jhash_1word(addr, connlimit_iphash_rnd) & 0xFF;
+}
+
+#ifdef DEBUG
+static const char *connection_state(const struct nf_conn *conn)
+{
+	static const char const *tcp_state[] = {
+		"none", "established", "syn_sent", "syn_recv", "fin_wait",
+		"time_wait", "close", "close_wait", "last_ack", "listen"
+	};
+	if (conn == NULL)
+		return "gone";
+	if (conn->tuplehash[0].tuple.dst.protonum == IPPROTO_TCP)
+		return tcp_state[found_ct->proto.tcp.state]);
+	return "";
+}
+#else
+static inline const char *connection_state(const struct nf_conn *conn)
+{
+	return "";
+}
+#endif
+
+static bool already_closed(const struct nf_conn *conn)
+{
+	u_int16_t proto = conn->tuplehash[0].tuple.dst.protonum;
+	if (proto == IPPROTO_TCP)
+		return conn->proto.tcp.state == TCP_CONNTRACK_TIME_WAIT;
+	else if (proto == IPPROTO_SCTP)
+		/* ACK_SENT the right thing? */
+		return conn->proto.sctp.state == SCTP_CONNTRACK_SHUTDOWN_ACK_SENT;
+	else
+		return 0;
+}
+
+static int count_them(struct xt_connlimit_data *data, u_int32_t addr,
+		      u_int32_t mask, struct nf_conn *ct)
+{
+	struct nf_conntrack_tuple_hash *found;
+	struct nf_conntrack_tuple tuple;
+	struct xt_connlimit_conn *conn;
+	struct xt_connlimit_conn *tmp;
+	struct nf_conn *found_ct;
+	struct list_head *hash;
+	bool addit = true;
+	int matches = 0;
+
+	tuple = ct->tuplehash[0].tuple;
+	hash  = &data->iphash[connlimit_iphash(addr & mask)];
+
+	/* check the saved connections */
+	list_for_each_entry_safe(conn, tmp, hash, list) {
+		found    = nf_conntrack_find_get(&conn->tuple, ct);
+		found_ct = NULL;
+
+		if (found != NULL)
+			found_ct = nf_ct_tuplehash_to_ctrack(found);
+
+		if (found_ct != NULL &&
+		    memcmp(&conn->tuple, &tuple, sizeof(tuple)) == 0 &&
+		    !already_closed(found_ct))
+			/*
+			 * Just to be sure we have it only once in the list.
+			 * We should not see tuples twice unless someone hooks
+			 * this into a table without "-p tcp --syn".
+			 */
+			addit = false;
+
+		pr_debug(KERN_WARNING "xt_connlimit [%u]: src=%u.%u.%u.%u:%u "
+		         "dst=%u.%u.%u.%u:%d %s\n",
+		         connlimit_iphash(addr & mask),
+		         NIPQUAD(conn->tuple.src.u3.ip),
+		         ntohs(conn->tuple.src.u.tcp.port),
+		         NIPQUAD(conn->tuple.dst.u3.ip),
+		         ntohs(conn->tuple.dst.u.tcp.port),
+			 connection_state(found_ct));
+
+		if (found == NULL) {
+			/* this one is gone */
+			list_del(&conn->list);
+			kfree(conn);
+			continue;
+		}
+
+		if (already_closed(found_ct)) {
+
+			/*
+			 * we do not care about connections which are
+			 * closed already -> ditch it
+			 */
+			list_del(&conn->list);
+			kfree(conn);
+			nf_conntrack_put(&found_ct->ct_general);
+			continue;
+		}
+
+		if ((addr & mask) == (conn->tuple.src.u3.ip & mask))
+			/* same source network -> be counted! */
+			++matches;
+
+		nf_conntrack_put(&found_ct->ct_general);
+	}
+
+	if (addit) {
+		/* save the new connection in our list */
+#ifdef DEBUG
+		pr_debug(KERN_WARNING "xt_connlimit [%u]: src=%u.%u.%u.%u:%u "
+		         "dst=%u.%u.%u.%u:%u new\n",
+		         connlimit_iphash(addr & mask),
+		         NIPQUAD(tuple.src.u3.ip), ntohs(tuple.src.u.tcp.port),
+		         NIPQUAD(tuple.dst.u3.ip), ntohs(tuple.dst.u.tcp.port));
+#endif
+
+		conn = kzalloc(sizeof(*conn), GFP_ATOMIC);
+		if (conn == NULL)
+			return -ENOMEM;
+
+		INIT_LIST_HEAD(&conn->list);
+		conn->tuple = tuple;
+		list_add(&conn->list, hash);
+		++matches;
+	}
+
+	return matches;
+}
+
+static bool connlimit_match(const struct sk_buff *skb,
+			    const struct net_device *in,
+			    const struct net_device *out,
+			    const struct xt_match *match,
+			    const void *matchinfo, int offset,
+			    unsigned int protoff, bool *hotdrop)
+{
+	const struct xt_connlimit_info *info = matchinfo;
+	enum ip_conntrack_info ctinfo;
+	const struct iphdr *iph;
+	struct nf_conn *ct;
+	int connections;
+
+	ct = nf_ct_get(skb, &ctinfo);
+	if (ct == NULL) {
+		printk(KERN_INFO "xt_connlimit: INVALID connection\n");
+		*hotdrop = true;
+		return false;
+	}
+
+	iph = ip_hdr(skb);
+	spin_lock_bh(&info->data->lock);
+	connections = count_them(info->data, iph->saddr, info->mask, ct);
+	spin_unlock_bh(&info->data->lock);
+
+	if (connections < 0) {
+		/* kmalloc failed, drop it entirely */
+		printk(KERN_DEBUG "xt_connlimit: kmalloc failed\n");
+		*hotdrop = 1;
+		return false;
+	}
+
+	return (connections > info->limit) ^ info->inverse;
+}
+
+static bool connlimit_check(const char *tablename, const void *ip,
+			    const struct xt_match *match, void *matchinfo,
+			    unsigned int hook_mask)
+{
+	struct xt_connlimit_info *info = matchinfo;
+	unsigned int i;
+
+	if (nf_ct_l3proto_try_module_get(match->family) < 0) {
+		printk(KERN_WARNING "cannot load conntrack support for "
+		       "address family %u\n", match->family);
+		return false;
+	}
+
+	/* init private data */
+	info->data = kmalloc(sizeof(struct xt_connlimit_data), GFP_KERNEL);
+	spin_lock_init(&info->data->lock);
+	for (i = 0; i < ARRAY_SIZE(info->data->iphash); ++i)
+		INIT_LIST_HEAD(&info->data->iphash[i]);
+
+	return true;
+}
+
+static void connlimit_destroy(const struct xt_match *match, void *matchinfo)
+{
+	struct xt_connlimit_info *info = matchinfo;
+	struct xt_connlimit_conn *conn;
+	struct xt_connlimit_conn *tmp;
+	unsigned int i;
+
+	nf_ct_l3proto_module_put(match->family);
+
+	for (i = 0; i < ARRAY_SIZE(info->data->iphash); ++i) {
+		list_for_each_entry_safe(conn, tmp,
+		    &info->data->iphash[i], list) {
+			list_del(&conn->list);
+			kfree(conn);
+		}
+	}
+
+	kfree(info->data);
+}
+
+static struct xt_match connlimit_reg = {
+	.name       = "connlimit",
+	.family     = AF_INET,
+	.checkentry = connlimit_check,
+	.match      = connlimit_match,
+	.matchsize  = sizeof(struct xt_connlimit_info),
+	.destroy    = connlimit_destroy,
+	.me         = THIS_MODULE,
+};
+
+static int __init xt_connlimit_init(void)
+{
+	get_random_bytes(&connlimit_iphash_rnd, sizeof(connlimit_iphash_rnd));
+	return xt_register_match(&connlimit_reg);
+}
+
+static void __exit xt_connlimit_exit(void)
+{
+	xt_unregister_match(&connlimit_reg);
+}
+
+module_init(xt_connlimit_init);
+module_exit(xt_connlimit_exit);
+MODULE_AUTHOR("Jan Engelhardt <jengelh@gmx.de>");
+MODULE_DESCRIPTION("netfilter xt_connlimit match module");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("ipt_connlimit");

  parent reply	other threads:[~2007-06-25 11:11 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-20  9:39 xt_connlimit 20070620_2 Jan Engelhardt
2007-06-20 17:21 ` Andrew Beverley
2007-06-22 11:14 ` Patrick McHardy
2007-06-22 11:36   ` Jan Engelhardt
2007-06-22 11:43     ` Patrick McHardy
2007-06-22 12:33       ` Jan Engelhardt
2007-06-22 12:42         ` Patrick McHardy
2007-06-22 13:22           ` Jan Engelhardt
2007-06-22 13:27             ` Patrick McHardy
2007-06-25 11:11   ` Jan Engelhardt [this message]
2007-06-25 11:41     ` xt_connlimit 20070625 Patrick McHardy
2007-06-25 11:45       ` Patrick McHardy
2007-06-25 12:36       ` Jan Engelhardt
2007-06-25 12:43         ` Patrick McHardy
2007-06-25 14:41           ` Jan Engelhardt
2007-06-25 14:46             ` Patrick McHardy
2007-06-25 15:01               ` Jan Engelhardt
2007-06-25 15:05                 ` Patrick McHardy
2007-06-25 15:05                 ` Patrick McHardy
2007-06-25 15:14                   ` Jan Engelhardt
2007-06-28 19:23       ` Jan Engelhardt
2007-06-28 19:27         ` Patrick McHardy
2007-06-28 19:31           ` Jan Engelhardt
2007-06-28 19:33             ` Patrick McHardy
2007-06-28 19:48             ` Patrick McHardy
2007-06-28 19:51               ` xt_connlimit 20070628 Jan Engelhardt
2007-06-28 19:55                 ` xt_connlimit 20070628 kernel Jan Engelhardt
2007-06-29 11:27                   ` Patrick McHardy
2007-07-01 14:11                     ` Jan Engelhardt
2007-07-02 12:27                       ` Patrick McHardy
2007-07-02 15:38                         ` Jan Engelhardt
2007-07-02 15:40                           ` Patrick McHardy
2007-07-02 19:53                             ` Jan Engelhardt
2007-07-03 11:14                               ` Patrick McHardy
2007-07-03 11:31                                 ` Jan Engelhardt
2007-07-03 11:34                                   ` Patrick McHardy
2007-07-04 10:56                                     ` Jan Engelhardt
2007-07-04 14:52                                       ` Patrick McHardy
2007-07-04 15:11                                         ` Jan Engelhardt
2007-07-06 13:05                                           ` Patrick McHardy
2007-07-07 17:51                                             ` xt_connlimit 20070707 kernel Jan Engelhardt
2007-07-09 14:30                                               ` Patrick McHardy
2007-07-09 15:10                                                 ` Jan Engelhardt
2007-07-09 15:20                                                   ` Patrick McHardy
2007-07-09 15:29                                                     ` Patrick McHardy
2007-07-09 15:32                                                       ` Jan Engelhardt
2007-07-09 15:33                                                         ` Patrick McHardy
2007-07-09 15:34                                                           ` Patrick McHardy
2007-07-09 15:38                                                             ` Jan Engelhardt
2007-07-09 15:43                                                               ` Patrick McHardy
2007-07-13 14:18                                                               ` Yasuyuki KOZAKAI
     [not found]                                                               ` <200707131418.l6DEIudN010879@toshiba.co.jp>
2007-07-13 15:01                                                                 ` Jan Engelhardt
2007-07-13 15:03                                                                   ` Patrick McHardy
2007-07-13 15:13                                                                     ` Jan Engelhardt
2007-07-13 15:16                                                                       ` Patrick McHardy
2007-07-13 15:31                                                                         ` Jan Engelhardt
2007-07-13 15:42                                                                           ` Patrick McHardy
2007-07-13 16:08                                                                             ` Jan Engelhardt
2007-07-13 15:44                                                                       ` Yasuyuki KOZAKAI
     [not found]                                                                       ` <200707131544.l6DFivSf011446@toshiba.co.jp>
2007-07-13 16:09                                                                         ` Jan Engelhardt
2007-07-10  6:30                                               ` Yasuyuki KOZAKAI
2007-07-11 17:37                                                 ` Jan Engelhardt
2007-07-11 18:04                                                   ` Patrick McHardy
2007-07-11 18:18                                                     ` Jan Engelhardt
2007-07-11 18:19                                                       ` Jan Engelhardt
2007-07-11 18:25                                                       ` Patrick McHardy
     [not found]                                               ` <200707100630.l6A6UBM1021597@toshiba.co.jp>
2007-07-11 13:23                                                 ` Patrick McHardy
2007-07-04  8:55                         ` xt_connlimit 20070628 kernel Yasuyuki KOZAKAI
2007-07-04 14:52                           ` Patrick McHardy
2007-06-28 20:08                 ` xt_connlimit 20070628 Jan Engelhardt
2007-06-25 18:51 ` xt_connlimit 20070620_2 Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0706251309521.3137@fbirervta.pbzchgretzou.qr \
    --to=jengelh@computergmbh.de \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.