All of lore.kernel.org
 help / color / mirror / Atom feed
From: malc <av1474@comtv.ru>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Document Qemu coding style
Date: Wed, 1 Apr 2009 02:38:28 +0400 (MSD)	[thread overview]
Message-ID: <Pine.LNX.4.64.0904010225280.3379@linmac.oyster.ru> (raw)
In-Reply-To: <60cad3f0903311448y7e826b6blecb015140fa09901@mail.gmail.com>

On Tue, 31 Mar 2009, David Turner wrote:

> On Tue, Mar 31, 2009 at 6:18 PM, Blue Swirl <blauwirbel@gmail.com> wrote:
> 
> >
> > True enough for the comments part. There are still some areas that I
> > don't understand well, for example TB handling and its inherent
> > limitations.
> >
> > Which part of the source you find subtle and magical but not commented
> > enough?
> >
> 
> ok, here are a few things that ring a bell, there are probably a lot others:
> 
> the software mmu implementation in system mode is *really* hard to
> understand at
> first. It took me a long time to grasp the various aspects of it, including
> these:
> 
>    - loads/stores in kernel or userspace map to different translated code
>    fragments
>    - loads/stores in different emulated CPUs also map to different
>    translated code.
>    - the way i/o memory access is controlled in fine details and relates to
>    the rest of the MMU.
> 
> most of what happens in exe.c is black-magic :-)
> 
> how the audio-subsystem works and its relationship with hardware
> emulation is subtle.  For my work on the Android emulator, I have
> modified three audio-backends and wrote one from scratch. It took me
> several tries to get things to an acceptable state. What I didn't
> understand first is that there is no common time-based used by all
> components involved.
> 

For starters you could have asked about things you believe are subtle.

Now to the part i do not understand: what do you mean by time-based(sic)?

There's one clock involved, as far as audio is concerned, and it's the
one dervied from the speed with which host audio can consume/produce
audio, anything else just doesn't work (for scenarios i was interested
in anyway)

As for the question of why everything just calls audio_pcm_sw_write
raised in AUDIO.txt, the reason, if my memory serves and it might as
well not do that all that well, things are the way they are for the
reason that any given driver can, theoretically, use the respective
audio subsystems/libraries own, less naive, st_rate_flow equivalent.

[..snip..]

> For the record, here are attached a few documents I wrote to detail
> what I've "discovered" until now. Hope some one can find them useful
> (Sorry if some of them are focused on ARM system emulation only).
> 
> Regards
> 

P.S. Last/only time i looked at Android couldn't help but notice that,
     apart from other things, capture was implemented for coreaudio,
     it would have been nice, if for nothing else but the sake of
     completeness, to have that in main QEMU too.

-- 
mailto:av1474@comtv.ru

  reply	other threads:[~2009-03-31 22:39 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-29 21:23 [Qemu-devel] [PATCH] Document Qemu coding style Avi Kivity
2009-03-30  1:15 ` malc
2009-03-30 18:28 ` Blue Swirl
2009-03-30 19:02   ` M. Warner Losh
2009-03-30 19:55     ` Avi Kivity
2009-03-30 19:54   ` Avi Kivity
2009-03-30 21:43     ` Lennart Sorensen
2009-03-30 22:15       ` M. Warner Losh
2009-03-30 23:38         ` Lennart Sorensen
2009-03-31  0:09           ` M. Warner Losh
2009-03-31  5:59           ` Laurent Desnogues
2009-03-31 12:58             ` David Turner
2009-03-31 13:31               ` Avi Kivity
2009-03-31 21:18                 ` David Turner
2009-03-31 16:18               ` Blue Swirl
2009-03-31 21:48                 ` David Turner
2009-03-31 22:38                   ` malc [this message]
2009-03-31 23:28                     ` David Turner
2009-03-31 23:49                       ` malc
2009-04-01  0:25                         ` David Turner
2009-04-01  1:02                           ` malc
2009-04-01  9:04               ` Daniel P. Berrange
2009-03-30 19:58   ` Avi Kivity
2009-03-30 20:10     ` Glauber Costa
2009-03-30 20:35       ` Avi Kivity
2009-03-30 20:37         ` Glauber Costa
2009-03-30 20:20   ` Andreas Färber
2009-03-30 21:45   ` Lennart Sorensen
2009-03-30 22:16     ` M. Warner Losh
2009-03-31  5:42     ` Gleb Natapov
2009-03-31 13:47 ` Paul Brook
2009-04-01  8:51 ` Richard W.M. Jones
2009-04-01  9:04   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0904010225280.3379@linmac.oyster.ru \
    --to=av1474@comtv.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.