[Qemu-devel] PPC target

[Qemu-devel] PPC target

[malc]

I don't know what exactly changed (-Werror, opcode section removal, compiler
version), but PPC target doesn't build here without:

diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index f60f99a..4044eee 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -759,7 +759,7 @@ static always_inline void gen_op_arith_compute_ca(DisasContext *ctx, TCGv arg1,
 static always_inline void gen_op_arith_add(DisasContext *ctx, TCGv ret, TCGv arg1, TCGv arg2,
                                            int add_ca, int compute_ca, int compute_ov)
 {
-    TCGv t0, t1;
+    TCGv t0, t1 = t1;
 
     if ((!compute_ca && !compute_ov) ||
         (!TCGV_EQUAL(ret,arg1) && !TCGV_EQUAL(ret, arg2)))  {
@@ -1176,7 +1176,7 @@ static void gen_nego(DisasContext *ctx)
 static always_inline void gen_op_arith_subf(DisasContext *ctx, TCGv ret, TCGv arg1, TCGv arg2,
                                             int add_ca, int compute_ca, int compute_ov)
 {
-    TCGv t0, t1;
+    TCGv t0, t1 = t1;
 
     if ((!compute_ca && !compute_ov) ||
         (!TCGV_EQUAL(ret, arg1) && !TCGV_EQUAL(ret, arg2)))  {
@@ -3355,7 +3355,7 @@ static always_inline void gen_bcond (DisasContext *ctx, int type)
 {
     uint32_t bo = BO(ctx->opcode);
     int l1 = gen_new_label();
-    TCGv target;
+    TCGv target = target;
 
     ctx->exception = POWERPC_EXCP_BRANCH;
     if (type == BCOND_LR || type == BCOND_CTR) {


-- 
mailto:av1474@comtv.ru

Re: [Qemu-devel] PPC target

[Blue Swirl]

On 6/17/09, malc <av1474@comtv.ru> wrote:
>
>  I don't know what exactly changed (-Werror, opcode section removal, compiler
>  version), but PPC target doesn't build here without:
>

What's the problem? Error from compiler?

Re: [Qemu-devel] PPC target

[malc]

On Wed, 17 Jun 2009, Blue Swirl wrote:

> On 6/17/09, malc <av1474@comtv.ru> wrote:
> >
> >  I don't know what exactly changed (-Werror, opcode section removal, compiler
> >  version), but PPC target doesn't build here without:
> >
> 
> What's the problem? Error from compiler?

Same old, variable might be uninitialized.

-- 
mailto:av1474@comtv.ru

Re: [Qemu-devel] PPC target

[Paul Brook]

On Wednesday 17 June 2009, malc wrote:
> On Wed, 17 Jun 2009, Blue Swirl wrote:
> > On 6/17/09, malc <av1474@comtv.ru> wrote:
> > >  I don't know what exactly changed (-Werror, opcode section removal,
> > > compiler version), but PPC target doesn't build here without:
> >
> > What's the problem? Error from compiler?
>
> Same old, variable might be uninitialized.

In that case you should be using TCGV_UNUSED.

Paul