* [PATCH] drivers/input/keyboard: Move a dereference below a NULL test
@ 2009-08-30 9:18 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2009-08-30 9:18 UTC (permalink / raw)
To: Dmitry Torokhov, Dmitry Torokhov, linux-input, linux-kernel,
kernel-janitors
From: Julia Lawall <julia@diku.dk>
If the NULL test is necessary, then the dereference should be moved below
the NULL test.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/).
// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@
- T i = E->fld;
+ T i;
... when != E
when != i
if (E == NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/input/keyboard/w90p910_keypad.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -u -p a/drivers/input/keyboard/w90p910_keypad.c b/drivers/input/keyboard/w90p910_keypad.c
--- a/drivers/input/keyboard/w90p910_keypad.c
+++ b/drivers/input/keyboard/w90p910_keypad.c
@@ -120,7 +120,7 @@ static int __devinit w90p910_keypad_prob
{
const struct w90p910_keypad_platform_data *pdata =
pdev->dev.platform_data;
- const struct matrix_keymap_data *keymap_data = pdata->keymap_data;
+ const struct matrix_keymap_data *keymap_data;
struct w90p910_keypad *keypad;
struct input_dev *input_dev;
struct resource *res;
@@ -132,6 +132,7 @@ static int __devinit w90p910_keypad_prob
dev_err(&pdev->dev, "no platform data defined\n");
return -EINVAL;
}
+ keymap_data = pdata->keymap_data;
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drivers/input/keyboard: Move a dereference below a NULL test
@ 2009-08-30 9:18 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2009-08-30 9:18 UTC (permalink / raw)
To: Dmitry Torokhov, Dmitry Torokhov, linux-input, linux-kernel,
kernel-janitors
From: Julia Lawall <julia@diku.dk>
If the NULL test is necessary, then the dereference should be moved below
the NULL test.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/).
// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@
- T i = E->fld;
+ T i;
... when != E
when != i
if (E = NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/input/keyboard/w90p910_keypad.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -u -p a/drivers/input/keyboard/w90p910_keypad.c b/drivers/input/keyboard/w90p910_keypad.c
--- a/drivers/input/keyboard/w90p910_keypad.c
+++ b/drivers/input/keyboard/w90p910_keypad.c
@@ -120,7 +120,7 @@ static int __devinit w90p910_keypad_prob
{
const struct w90p910_keypad_platform_data *pdata pdev->dev.platform_data;
- const struct matrix_keymap_data *keymap_data = pdata->keymap_data;
+ const struct matrix_keymap_data *keymap_data;
struct w90p910_keypad *keypad;
struct input_dev *input_dev;
struct resource *res;
@@ -132,6 +132,7 @@ static int __devinit w90p910_keypad_prob
dev_err(&pdev->dev, "no platform data defined\n");
return -EINVAL;
}
+ keymap_data = pdata->keymap_data;
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/input/keyboard: Move a dereference below a NULL test
2009-08-30 9:18 ` Julia Lawall
@ 2009-08-30 18:26 ` Dmitry Torokhov
-1 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2009-08-30 18:26 UTC (permalink / raw)
To: Julia Lawall; +Cc: linux-input, linux-kernel, kernel-janitors
On Sun, Aug 30, 2009 at 11:18:13AM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> If the NULL test is necessary, then the dereference should be moved below
> the NULL test.
>
Applied, thank you Julia.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/input/keyboard: Move a dereference below a
@ 2009-08-30 18:26 ` Dmitry Torokhov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2009-08-30 18:26 UTC (permalink / raw)
To: Julia Lawall; +Cc: linux-input, linux-kernel, kernel-janitors
On Sun, Aug 30, 2009 at 11:18:13AM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> If the NULL test is necessary, then the dereference should be moved below
> the NULL test.
>
Applied, thank you Julia.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-08-30 18:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-30 9:18 [PATCH] drivers/input/keyboard: Move a dereference below a NULL test Julia Lawall
2009-08-30 9:18 ` Julia Lawall
2009-08-30 18:26 ` Dmitry Torokhov
2009-08-30 18:26 ` [PATCH] drivers/input/keyboard: Move a dereference below a Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.