From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: "Teresa Gámez" <t.gamez@phytec.de>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 1/2] mt9v022: fix pixel clock
Date: Thu, 7 Apr 2011 13:08:11 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.1104071303001.26842@axis700.grange> (raw)
In-Reply-To: <1302098515-12176-1-git-send-email-t.gamez@phytec.de>
On Wed, 6 Apr 2011, Teresa Gámez wrote:
> Measurements show that the setup of the pixel clock is not correct.
> The 'Invert Pixel Clock' bit has to be set to 1 for falling edge
> and not for rising.
Doesn't seem correct to me. The mt9v022 datasheet says:
<quote>
Invert pixel clock. When set, LINE_VALID,
FRAME_VALID, and DOUT is set up to the rising edge
of pixel clock, PIXCLK. When clear, they are set up to
the falling edge of PIXCLK.
</quote>
and this works for present mt9v022 configurations, which include at least
two boards: PXA270-based arch/arm/mach-pxa/pcm990-baseboard.c and i.MX31
based arch/arm/mach-mx3/mach-pcm037.c. If this is different for your
board, maybe you have to set the SOCAM_SENSOR_INVERT_PCLK flag in your
"struct soc_camera_link" instance.
Thanks
Guennadi
> Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
> ---
> drivers/media/video/mt9v022.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/mt9v022.c b/drivers/media/video/mt9v022.c
> index 6a784c8..dec2a69 100644
> --- a/drivers/media/video/mt9v022.c
> +++ b/drivers/media/video/mt9v022.c
> @@ -228,7 +228,7 @@ static int mt9v022_set_bus_param(struct soc_camera_device *icd,
>
> flags = soc_camera_apply_sensor_flags(icl, flags);
>
> - if (flags & SOCAM_PCLK_SAMPLE_RISING)
> + if (flags & SOCAM_PCLK_SAMPLE_FALLING)
> pixclk |= 0x10;
>
> if (!(flags & SOCAM_HSYNC_ACTIVE_HIGH))
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
next prev parent reply other threads:[~2011-04-07 11:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 14:01 [PATCH 1/2] mt9v022: fix pixel clock Teresa Gámez
2011-04-06 14:01 ` [PATCH 2/2] mt9m111: " Teresa Gámez
2011-04-07 11:25 ` Guennadi Liakhovetski
2011-05-18 11:12 ` Guennadi Liakhovetski
2011-05-19 11:07 ` Teresa Gamez
2011-04-07 11:08 ` Guennadi Liakhovetski [this message]
2011-04-07 12:38 ` [PATCH 1/2] mt9v022: " Teresa Gamez
[not found] ` <OF0E7310A6.B4F9559D-ONC125786B.003E2F29-C125786B.004202D7@phytec.de>
2011-04-07 12:41 ` Antwort: " Guennadi Liakhovetski
2011-04-08 13:27 ` Teresa Gamez
2011-04-12 11:22 ` Teresa Gamez
2011-04-13 6:31 ` Guennadi Liakhovetski
2011-04-14 14:33 ` Teresa Gamez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1104071303001.26842@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=linux-media@vger.kernel.org \
--cc=t.gamez@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.