All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sage Weil <sage@newdream.net>
To: huang jun <hjwsm1989@gmail.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: the messenger to send osd write ack|ondisk
Date: Tue, 6 Sep 2011 22:15:48 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.1109062214560.7331@cobra.newdream.net> (raw)
In-Reply-To: <Pine.LNX.4.64.1109062058240.7748@cobra.newdream.net>

On Tue, 6 Sep 2011, Sage Weil wrote:
> Ah, nice catch.  This fixes it:
> 
> diff --git a/src/osd/ReplicatedPG.cc b/src/osd/ReplicatedPG.cc
> index 73b42ac..48ee6bb 100644
> --- a/src/osd/ReplicatedPG.cc
> +++ b/src/osd/ReplicatedPG.cc
> @@ -2817,7 +2817,7 @@ void ReplicatedPG::eval_repop(RepGather *repop)
>           reply = new MOSDOpReply(op, 0, osd->osdmap->get_epoch(), 0);
>         reply->add_flags(CEPH_OSD_FLAG_ACK);
>         dout(10) << " sending ack on " << *repop << " " << reply << dendl;
> -       osd->cluster_messenger->send_message(reply, op->get_connection());
> +       osd->client_messenger->send_message(reply, op->get_connection());
>         repop->sent_ack = true;
>        }
> 
> Pushing to master.

Er, looks like Greg already pushed this fix on Sunday!

sage

  reply	other threads:[~2011-09-07  5:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-07  4:00 the messenger to send osd write ack|ondisk Sage Weil
2011-09-07  5:15 ` Sage Weil [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-09-03  2:28 huang jun
2011-09-06 16:37 ` Tommi Virtanen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1109062214560.7331@cobra.newdream.net \
    --to=sage@newdream.net \
    --cc=ceph-devel@vger.kernel.org \
    --cc=hjwsm1989@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.