All of lore.kernel.org
 help / color / mirror / Atom feed
From: peter fuerst <post@pfrst.de>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] Impact video driver for SGI Indigo2
Date: Tue, 13 Sep 2011 11:39:20 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.1109131101530.4143@Indigo2.Peter> (raw)



Hi Sergei,

On Mon, 12 Sep 2011, Sergei Shtylyov wrote:

> Date: Mon, 12 Sep 2011 13:56:36 +0400
> From: Sergei Shtylyov <sshtylyov@mvista.com>
> To: post@pfrst.de
> Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
>     attilio.fiandrotti@gmail.com
> Subject: Re: [PATCH] Impact video driver for SGI Indigo2
> 
> ...
>> framebuffer device. Without the support of PCI & AGP.
>
>   It looks like the patch is spoiled as I'm seeing two spaces at the start
> of line when looking at the message source.

hmmm, that's a strange problem. The two spaces are not in the diff-file
read into the eMail and are not displayed by the MUA (pine 4.64). But
indeed, where's a leading space in the diff, there's an additional space
inserted into the eMail-body. Have to find out the best way to suppress
this behaviour...

>
>>
>> ...
>
>   There are alos empty lines after each file in the patch -- which
> shouldn't be there.

These were intended for readability (reviewability :), but i can remove
them easily (of course).

>
>> diff --git a/drivers/video/Makefile b/drivers/video/Makefile
>> ...
>
>   The above should be a part of the driver patch, as you can't add Makefile
> targets fow which no source files exist yet.
>

Do you suggest to submit the ip22-setup.c-, impact.h-, impact.c-parts
alone in a first patch and then, in a separate follow-up patch, the
Kconfig- and Makefile-parts, or just to reorder the parts in this single
patch?

>> diff --git a/arch/mips/sgi-ip22/ip22-setup.c
>> ...
>> + if (sgi_gfxaddr < 0x1f000000 || 0x1fa00000 <= sgi_gfxaddr)
>
>   Immediate should generally be the right operand in comparison.

This can be changed, should the "if (a is outside the range...)"
notation be confusing or the like.

> ...
>
>   I lack the time to review such a large driver, unfortunately...
>
> WBR, Sergei
>

with kind regards

peter

             reply	other threads:[~2011-09-13  9:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-13  9:39 peter fuerst [this message]
2011-09-13 10:03 ` [PATCH] Impact video driver for SGI Indigo2 Jayachandran C.
2011-09-13 10:38 ` Sergei Shtylyov
2011-09-13 12:20   ` peter fuerst
2011-09-13 13:03   ` peter fuerst
  -- strict thread matches above, loose matches on Subject: below --
2011-09-11 11:14 peter fuerst
2011-09-12  9:56 ` Sergei Shtylyov
2011-09-13 12:43 ` Joshua Kinard
2011-09-14 14:50   ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1109131101530.4143@Indigo2.Peter \
    --to=post@pfrst.de \
    --cc=linux-mips@linux-mips.org \
    --cc=sshtylyov@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.