All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Q] .readable_reg() not verified during read?
Date: Mon, 29 Oct 2012 08:40:55 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.64.1210290833440.17869@axis700.grange> (raw)
In-Reply-To: <20121028180629.GB4547@opensource.wolfsonmicro.com>

On Sun, 28 Oct 2012, Mark Brown wrote:

> On Sun, Oct 28, 2012 at 12:36:40AM +0200, Guennadi Liakhovetski wrote:
> 
> > Looking at regmap.c it looks like the .readable_reg() callback is not 
> > consulted when performing a register read, e.g. in _regmap_raw_read(). Is 
> > this intentional? If yes - why?
> 
> No real reason, though to be honest it's not that important - the main
> reason for having the function is to make the debugfs stuff work nicely
> rather than anything else.

But what about initialising the register cache in regcache_hw_init()? 
Doesn't it read in all registers without checking their readability?

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

  reply	other threads:[~2012-10-29  7:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-27 22:36 [Q] .readable_reg() not verified during read? Guennadi Liakhovetski
2012-10-28 18:08 ` Mark Brown
2012-10-29  7:40   ` Guennadi Liakhovetski [this message]
2012-10-29 16:13     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1210290833440.17869@axis700.grange \
    --to=g.liakhovetski@gmx.de \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.