All of lore.kernel.org
 help / color / mirror / Atom feed
From: Palle Lyckegaard <palle@lyckegaard.dk>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] Get sh right on OpenSolaris/SPARC
Date: Wed, 4 Mar 2009 21:04:38 +0000 (UTC)	[thread overview]
Message-ID: <Pine.NEB.4.64.0903022047120.15645@otaku.freeshell.org> (raw)


The patch below solves a problem when building qemu on OpenSolaris/SPARC.

"feature_to_c.sh: test: argument expected"

There seemes to be a problem with how "features_to_c.sh" is started from 
the makefile. On Solaris the shell in /bin/sh is not standards compliant 
according to http://docs.sun.com/app/docs/doc/816-5165/sh-1?a=view 
so the patch fixes the configure script so a proper sh in located in 
/usr/xpg4/bin when building on OpenSolaris. Other platforms defaults to 
whatever is in the path when configure is running.

Please consider this patch so qemu builds out-of-the-box for 
OpenSolaris...

Best regards
Palle

------ start of patch

Index: configure
===================================================================
--- configure   (revision 6657)
+++ configure   (working copy)
@@ -34,6 +34,7 @@
  make="make"
  install="install"
  strip="strip"
+shell="`which sh`"

  # parse CC options first
  for opt do
@@ -263,6 +264,7 @@
  SunOS)
      solaris="yes"
      make="gmake"
+    shell="/usr/xpg4/bin/sh"
      install="ginstall"
      needs_libsunmath="no"
      solarisrev=`uname -r | cut -f2 -d.`
@@ -1178,6 +1180,7 @@
  echo "INSTALL=$install" >> $config_mak
  echo "CC=$cc" >> $config_mak
  echo "HOST_CC=$host_cc" >> $config_mak
+echo "SHELL=$shell" >> $config_mak
  echo "AR=$ar" >> $config_mak
  echo "STRIP=$strip -s -R .comment -R .note" >> $config_mak
  # XXX: only use CFLAGS and LDFLAGS ?


------ end of patch

             reply	other threads:[~2009-03-04 21:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-04 21:04 Palle Lyckegaard [this message]
2009-03-04 21:30 ` [Qemu-devel] [PATCH] Get sh right on OpenSolaris/SPARC Stefan Weil
2009-03-04 22:08 ` Anthony Liguori
2009-03-17 19:37   ` Palle Lyckegaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.NEB.4.64.0903022047120.15645@otaku.freeshell.org \
    --to=palle@lyckegaard.dk \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.