Re: [OE-core] [meta-oe][PATCH] wic/direct.py: ignore root mountpoint in fstab updater

From: Markus Volk <f_l_k@t-online.de>
To: Ross Burton <Ross.Burton@arm.com>
Cc: tobiasschmidl@siemens.com, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [meta-oe][PATCH] wic/direct.py: ignore root mountpoint in fstab updater
Date: Tue, 02 Aug 2022 16:05:14 +0200	[thread overview]
Message-ID: <Q4RZFR.Q72GTSVZXCK3@t-online.de> (raw)
In-Reply-To: <536911C2-925C-47AF-A369-9453B5900916@arm.com>

[-- Attachment #1: Type: text/plain, Size: 821 bytes --]

Maybe we could do like this in base-files.bb ?

FSTAB_HAVE_WIC = "${@bb.utils.contains('IMAGE_FSTYPES', 'wic', 'true', 
'false', d)}"
FSTAB_WIC_UPDATER = "${@bb.utils.contains('WIC_CREATE_EXTRA_ARGS', 
'--no-fstab-update', 'false', 'true', d)}"

do_install:append() {
	if [ ${FSTAB_HAVE_WIC} = true ] && [ ${FSTAB_WIC_UPDATER} = true ]; 
then
		sed -i '/\/dev\/root/d' ${D}${sysconfdir}/fstab
	fi
}

This would remove the hardcoded '/dev/root' entry  if all conditions 
are met to add the root entry with wic fstab-update
> \rIt’s looking like the easiest fix here is to revert your patch, so 
> at least we don’t have warnings and unexpected behaviour on boot.  
> Unless you’re willing to rework your patch so that it allows edits 
> to the root mount point but doesn’t end up creating duplicates?

[-- Attachment #2: Type: text/html, Size: 1299 bytes --]