All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: 周琰杰 <zhouyanjie@wanyeetech.com>
Cc: gregkh@linuxfoundation.org, hminas@synopsys.com,
	robh+dt@kernel.org, krzk+dt@kernel.org,
	tsbogend@alpha.franken.de, linux-usb@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, dongsheng.qiu@ingenic.com,
	aric.pzqi@ingenic.com, rick.tyliu@ingenic.com,
	sernia.zhou@foxmail.com, zhenwenjin@gmail.com,
	reimu@sudomaker.com
Subject: Re: [PATCH v4 1/3] dt-bindings: dwc2: Add bindings for new Ingenic SoCs.
Date: Fri, 22 Apr 2022 13:44:50 +0100	[thread overview]
Message-ID: <QERQAR.SQYC38Q7CE0Z2@crapouillou.net> (raw)
In-Reply-To: <1650561308-54704-2-git-send-email-zhouyanjie@wanyeetech.com>

Hi Zhou,

Le ven., avril 22 2022 at 01:15:06 +0800, 周琰杰 (Zhou Yanjie) 
<zhouyanjie@wanyeetech.com> a écrit :
> Add the dwc2 bindings for the JZ4775 SoC, the JZ4780 SoC, the X1000 
> SoC,
> the X1600 SoC, the X1830 SoC, and the X2000 SoC from Ingenic.
> 
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> 
> Notes:
>     v1->v2:
>     Add Rob Herring's Acked-by.
> 
>     v2->v3:
>     No change.
> 
>     v3->v4:
>     Remove the compatible string of X1700 since it could use the 
> X1600 string
>     as the fallback.
> 
>  Documentation/devicetree/bindings/usb/dwc2.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml 
> b/Documentation/devicetree/bindings/usb/dwc2.yaml
> index 4cebce6..2218df8 100644
> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
> @@ -17,6 +17,12 @@ properties:
>      oneOf:
>        - const: brcm,bcm2835-usb
>        - const: hisilicon,hi6220-usb
> +      - const: ingenic,jz4775-otg
> +      - const: ingenic,jz4780-otg
> +      - const: ingenic,x1000-otg
> +      - const: ingenic,x1600-otg
> +      - const: ingenic,x1830-otg
> +      - const: ingenic,x2000-otg

You should probably also add:
- items:
    - const: ingenic,x1700-otg
    - const: ingenic,x1600-otg

As discussed in your v3.

Cheers,
-Paul

>        - items:
>            - const: rockchip,rk3066-usb
>            - const: snps,dwc2
> --
> 2.7.4
> 



  reply	other threads:[~2022-04-22 12:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-21 17:15 [PATCH v4 0/3] Add OTG support for Ingenic SoCs 周琰杰 (Zhou Yanjie)
2022-04-21 17:15 ` [PATCH v4 1/3] dt-bindings: dwc2: Add bindings for new " 周琰杰 (Zhou Yanjie)
2022-04-22 12:44   ` Paul Cercueil [this message]
2022-04-22 17:57     ` Zhou Yanjie
2022-04-21 17:15 ` [PATCH v4 2/3] USB: dwc2: Add OTG support for " 周琰杰 (Zhou Yanjie)
2022-04-21 17:15 ` [PATCH v4 3/3] MIPS: Ingenic: Refresh USB nodes to match driver changes 周琰杰 (Zhou Yanjie)
2022-04-22  8:30 ` [PATCH v4 0/3] Add OTG support for Ingenic SoCs Greg KH
2022-04-22 15:57   ` Zhou Yanjie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=QERQAR.SQYC38Q7CE0Z2@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=aric.pzqi@ingenic.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dongsheng.qiu@ingenic.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hminas@synopsys.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=reimu@sudomaker.com \
    --cc=rick.tyliu@ingenic.com \
    --cc=robh+dt@kernel.org \
    --cc=sernia.zhou@foxmail.com \
    --cc=tsbogend@alpha.franken.de \
    --cc=zhenwenjin@gmail.com \
    --cc=zhouyanjie@wanyeetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.