From: "Barnabás Pőcze" <pobrn@protonmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Luke D. Jones" <luke@ljones.dev>,
corentin.chary@gmail.com, mgross@linux.intel.com,
jdelvare@suse.com, linux@roeck-us.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] asus-wmi: Add dgpu disable method
Date: Thu, 08 Jul 2021 17:09:40 +0000 [thread overview]
Message-ID: <QwL-txKgshTDtkHPjQ1gnufO18a6waLR7e2WEVmJbo3T7s3xs6jW6vnbzhtOyyDpQHyDi7q7ObEDWCE_YV8KwrBGHZmsDA6LInznCqeFzj0=@protonmail.com> (raw)
In-Reply-To: <e933f74e-50d3-8de9-258a-a4000f3b6403@redhat.com>
Hi
2021. július 6., kedd 12:17 keltezéssel, Hans de Goede írta:
> [...]
> >> @@ -2699,6 +2792,10 @@ static int asus_wmi_add(struct platform_device *pdev)
> >> if (err)
> >> goto fail_platform;
> >>
> >> + err = dgpu_disable_check_present(asus);
> >> + if (err)
> >> + goto fail_dgpu_disable;
> >> +
> >
> > Should this really be considered a "fatal" error?
>
> Well dgpu_disable_check_present() does already contain:
>
> if (err == -ENODEV)
> return 0;
>
> IOW it only returns an error on unexpected errors and asus_wmi_add()
> already contains a couple of other foo_present() checks which are
> dealt with in the same way, so this is consistent with that and
> being consistent is good, so I think this is fine.
>
Indeed, that's right, I missed that. I am still unsure whether any error
should cause it to fail to load. But I guess if there is precedent for that
in the module, then consistency is probably better.
Regards,
Barnabás Pőcze
next prev parent reply other threads:[~2021-07-08 17:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-04 22:21 [PATCH 0/3] Support for ASUS egpu, dpgu disable, panel overdrive Luke D. Jones
2021-07-04 22:21 ` [PATCH 1/3] asus-wmi: Add panel overdrive functionality Luke D. Jones
2021-07-04 23:48 ` kernel test robot
2021-07-04 23:48 ` kernel test robot
2021-07-06 10:07 ` Hans de Goede
2021-07-06 10:08 ` Hans de Goede
2021-07-04 22:21 ` [PATCH 2/3] asus-wmi: Add dgpu disable method Luke D. Jones
2021-07-05 0:47 ` Barnabás Pőcze
2021-07-06 10:17 ` Hans de Goede
2021-07-08 17:09 ` Barnabás Pőcze [this message]
2021-07-16 23:09 ` Luke Jones
2021-07-06 10:10 ` Hans de Goede
2021-07-16 23:12 ` Luke Jones
2021-07-04 22:21 ` [PATCH 3/3] asus-wmi: Add egpu enable method Luke D. Jones
2021-07-06 10:19 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='QwL-txKgshTDtkHPjQ1gnufO18a6waLR7e2WEVmJbo3T7s3xs6jW6vnbzhtOyyDpQHyDi7q7ObEDWCE_YV8KwrBGHZmsDA6LInznCqeFzj0=@protonmail.com' \
--to=pobrn@protonmail.com \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jdelvare@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luke@ljones.dev \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.