From: Lucas Mateus Martins Araujo e Castro <lucas.araujo@eldorado.org.br>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Bruno Piazera Larsen <bruno.larsen@eldorado.org.br>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: target/ppc: sPAPR invalid function calls when compiling without TCG
Date: Tue, 20 Apr 2021 18:27:38 +0000 [thread overview]
Message-ID: <RO1PR80MB561024219A35A26C418CF51BCE489@RO1PR80MB5610.lamprd80.prod.outlook.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]
________________________________
>> spapr_hcall.c:
>> function h_enter call ppc_hash64_hpte_page_shift_noslb, ppc_hash64_map_hptes and ppc_hash64_unmap_hptes
>> function remove_hpte call ppc_hash64_map_hptes, ppc_hash64_unmap_hptes and ppc_hash64_tlb_flush_hpte
>> function h_protect call ppc_hash64_map_hptes, ppc_hash64_unmap_hptes and ppc_hash64_tlb_flush_hpte
>> function h_read call ppc_hash64_map_hptes and ppc_hash64_unmap_hptes
>> function rehash_hpte call ppc_hash64_hpte_page_shift_noslb
>> function rehash_hpt call ppc_hash64_map_hptes and ppc_hash64_unmap_hptes
>
>h_enter, remove_hpte, h_protect, h_read and rehash_hpte should never
>be called for a KVM guest (KVM will intercept the relevant hcalls
>before they reach qemu). I think it would make sense to split of a
>TCG only portion of spapr_hcall.c into a new file. You'll then
>probably need !TCG stubs for those hypercalls, which should trip a
>fatal error (if KVM hasn't handled the calls, there's nothing we can
>do that will salvage the situation).
Besides the aforementioned functions, will all spapr hypercalls beginning with H_* be intercepted
(and therefore, should trip a fatal error in the KVM-only file) or only a subset of these functions will
be intercepted? If the latter is there an interval of opcodes that'll be intercepted?
[-- Attachment #2: Type: text/html, Size: 2358 bytes --]
next reply other threads:[~2021-04-20 18:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 18:27 Lucas Mateus Martins Araujo e Castro [this message]
2021-04-21 4:06 ` target/ppc: sPAPR invalid function calls when compiling without TCG David Gibson
-- strict thread matches above, loose matches on Subject: below --
2021-04-19 19:04 Lucas Mateus Martins Araujo e Castro
2021-04-20 0:09 ` David Gibson
2021-04-14 18:28 Lucas Mateus Martins Araujo e Castro
2021-04-19 5:17 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=RO1PR80MB561024219A35A26C418CF51BCE489@RO1PR80MB5610.lamprd80.prod.outlook.com \
--to=lucas.araujo@eldorado.org.br \
--cc=bruno.larsen@eldorado.org.br \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.