From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5701CC4332F for ; Thu, 24 Nov 2022 01:22:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D17F2855CC; Thu, 24 Nov 2022 02:22:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com header.b="0RDN8gkv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9FEE183623; Thu, 24 Nov 2022 02:22:48 +0100 (CET) Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on20727.outbound.protection.outlook.com [IPv6:2a01:111:f403:704b::727]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8DA60855D1 for ; Thu, 24 Nov 2022 02:22:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ryan_chen@aspeedtech.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n+DLpBOqFbj+KRda6IQCay1JVdeb9VqqhWMxfFc/OA7ywERh7O1WC13c5veXLAvoc8704OlSSwrMdobgiuPW0914UJ++XYIGnSztzPTR8Spihv+2l3VDE5Yfm/WKXL7ncKKgsQ87JxyEIDTCzlha0K4H+Z2oIUc8YG2BbQFT+kvj4AqKaJUqmHDZwptnUYnXUczkpgFFjIJHDkIwWcbJZFbTvUtiFL6DdkDExjM3roqwT9vRAko5nEB9a2aDzP39SwyPN4aiqNV7tMS6a3rCrJWzrWQomU9etvhXpqoAxHfpGWPbfPexlLwNJyBKP7ZvcGN9KD9J5l37eUU4dYaRFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6ps/v3qbRH0rDSAfRjw7xKYiTF+O10C0cL5jS/59B2c=; b=ogovJ6b3sGyAM5bXiNwULzitkREwUycgFLMUIhpZ/w4CT8W6zvsvTyLsZ0J/kntMfxRISgiAqBK0dazfK5CMfXSUZBJXcxL0YvmA5kTZP9uAKNlIeH6xIZD25vfrj/0da3fjaW3R8F+d8vRu1RZc4zX8JURn0ttI8Iv4CWFICEhTI5pCsiyw5+cB4an3P7SK1jWrxY9DsdDiCYmPdgsONR0vM+l0GOuz6woglBk0EHXyD1CbZopkyGADco1muERbv+OVQV8GGnbYHThLE1jIrMczI5hKvqNb0wClsT7FJrZ4+p7ghpZ5u1y1NywXXNQvjjJcj4hHKs87hFnLMirU8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6ps/v3qbRH0rDSAfRjw7xKYiTF+O10C0cL5jS/59B2c=; b=0RDN8gkvZPVVSiTsqirNUqKvbvw+UxzWraDjNpiXACsTk+TWKJd+c28nFqfMsBNvrFLHRbD546qeUeZwc12prliqLvOCVGoEhF4ibGVt6Gm5HqBpue3LAGfHCOX8dqTLzcQ+r4v9QmwzL8/6m18bldZZ+//LtKPv443O/SdQieZc3+IYcWtGdaTGgE7mcdaED5Z4wuiIljyHXFhWoUSHsUmaviO/3zUz5kTLUyQmX6ep+kxSSilkJuju4G3NPgbm/ROCeWUkChWBnSscLsvyYoRRnr3fbLi9mgf5/fYi1MbtyUc6kAAfclzh7SP9v3MUeBfgzNeW9eii83u/InIVrg== Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by PUZPR06MB5745.apcprd06.prod.outlook.com (2603:1096:301:f6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Thu, 24 Nov 2022 01:22:30 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::1230:5f04:fe98:d139]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::1230:5f04:fe98:d139%7]) with mapi id 15.20.5834.015; Thu, 24 Nov 2022 01:22:30 +0000 From: Ryan Chen To: Dylan Hung , ChiaWei Wang , "joel@jms.id.au" , "u-boot@lists.denx.de" CC: BMC-SW Subject: RE: [PATCH 1/3] ram: ast2600: Fix incorrect statement of the register polling Thread-Topic: [PATCH 1/3] ram: ast2600: Fix incorrect statement of the register polling Thread-Index: AQHY9Z916XX4E79fPUOTVKnFThraQK5NWycg Date: Thu, 24 Nov 2022 01:22:30 +0000 Message-ID: References: <20221111073008.16364-1-dylan_hung@aspeedtech.com> <20221111073008.16364-2-dylan_hung@aspeedtech.com> In-Reply-To: <20221111073008.16364-2-dylan_hung@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SEZPR06MB5269:EE_|PUZPR06MB5745:EE_ x-ms-office365-filtering-correlation-id: 7fe727bc-c922-4046-9b5d-08dacdba5b46 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QSfC+47KZmkQnMgquivGawsMv0f7lU5jIpUOObsJsQyozpneDwNwUXw2QTTfk4xbZpIHmxaX6vSD4BMNq/ncjxNo9igoIWiE6cD8ynnly3bWOw0sTXjmL+3BVlQSTqmIcvPKB3Zv4KJdE5Z+jUdH47QWwbJIylSRo7ZHucjH1scf7DiFkGavhsjud+vMsAja5wSje3Kq14io7LTtoEP2EGs+8mDG32ozeNNLX471yvuUIyGFw02UbNo/uuerO56RxDHsycutcw2aYM+fTHppX0h328aSCi8Sy4AdxLbKd3ch35b6BqGQBr+oScQvKk2oYJ35aKZHv45Txy4pvYxSJL5c1xz8nfKDpUaPTi7b8Ke9I7kKTQuMDGnFLq8k2065BWCNqYj8Fs36Xu4ET6L3+sFyetg1SOGHpBnEUXxJITvzwusqVdKDB1owav2nfULW+O7T8rZ1W1EXtwGYBPVKJ76vf1277/idRX02fP9ZTOP2VQDPna/T7lM2TMB68YYc0dOJkaqhsvQv4RbZl2OwIae+bL3UIlf17NeMZI21O7MFiKJVsr6f99c0Tw1J3J/LIeooHPQC38L++JG8Tw0LhXSrKQvyoSk1jIICCBJkpJu49jM5EQd//CmU5nje3OcYDD45mhJ+P6Qzap4jRo3Ced5WkGIBdxDPabRMpBfUHqGpzxfgnMXzX9O16xJpW/0bdgnAfkAZAn633RDZKA+dIg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39850400004)(366004)(376002)(396003)(346002)(136003)(451199015)(38100700002)(76116006)(478600001)(33656002)(107886003)(55016003)(71200400001)(316002)(9686003)(26005)(86362001)(38070700005)(66556008)(66446008)(66476007)(66946007)(64756008)(8676002)(4326008)(53546011)(110136005)(6506007)(7696005)(41300700001)(122000001)(2906002)(83380400001)(5660300002)(52536014)(186003)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MgwWomGiFFwggZEh8Zda2Cowmp8BUElcueQ1Btx9Jbmn+aNue6FLihUFvLcL?= =?us-ascii?Q?Zap/dsW1XI1bY9WdLqF9Nfg5fRyyrGv674FWhzjfUD16yEsD+bxAo/NhaZLd?= =?us-ascii?Q?1YeI8rdhddgyHFzDIlOvg/tE8mE6FU8700joQXzmUQKentWl0NdA90dCPErt?= =?us-ascii?Q?uOiCIMehE2bi2wgk1WxWfJ9aJZrzW+tQ2TgPGp2LwVSYNg3cSE4vP5rggaV7?= =?us-ascii?Q?+DzjIq2qA18tq2dOjdVL29N8rmnbWRhD1V36DgDbWsqomw5hGbNly4AeJLoM?= =?us-ascii?Q?3Dgka2QqdNmG2ijKLEKLYD6r4hO6FgvClObleYUe6bvWHln5yd8hfRRpewp3?= =?us-ascii?Q?XndaCfBJzWwNJWXyaC2US5p2RIgw3j9R9zJGxR9MvpXcPgqrmp6ehFQ1amx8?= =?us-ascii?Q?uyAovw7SkF3hsG/PIdQIjjrua9hvqyF66ZUwMDm80RnKWrAz3W0rjoXBVVng?= =?us-ascii?Q?hUssx9XQwpFiTSY4c0YgCVN3vHd6q37uvQvdYUjWC0o8pKE5gKf9nLp8cbTt?= =?us-ascii?Q?pb20Y5dKa8qoEs2MV6U9i97SJ61Oyc4rwAJgyP2n/gpTzVIhhJ7qXVQe37M/?= =?us-ascii?Q?4jnE35VjGKWjDTGww2U54huJ+7cvGNiiEx4IzjndH+dTKLzprG/Q8kAL6RFY?= =?us-ascii?Q?G8YpLJB1uWLbd6RWqBHCMqMfbaIfK7B5s13wQ+CJUjnBqQgt26SPC8Dfn+qU?= =?us-ascii?Q?80H+lWdtHQXeAIyGtjlYODAbet9/zfaRTr0Q4xWoFv6Jb6NEsH2apxwj2PfD?= =?us-ascii?Q?N1Xod1RnNpkzAUpmKjbl+L+ZcWqa1wIB1q6XAT8u3KClaMleGapD6A+25dqM?= =?us-ascii?Q?t3eSEs2/Cmb6MbmEFY2pnSbX/YZOKFyRgCq8qoOwzqGyWTimkvn9h1Bbqshq?= =?us-ascii?Q?RHqXnIAD3Wr3tNjYGb8rBL+HOxmn4jkYvS3AWmPo1JWWtIOXti/Omums3bWp?= =?us-ascii?Q?d4TsG0CNwi8JgmwEtgpSxJMFq3g12fhpG6lIku5jm7W2/eG2ujQfaaNNOVHu?= =?us-ascii?Q?S+bjNtOt8GzpHm8dUSH8gW9sQ9mn+Ic2Zr5HS0Bnye2stvog6M0MME5ktLv+?= =?us-ascii?Q?vLihJ/7H9sjxJbUG+oGA0xLO1Tuku9/sag/KOJH7iOYaDc3IyQXdaDzjZEit?= =?us-ascii?Q?+c6OcmmI7zfHZLtrwrt1byw775PdCSUysz3k9FSJioktFCfZczIZGW4rY2o1?= =?us-ascii?Q?FyxiUE7F+HFjzImgo4lC5KYZWkCDZpLAdqXb6tDoCr5D3q27XsT93N3A2CZw?= =?us-ascii?Q?jnUDlmIfus5/NUNGabdeLp0S2z1//eNG1VM3ACIcDvWLGt9WyaueN5/pY8oT?= =?us-ascii?Q?7T0KEx7TpqBI0KxdoYS6R4RS+iga6hOF8fJj6+bzZCelCAWmsYQ/7Rm5ykIS?= =?us-ascii?Q?fL4e9W0/0/JRCKOkRKN5dxIflpN8voUlSeN6ELaLOgV3+N9dYN3B9hy6GiKh?= =?us-ascii?Q?rBkzZo22Cu7oJIv8se9MpsmTWkDjFmjxhwgkdHPKxPQmnB1l34/ByI742Bj0?= =?us-ascii?Q?R3IDhUnqbYdjQfJtfW3i2VtizLjuDJ1MCY7Hm5KHJ/8M1XDUUfhCurjNMgdP?= =?us-ascii?Q?iea2GtQWBybMSbJ8Ko7dQLfGmmWjv+ID9V91ohhy?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fe727bc-c922-4046-9b5d-08dacdba5b46 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2022 01:22:30.4686 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ovN6b82O0jD1iTgKpf6VEolZq3WDnEP2L9WcG8e+cuUUMjYMVTPlxqF4Dt6gMF6ZCzmoDsENwhul9+4IJWX/mtLobpfbgK5w92N4sSxaDdk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB5745 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean > -----Original Message----- > From: Dylan Hung > Sent: Friday, November 11, 2022 3:30 PM > To: Ryan Chen ; ChiaWei Wang > ; joel@jms.id.au; Dylan Hung > ; u-boot@lists.denx.de > Cc: BMC-SW > Subject: [PATCH 1/3] ram: ast2600: Fix incorrect statement of the registe= r > polling >=20 > The condition "~data" in the if-statement is a typo. The original intent= ion is > to poll if SDRAM_PHYCTRL0_INIT bit equals to 0. So use "data =3D=3D 0" fo= r > instead. >=20 > Besides, the bit[1] of "phy_status" register is hardwired to > SDRAM_PHYCTRL0_INIT (with inverse logic). Since SDRAM_PHYCTRL0_INIT has > already done, remove the unnecessary checking of phy_status[1]. >=20 > Fixes: fde93143469f ("ram: aspeed: Add AST2600 DRAM control support") >=20 > Signed-off-by: Dylan Hung Review-by: Ryan Chen > --- > drivers/ram/aspeed/sdram_ast2600.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) >=20 > diff --git a/drivers/ram/aspeed/sdram_ast2600.c > b/drivers/ram/aspeed/sdram_ast2600.c > index 9ad398d24155..b09232a30413 100644 > --- a/drivers/ram/aspeed/sdram_ast2600.c > +++ b/drivers/ram/aspeed/sdram_ast2600.c > @@ -449,7 +449,7 @@ static void ast2600_sdramphy_kick_training(struct > dram_info *info) >=20 > while (1) { > data =3D readl(®s->phy_ctrl[0]) & SDRAM_PHYCTRL0_INIT; > - if (~data) > + if (data =3D=3D 0) > break; > } > } > @@ -984,11 +984,6 @@ static int ast2600_sdrammc_probe(struct udevice > *dev) > L_ast2600_sdramphy_train: > ast2600_sdrammc_init_ddr4(priv); >=20 > - /* make sure DDR-PHY is ready before access */ > - do { > - reg =3D readl(priv->phy_status) & BIT(1); > - } while (reg =3D=3D 0); > - > if (ast2600_sdramphy_check_status(priv) !=3D 0) { > printf("DDR4 PHY training fail, retrain\n"); > goto L_ast2600_sdramphy_train; > -- > 2.25.1