All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Brandt <Chris.Brandt@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>, Rob Herring <robh@kernel.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Simon Horman <horms+renesas@verge.net.au>,
	RTCLINUX <rtc-linux@googlegroups.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: [rtc-linux] RE: [PATCH v2 2/7] rtc: Add rtc-sh
Date: Wed, 29 Mar 2017 14:14:20 +0000	[thread overview]
Message-ID: <SG2PR06MB11657A015A46C48CDD3858978A350@SG2PR06MB1165.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdVmwJYMzspVeDqToBrkfK+zGLMNhxGvEbqCA-vuCUXqoQ@mail.gmail.com>

On Wednesday, March 29, 2017, Geert Uytterhoeven wrote:
> >> +Example:
> >> +rtc: rtc@fcff1000 {
> >> +     compatible = "renesas,r7s72100-rtc", "renesas,sh-rtc";
> >> +     reg = <0xfcff1000 0x2e>;
> >> +     interrupts = <GIC_SPI 276 IRQ_TYPE_EDGE_RISING
> >> +                   GIC_SPI 277 IRQ_TYPE_EDGE_RISING
> >> +                   GIC_SPI 278 IRQ_TYPE_EDGE_RISING>;
> >> +     interrupt-names = "alarm", "period", "carry";
> >> +     clocks = <&mstp6_clks R7S72100_CLK_RTC>, <&rtc_x1_clk>,
> >> +              <&rtc_x3_clk>, <&extal_clk>;
> >> +     clock-names = "fck", "rtc_x1", "rtc_x3", "extal";
> >> +     power-domains = <&cpg_clocks>;
> >
> > Not documented.
> 
> "power-domains" is a platform property.
> 
> All hardware components need power.
> All synchronous hardware components need a clock.
> Most hardware components have a reset signal.
> 
> Whether these are exposed and can be controlled depends on the
> platform/SoC.
> So documenting them in each and every device binding looks overkill to me.
> I think this is something to be addressed by devicetree-specification
> (which doesn't handle clocks, power-domains, resets yet).
> 
> If you prefer, the property can be removed from the example, though.

I'll go ahead and pull it out (since I have to update the commit title
anyway as per Rob's request)

Besides...it's probably the most least important part of the example ;)

Thanks,
Chris

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

WARNING: multiple messages have this Message-ID
From: Chris Brandt <Chris.Brandt@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>, Rob Herring <robh@kernel.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Simon Horman <horms+renesas@verge.net.au>,
	RTCLINUX <rtc-linux@googlegroups.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v2 2/7] rtc: Add rtc-sh
Date: Wed, 29 Mar 2017 14:14:20 +0000	[thread overview]
Message-ID: <SG2PR06MB11657A015A46C48CDD3858978A350@SG2PR06MB1165.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdVmwJYMzspVeDqToBrkfK+zGLMNhxGvEbqCA-vuCUXqoQ@mail.gmail.com>

On Wednesday, March 29, 2017, Geert Uytterhoeven wrote:
> >> +Example:
> >> +rtc: rtc@fcff1000 {
> >> +     compatible = "renesas,r7s72100-rtc", "renesas,sh-rtc";
> >> +     reg = <0xfcff1000 0x2e>;
> >> +     interrupts = <GIC_SPI 276 IRQ_TYPE_EDGE_RISING
> >> +                   GIC_SPI 277 IRQ_TYPE_EDGE_RISING
> >> +                   GIC_SPI 278 IRQ_TYPE_EDGE_RISING>;
> >> +     interrupt-names = "alarm", "period", "carry";
> >> +     clocks = <&mstp6_clks R7S72100_CLK_RTC>, <&rtc_x1_clk>,
> >> +              <&rtc_x3_clk>, <&extal_clk>;
> >> +     clock-names = "fck", "rtc_x1", "rtc_x3", "extal";
> >> +     power-domains = <&cpg_clocks>;
> >
> > Not documented.
> 
> "power-domains" is a platform property.
> 
> All hardware components need power.
> All synchronous hardware components need a clock.
> Most hardware components have a reset signal.
> 
> Whether these are exposed and can be controlled depends on the
> platform/SoC.
> So documenting them in each and every device binding looks overkill to me.
> I think this is something to be addressed by devicetree-specification
> (which doesn't handle clocks, power-domains, resets yet).
> 
> If you prefer, the property can be removed from the example, though.

I'll go ahead and pull it out (since I have to update the commit title
anyway as per Rob's request)

Besides...it's probably the most least important part of the example ;)

Thanks,
Chris

  reply	other threads:[~2017-03-29 14:14 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22 14:27 [rtc-linux] [PATCH v2 0/7] rtc: Reuse rtc-sh driver to support RZ/A1 Chris Brandt
2017-03-22 14:27 ` Chris Brandt
2017-03-22 14:27 ` Chris Brandt
2017-03-22 14:27 ` [rtc-linux] [PATCH v2 1/7] rtc: rtc-sh: add support for rza series Chris Brandt
2017-03-22 14:27   ` Chris Brandt
2017-03-22 14:27   ` Chris Brandt
2017-03-22 14:27 ` [rtc-linux] [PATCH v2 2/7] rtc: Add rtc-sh Chris Brandt
2017-03-22 14:27   ` Chris Brandt
2017-03-22 14:27   ` Chris Brandt
2017-03-29  1:24   ` [rtc-linux] " Rob Herring
2017-03-29  1:24     ` Rob Herring
2017-03-29  6:49     ` [rtc-linux] " Geert Uytterhoeven
2017-03-29  6:49       ` Geert Uytterhoeven
2017-03-29  6:49       ` Geert Uytterhoeven
2017-03-29 14:14       ` Chris Brandt [this message]
2017-03-29 14:14         ` Chris Brandt
2017-04-04 14:29       ` [rtc-linux] " Rob Herring
2017-04-04 14:29         ` Rob Herring
2017-04-04 14:29         ` Rob Herring
2017-04-04 15:27         ` [rtc-linux] " Geert Uytterhoeven
2017-04-04 15:27           ` Geert Uytterhoeven
2017-04-04 15:27           ` Geert Uytterhoeven
2017-03-22 14:27 ` [rtc-linux] [PATCH v2 3/7] ARM: dts: r7s72100: add rtc clock to device tree Chris Brandt
2017-03-22 14:27   ` Chris Brandt
2017-03-22 14:27   ` Chris Brandt
2017-03-22 14:27 ` [rtc-linux] [PATCH v2 4/7] ARM: dts: r7s72100: add RTC_X clock inputs " Chris Brandt
2017-03-22 14:27   ` Chris Brandt
2017-03-22 14:27   ` Chris Brandt
2017-03-22 14:27 ` [rtc-linux] [PATCH v2 5/7] ARM: dts: r7s72100: add rtc " Chris Brandt
2017-03-22 14:27   ` Chris Brandt
2017-03-22 14:27   ` Chris Brandt
2017-03-22 14:27 ` [rtc-linux] [PATCH v2 6/7] ARM: dts: rskrza1: set rtc_x1 clock value Chris Brandt
2017-03-22 14:27   ` Chris Brandt
2017-03-22 14:27 ` [rtc-linux] [PATCH v2 7/7] ARM: dts: rskrza1: add rtc DT support Chris Brandt
2017-03-22 14:27   ` Chris Brandt
2017-03-22 14:27   ` Chris Brandt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SG2PR06MB11657A015A46C48CDD3858978A350@SG2PR06MB1165.apcprd06.prod.outlook.com \
    --to=chris.brandt@renesas.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=horms+renesas@verge.net.au \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.