From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from relmlie3.idc.renesas.com (relmlor4.renesas.com. [210.160.252.174]) by gmr-mx.google.com with ESMTP id 2si1141150pfz.1.2017.03.29.07.14.24 for ; Wed, 29 Mar 2017 07:14:25 -0700 (PDT) From: Chris Brandt To: Geert Uytterhoeven , Rob Herring CC: Alessandro Zummo , Alexandre Belloni , Mark Rutland , Simon Horman , RTCLINUX , "devicetree@vger.kernel.org" , Linux-Renesas Subject: [rtc-linux] RE: [PATCH v2 2/7] rtc: Add rtc-sh Date: Wed, 29 Mar 2017 14:14:20 +0000 Message-ID: References: <20170322142754.30888-1-chris.brandt@renesas.com> <20170322142754.30888-3-chris.brandt@renesas.com> <20170329012441.bxnkyqui24mymuvr@rob-hp-laptop> In-Reply-To: Content-Type: text/plain; charset=UTF-8 MIME-Version: 1.0 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Wednesday, March 29, 2017, Geert Uytterhoeven wrote: > >> +Example: > >> +rtc: rtc@fcff1000 { > >> + compatible = "renesas,r7s72100-rtc", "renesas,sh-rtc"; > >> + reg = <0xfcff1000 0x2e>; > >> + interrupts = >> + GIC_SPI 277 IRQ_TYPE_EDGE_RISING > >> + GIC_SPI 278 IRQ_TYPE_EDGE_RISING>; > >> + interrupt-names = "alarm", "period", "carry"; > >> + clocks = <&mstp6_clks R7S72100_CLK_RTC>, <&rtc_x1_clk>, > >> + <&rtc_x3_clk>, <&extal_clk>; > >> + clock-names = "fck", "rtc_x1", "rtc_x3", "extal"; > >> + power-domains = <&cpg_clocks>; > > > > Not documented. > > "power-domains" is a platform property. > > All hardware components need power. > All synchronous hardware components need a clock. > Most hardware components have a reset signal. > > Whether these are exposed and can be controlled depends on the > platform/SoC. > So documenting them in each and every device binding looks overkill to me. > I think this is something to be addressed by devicetree-specification > (which doesn't handle clocks, power-domains, resets yet). > > If you prefer, the property can be removed from the example, though. I'll go ahead and pull it out (since I have to update the commit title anyway as per Rob's request) Besides...it's probably the most least important part of the example ;) Thanks, Chris -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Brandt Subject: RE: [PATCH v2 2/7] rtc: Add rtc-sh Date: Wed, 29 Mar 2017 14:14:20 +0000 Message-ID: References: <20170322142754.30888-1-chris.brandt@renesas.com> <20170322142754.30888-3-chris.brandt@renesas.com> <20170329012441.bxnkyqui24mymuvr@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Sender: linux-renesas-soc-owner@vger.kernel.org To: Geert Uytterhoeven , Rob Herring Cc: Alessandro Zummo , Alexandre Belloni , Mark Rutland , Simon Horman , RTCLINUX , "devicetree@vger.kernel.org" , Linux-Renesas List-Id: devicetree@vger.kernel.org T24gV2VkbmVzZGF5LCBNYXJjaCAyOSwgMjAxNywgR2VlcnQgVXl0dGVyaG9ldmVuIHdyb3RlOg0K PiA+PiArRXhhbXBsZToNCj4gPj4gK3J0YzogcnRjQGZjZmYxMDAwIHsNCj4gPj4gKyAgICAgY29t cGF0aWJsZSA9ICJyZW5lc2FzLHI3czcyMTAwLXJ0YyIsICJyZW5lc2FzLHNoLXJ0YyI7DQo+ID4+ ICsgICAgIHJlZyA9IDwweGZjZmYxMDAwIDB4MmU+Ow0KPiA+PiArICAgICBpbnRlcnJ1cHRzID0g PEdJQ19TUEkgMjc2IElSUV9UWVBFX0VER0VfUklTSU5HDQo+ID4+ICsgICAgICAgICAgICAgICAg ICAgR0lDX1NQSSAyNzcgSVJRX1RZUEVfRURHRV9SSVNJTkcNCj4gPj4gKyAgICAgICAgICAgICAg ICAgICBHSUNfU1BJIDI3OCBJUlFfVFlQRV9FREdFX1JJU0lORz47DQo+ID4+ICsgICAgIGludGVy cnVwdC1uYW1lcyA9ICJhbGFybSIsICJwZXJpb2QiLCAiY2FycnkiOw0KPiA+PiArICAgICBjbG9j a3MgPSA8Jm1zdHA2X2Nsa3MgUjdTNzIxMDBfQ0xLX1JUQz4sIDwmcnRjX3gxX2Nsaz4sDQo+ID4+ ICsgICAgICAgICAgICAgIDwmcnRjX3gzX2Nsaz4sIDwmZXh0YWxfY2xrPjsNCj4gPj4gKyAgICAg Y2xvY2stbmFtZXMgPSAiZmNrIiwgInJ0Y194MSIsICJydGNfeDMiLCAiZXh0YWwiOw0KPiA+PiAr ICAgICBwb3dlci1kb21haW5zID0gPCZjcGdfY2xvY2tzPjsNCj4gPg0KPiA+IE5vdCBkb2N1bWVu dGVkLg0KPiANCj4gInBvd2VyLWRvbWFpbnMiIGlzIGEgcGxhdGZvcm0gcHJvcGVydHkuDQo+IA0K PiBBbGwgaGFyZHdhcmUgY29tcG9uZW50cyBuZWVkIHBvd2VyLg0KPiBBbGwgc3luY2hyb25vdXMg aGFyZHdhcmUgY29tcG9uZW50cyBuZWVkIGEgY2xvY2suDQo+IE1vc3QgaGFyZHdhcmUgY29tcG9u ZW50cyBoYXZlIGEgcmVzZXQgc2lnbmFsLg0KPiANCj4gV2hldGhlciB0aGVzZSBhcmUgZXhwb3Nl ZCBhbmQgY2FuIGJlIGNvbnRyb2xsZWQgZGVwZW5kcyBvbiB0aGUNCj4gcGxhdGZvcm0vU29DLg0K PiBTbyBkb2N1bWVudGluZyB0aGVtIGluIGVhY2ggYW5kIGV2ZXJ5IGRldmljZSBiaW5kaW5nIGxv b2tzIG92ZXJraWxsIHRvIG1lLg0KPiBJIHRoaW5rIHRoaXMgaXMgc29tZXRoaW5nIHRvIGJlIGFk ZHJlc3NlZCBieSBkZXZpY2V0cmVlLXNwZWNpZmljYXRpb24NCj4gKHdoaWNoIGRvZXNuJ3QgaGFu ZGxlIGNsb2NrcywgcG93ZXItZG9tYWlucywgcmVzZXRzIHlldCkuDQo+IA0KPiBJZiB5b3UgcHJl ZmVyLCB0aGUgcHJvcGVydHkgY2FuIGJlIHJlbW92ZWQgZnJvbSB0aGUgZXhhbXBsZSwgdGhvdWdo Lg0KDQpJJ2xsIGdvIGFoZWFkIGFuZCBwdWxsIGl0IG91dCAoc2luY2UgSSBoYXZlIHRvIHVwZGF0 ZSB0aGUgY29tbWl0IHRpdGxlDQphbnl3YXkgYXMgcGVyIFJvYidzIHJlcXVlc3QpDQoNCkJlc2lk ZXMuLi5pdCdzIHByb2JhYmx5IHRoZSBtb3N0IGxlYXN0IGltcG9ydGFudCBwYXJ0IG9mIHRoZSBl eGFtcGxlIDspDQoNClRoYW5rcywNCkNocmlzDQo=