From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Brandt Subject: RE: [PATCH] ARM: dts: r7s72100: fix sdhi clock define Date: Tue, 17 Jan 2017 14:48:10 +0000 Message-ID: References: <20170116114023.GA3029@katana> <20170117082118.GA1487@katana> <20170117094529.GC1487@katana> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20170117094529.GC1487@katana> Content-Language: en-US Sender: linux-renesas-soc-owner@vger.kernel.org To: Wolfram Sang , Geert Uytterhoeven Cc: Simon Horman , Magnus Damm , Rob Herring , Mark Rutland , "devicetree@vger.kernel.org" , Linux-Renesas , Wolfram Sang List-Id: devicetree@vger.kernel.org Hi Wolfram, On Tuesday, January 17, 2017, Wolfram Sang wrote: > > I have no idea if the SDHI driver disables the module clock when it is > > idle, but shouldn't the card detect clock be running all the time when > > the driver is bound to the device? >=20 > Yes, it should. And for all instances with just one clock, this means thi= s > main clock must be running. So, en-/disable functions are all about > suspend/resume and bind/unbind. (Huh, looks like the unbind part is > missing, though. Need to look closer). >=20 > My take is: either we implement the power saving and handle the cd clock > seperately. Or we ignore the power saving for now and handle both clocks > as virtually one, i.e. en-/disable them at the same time. >=20 > Doesn't make sense? I'll go with "ignore the power saving for now and handle both clocks as virtually one". I'll go give it a try and see how it works. Thanks, Chris