All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Aiqun Yu (Maria)" <aiquny@qti.qualcomm.com>
To: Greg KH <gregkh@linuxfoundation.org>,
	"Aiqun Yu (QUIC)" <quic_aiquny@quicinc.com>
Cc: "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] pinctrl: core: Make p->state in order in pinctrl_commit_state
Date: Thu, 27 Oct 2022 08:43:29 +0000	[thread overview]
Message-ID: <SJ0PR02MB8385CDAD532E58836B7F23E6E9339@SJ0PR02MB8385.namprd02.prod.outlook.com> (raw)
In-Reply-To: <Y1oyEMYRK8R0dOs1@kroah.com>

Thx Greg,

Pls ignore this thread. Already correct to the normal  linux-kernel@vger.kernel.org  in another email thread.

Thx and BRs,
Aiqun Yu (Maria)

-----Original Message-----
From: Greg KH <gregkh@linuxfoundation.org> 
Sent: Thursday, October 27, 2022 3:24 PM
To: Aiqun Yu (QUIC) <quic_aiquny@quicinc.com>
Cc: linus.walleij@linaro.org; linux-gpio@vger.kernel.org; stable@vger.kernel.org
Subject: Re: [PATCH] pinctrl: core: Make p->state in order in pinctrl_commit_state

WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.

On Thu, Oct 27, 2022 at 02:51:10PM +0800, Maria Yu wrote:
> We've got a dump that current cpu is in pinctrl_commit_state, the 
> old_state != p->state while the stack is still in the process of 
> pinmux_disable_setting. So it means even if the current p->state is 
> changed in new state, the settings are not yet up-to-date enabled 
> complete yet.
>
> Currently p->state in different value to synchronize the 
> pinctrl_commit_state behaviors. The p->state will have transaction 
> like old_state -> NULL -> new_state. When in old_state, it will try to 
> disable all the all state settings. And when after new state settings 
> enabled, p->state will changed to the new state after that. So use 
> smp_mb to synchronize the p->state variable and the settings in order.
> ---
>  drivers/pinctrl/core.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 
> 9e57f4c62e60..cd917a5b1a0a 100644
> --- a/drivers/pinctrl/core.c
> +++ b/drivers/pinctrl/core.c
> @@ -1256,6 +1256,7 @@ static int pinctrl_commit_state(struct pinctrl *p, struct pinctrl_state *state)
>               }
>       }
>
> +     smp_mb();
>       p->state = NULL;
>
>       /* Apply all the settings for the new state - pinmux first */ @@ 
> -1305,6 +1306,7 @@ static int pinctrl_commit_state(struct pinctrl *p, struct pinctrl_state *state)
>                       pinctrl_link_add(setting->pctldev, p->dev);
>       }
>
> +     smp_mb();
>       p->state = state;
>
>       return 0;
> --
> 2.17.1
>

<formletter>

This is not the correct way to submit patches for inclusion in the stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

  reply	other threads:[~2022-10-27  8:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27  6:51 [PATCH] pinctrl: core: Make p->state in order in pinctrl_commit_state Maria Yu
2022-10-27  7:24 ` Greg KH
2022-10-27  8:43   ` Aiqun Yu (Maria) [this message]
2022-11-08 12:47 ` Linus Walleij
2022-11-08 19:20   ` Paul E. McKenney
2022-11-09 10:01     ` Aiqun(Maria) Yu
2022-10-27  6:54 Maria Yu
2022-11-01  4:30 ` Pavan Kondeti
2022-11-02  1:26   ` Aiqun(Maria) Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR02MB8385CDAD532E58836B7F23E6E9339@SJ0PR02MB8385.namprd02.prod.outlook.com \
    --to=aiquny@qti.qualcomm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=quic_aiquny@quicinc.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.