From: "Sa, Nuno" <Nuno.Sa@analog.com>
To: Maarten Zanders <maarten.zanders@mind.be>,
Lars-Peter Clausen <lars@metafoo.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/3] ASoC: adau1372: correct PGA enable & mute bit
Date: Mon, 31 Oct 2022 11:22:44 +0000 [thread overview]
Message-ID: <SJ0PR03MB6778F2F397C62329B3B4D67E99379@SJ0PR03MB6778.namprd03.prod.outlook.com> (raw)
In-Reply-To: <20221028152626.109603-4-maarten.zanders@mind.be>
> -----Original Message-----
> From: Maarten Zanders <maarten.zanders@mind.be>
> Sent: Friday, October 28, 2022 5:26 PM
> To: Lars-Peter Clausen <lars@metafoo.de>; Sa, Nuno
> <Nuno.Sa@analog.com>; Liam Girdwood <lgirdwood@gmail.com>; Mark
> Brown <broonie@kernel.org>; Jaroslav Kysela <perex@perex.cz>; Takashi
> Iwai <tiwai@suse.com>
> Cc: Maarten Zanders <maarten.zanders@mind.be>; alsa-devel@alsa-
> project.org; linux-kernel@vger.kernel.org
> Subject: [PATCH 3/3] ASoC: adau1372: correct PGA enable & mute bit
>
> [External]
>
> The DAPM control for PGAx uses the PGA mute bit for
> power management. This bit is active high but is set to
> non-inverted (ie when powering, it will mute).
> The ALSA control "PGA x Capture Switch" uses the active
> high PGA_ENx bit, but is set to inverted. So when
> enabling this switch, the PGA gets disabled.
>
> To correct the behaviour, invert both these bits.
>
> Signed-off-by: Maarten Zanders <maarten.zanders@mind.be>
> ---
Also looks like a fix so a Fixes: tag? If so, the patch should come
before ("ASoC: adau1372: add support for S24_LE mode")
- Nuno Sá
next prev parent reply other threads:[~2022-10-31 11:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 15:26 [PATCH 0/3] ASoC: adau1372: fixes after debugging custom board Maarten Zanders
2022-10-28 15:26 ` Maarten Zanders
2022-10-28 15:26 ` [PATCH 1/3] ASoC: adau1372: fix mclk Maarten Zanders
2022-10-28 15:26 ` Maarten Zanders
2022-10-31 11:20 ` Sa, Nuno
2022-11-02 8:07 ` Maarten Zanders
2022-11-02 8:59 ` Sa, Nuno
2022-10-28 15:26 ` [PATCH 2/3] ASoC: adau1372: add support for S24_LE mode Maarten Zanders
2022-10-28 15:26 ` Maarten Zanders
2022-11-25 19:32 ` Mark Brown
2022-11-25 19:32 ` Mark Brown
2022-10-28 15:26 ` [PATCH 3/3] ASoC: adau1372: correct PGA enable & mute bit Maarten Zanders
2022-10-28 15:26 ` Maarten Zanders
2022-10-31 11:22 ` Sa, Nuno [this message]
2022-11-25 21:28 ` [PATCH 0/3] ASoC: adau1372: fixes after debugging custom board Mark Brown
2022-11-25 21:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR03MB6778F2F397C62329B3B4D67E99379@SJ0PR03MB6778.namprd03.prod.outlook.com \
--to=nuno.sa@analog.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.zanders@mind.be \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.