From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DEE0C2BA03 for ; Mon, 10 May 2021 11:07:46 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id C9A9A61878 for ; Mon, 10 May 2021 11:07:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9A9A61878 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6F4D40140; Mon, 10 May 2021 13:07:44 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 4F20E4003E for ; Mon, 10 May 2021 13:07:43 +0200 (CEST) IronPort-SDR: O3nx/tlCw8NjyHMCY6ObcIgo++U8vH6W68QHEPJ94Z/zyhAlVlEoOlsESa9UY3lB2ZDDyJAm25 fz2xIhPFgYeA== X-IronPort-AV: E=McAfee;i="6200,9189,9979"; a="284651713" X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="284651713" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 04:07:42 -0700 IronPort-SDR: iUSe8RyyyPz7uEXNzEB2uKuytOhiy6BoVzyoAngCwklz46V3LOlYiEUOtIPfRcLJKZoPWwSpWB DgJLHbrgfzTQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="408302645" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga002.jf.intel.com with ESMTP; 10 May 2021 04:07:41 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 10 May 2021 04:07:41 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 10 May 2021 04:07:41 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 10 May 2021 04:07:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iLkMmI2PbV+o1wU2eJcav81sDUeUoe8+DtkHQtpGfx+p1LfYZGAjVInDOQbMf6168+kxd1pyWk289aiuUvz0YOXBEYkd6PWC+52q+cS3BBmVBUNluXvruUVy/xvqPfaYPxu8K3FaLtjF2g76Yi9ii5CB7Blx7gyOlkBE5sm76iQZdKt9cWC5/by7PIiaswD0m+ZXlhL7pRvKRxm5lLQ+sEDNgFOMY7JVmx87rvr1jP42aZfCerjonfsXAlK1qPXD5WXC3jPtVhxa+OixBGBBWcgvPB4x9EdLPpQTpt2wyEHQFz9ePOJ5IopVcoR3gflB2GKacBLGOtDd0KHiQojHtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lZc4OJ9erL0/iYEyg4vAo/rpp6JvLnAN7ZIVKX/QBMs=; b=hGr+RGwF4pVWQYcNJDqg2C1Utn9BeisoH1qD5EFyq9M4UM8IWWJwloIbeuD1uakuZ3yDQS8WiYjbI2Rm5cxQK7/hYMk/0MbvTk7eOmep57rmGTnb5A0r4SiuZYwCe3X578S/YNugVedXArC8HVoVs1mxlVEsbWwRz5RlmTyMTsmWlypVTmsdkGclTYcFLtrzrz3x7e3S+RG17gs3SNR3WiGk5gM8Xu+FcXRUtn3SLrI4e+RvgUgt432IZs4O6zG5nr/IbMSGgcoguq6iT/aHKAxi9bSmb6uFa8kSx/Wzm98u+WJNvp5bvw/5rCZP7WQZNz4lQRQcY+7ODc0yeOUvnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lZc4OJ9erL0/iYEyg4vAo/rpp6JvLnAN7ZIVKX/QBMs=; b=kfSWBfZPxeNmQGbwN277Sz6EcEobxE/wE6g6VRerGriBblSqrZkUtOhevU7iIuVHpW139ZnT2DgzZjxAMmUp3xvY1Wn/v4g7p7UV0DCYTfm7kLw3gK8zjV78DHxXjYyBJ981wYnbqMLZMGRYoRX0kXrwgz48Ud2uBkYB9YN5XXI= Received: from SJ0PR11MB5055.namprd11.prod.outlook.com (2603:10b6:a03:2d9::10) by SJ0PR11MB5214.namprd11.prod.outlook.com (2603:10b6:a03:2df::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24; Mon, 10 May 2021 11:07:38 +0000 Received: from SJ0PR11MB5055.namprd11.prod.outlook.com ([fe80::d4c0:1747:b7ba:6ffb]) by SJ0PR11MB5055.namprd11.prod.outlook.com ([fe80::d4c0:1747:b7ba:6ffb%5]) with mapi id 15.20.4108.031; Mon, 10 May 2021 11:07:38 +0000 From: "Laatz, Kevin" To: "Richardson, Bruce" CC: "dev@dpdk.org" , "Pai G, Sunil" Thread-Topic: [PATCH] raw/ioat: fix parameter shadow warning Thread-Index: AQHXQ2VikZgqqsIyekmYkAq/bfGvNqrcb60AgAAen8A= Date: Mon, 10 May 2021 11:07:38 +0000 Message-ID: References: <20210507172025.181720-1-kevin.laatz@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [93.107.208.248] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dfbe6ee2-c086-4245-aa25-08d913a3d2e4 x-ms-traffictypediagnostic: SJ0PR11MB5214: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2803; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8VWq4LMgpUyusCL1P37VZ/2F0sxvButXDr3WZRRZ8TVD+ZiKMsyDlA3Nq6XoYZhEIUIVPUwo3qWY4DmSAgY5msMDDgAYnsjIjGYv+2lRFwaOhOoRlWMLg8P4QoWjIDoAmnlEdZXc1Qs7H1zwLJ7MFPkzcAWkEtL+cTXTJz2urlUCgYxA9QaUF9vhSeYow6RKhhfS3t5/xbwgpQkWu/q1ET47a2BFMhdxHY2EED3qWl71oXm6+VZpbQG4N4UCLqoHoEkDnq/7H2mx8TbLKeh014l2+tqqquU/zte67FYQ4UaOvNTki26KAkvv+OxJbOcjqA906QxUhOfBadKaSjjsVA2Q1Z02i6+ofcXYUw2/CYyAmNDgn7+qxaPC14QzN2bX3Pak7bwREh4ORUchm9nwx1ItXQncCBYtcnHuF+H5u1SGuef80WEZaFq56e8/vdgFBly3y1f1858CNuYSBQIePpjgdrUikXBSHeE6q0wzz8tek+QFUP+k1XBqZT+YfDEqQm6rOFj2UWRe9EfmiqWz+OY2ORJ6lWfpRxNIVxz0fjQhJg0aUNx7jB7vD+rEuMAnJiDnPS9U5SC5I2zzNvfS3fV3u4+peOyNlbelsC1fClo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5055.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(39860400002)(346002)(376002)(396003)(136003)(478600001)(4326008)(4744005)(9686003)(186003)(66556008)(66476007)(64756008)(66946007)(33656002)(76116006)(83380400001)(66446008)(8936002)(52536014)(55016002)(6506007)(7696005)(8676002)(86362001)(6862004)(6636002)(316002)(54906003)(122000001)(71200400001)(2906002)(26005)(107886003)(38100700002)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?26NVQRSizeyviEQ2nViTAk3KRMeCiOsvm0mzCGEw90cXQKFZjanq0S2m+pNv?= =?us-ascii?Q?XYtI3of9TpFlfC8mxB6f9+IwCfgQEfy8v71/Ef+cqZrjPr2Je7DgAXm6T4EX?= =?us-ascii?Q?iRdHUWh0vWY0LtUy+qDm3XFq4AYzBs6qRCYFzf+BxH4z5ExOSOhZeMrC0RRP?= =?us-ascii?Q?Lftb0fivrqB200AYoIDn+09SSnr5SZ5f4LPnahMJnklEXQ0ndXEf8LZdy8Mw?= =?us-ascii?Q?3bCjiA5LJ4Sa8hmSnfMreDL7iM1JbndFpE9JHERxfKdCa+l4zuflALDeRoC1?= =?us-ascii?Q?NU8EMq3GgmSm79/6iM0JPTINYpMDrkr3PDTuQN4wEhbU8ILzUfKgEPOIIolQ?= =?us-ascii?Q?gkRHgw7UYburJIz3oCSo/DaeoAysm1acZRQSIG1DmMIw0SMy4ikwzxWDEWSX?= =?us-ascii?Q?fKEC2wtaNUDcmg3jDTR89VkTu2og90vDgndEDuT/2pvoQyIevB8V9MjL7OKt?= =?us-ascii?Q?NPQrBm85CB7MSHZm6f/Rw7GkuoiIZFbIH8WCC0esd/nAk6UW/VmE2+XnsQ72?= =?us-ascii?Q?0ncc+nHhNLmHx1uWqI5Vc2e/GjZQVNs8820R/JQtty+9HoC3SU22wq2MsD0D?= =?us-ascii?Q?E3mmBEBBu06Hs93uMKV5QNeqSNfjfPVOxa1NjZ+zcMMrS3c/pLgVfKMD19Di?= =?us-ascii?Q?CS42z/Jw0Hxu+uCuvGvymFZDgJ0Lm0vYp/E8uNbv+QU6yEQcqIpxuOY+Sh9j?= =?us-ascii?Q?oybHcadkuvZBmnNw3O45PmkXteNQX6rFeGx2Eg+pe7eys479dnCvi9Jhbay4?= =?us-ascii?Q?I5ESVfVqR0gXL2wtVKCPgXiOt8nRiNPDy03xQ5G6Hist3FB8dnqnTyVqelvM?= =?us-ascii?Q?R84+FDf6vS2aNeASEz/p2fFUyzuoFekEeheqMzO5rvW3cjwulTNNKzpnPlQP?= =?us-ascii?Q?LAU07PxafFGH9VAQPxtFAREJax5wFr+DdpLjn8cK+XLDXvjOEC/K5lvGNeX6?= =?us-ascii?Q?DwrY05GScmjxYWYSJ92g2nubFoxoev+E+lvVyNAjZcmNLzCFP4Q2N/eFq/lm?= =?us-ascii?Q?02gyE9/lurQL99/FGcUOV5qKg+itGVYX4kDra0fpjH7AWSaFNlLYossZkvko?= =?us-ascii?Q?VNwf0li9KqxTSDjKiCqGLa0dMA110IlKq4NuWv2IeuBEswnU+jxTOJVEEVP0?= =?us-ascii?Q?f3pgf70CU6v2YS/M+ssijftz2RrVwlOlYTzocvQd04AGqGmLshRASmy00XzM?= =?us-ascii?Q?RbX66C+aNSBj5QQ3yEuGZDAmti7lLqvmCL/Va6HX3R7XTTmmALBEujjkrWlj?= =?us-ascii?Q?mCb8TTLM76Pb4U/WAEsZ9UZIA41q3pZmJGYr1xPq7AJ01yBeV3MC9UguFRKa?= =?us-ascii?Q?OujU7hLomDoLlw9mo7ZM4B8F?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5055.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dfbe6ee2-c086-4245-aa25-08d913a3d2e4 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2021 11:07:38.7139 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Lp00SVfgBarbG3jFKPrUYqcwzKqL0upuOPwJ7G0Qnbfq367Zz+uu7GA7FyVYgp290S+G4w9e5MEC6Po/KNT9xA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5214 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] raw/ioat: fix parameter shadow warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Fri, May 07, 2021 at 05:20:25PM +0000, Kevin Laatz wrote: > > In the function __idxd_completed_ops() we have a parameter shadow > warning > > due to a local variable having the same name as one of the function > > parameters. This is fixed by simply renaming the local variable. > > > > Fixes: 245efe544d8e ("raw/ioat: report status of completed jobs") > > > > Reported-by: Sunil Pai G > > Signed-off-by: Kevin Laatz > > --- > Please provide details in the commit log as to how/when this was seen. I > believe this issue was seen only with OVS because it passes the -Wshadow > flag when building - something DPDK probably should do, but doesn't. Is > that correct? Correct, the OVS build has -Wshadow by default. When -Wshadow is passed to the DPDK build, this warning is also visible. Will send a V2 to include details in commit log.