From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17D76C54E71 for ; Fri, 22 Mar 2024 19:32:20 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0962E402A7; Fri, 22 Mar 2024 20:32:19 +0100 (CET) Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11020002.outbound.protection.outlook.com [52.101.193.2]) by mails.dpdk.org (Postfix) with ESMTP id 381A340284 for ; Fri, 22 Mar 2024 20:32:18 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KdX4gpCduvNvss4SrsjG56NZ3N8Av3GbwIzGCy6gLxKuXYjw5aVNicXFYs/GOvB6TJtpXRWKaXkyHc29MgnB1Z1LTicdiD9mBKMZQbw5ing2NvBKDpyq/uKT+lJ+BVAR4DX53OR2jbT+rhlBrK05k57ynNs9xNCK5DLb2HnNsjD9z2owyqCvAjUkwytqM+VF2F134hmpN+En4MQDu3D4nQjlHARz01mzjDWJzPOfQ7dyYk7UfwkJ1CC+jI0ri338GZQjeRaQ+P96EbzGomUZOLAtG4SnYwdn+jwhLqQyBiIuXn4xNSuXzAbRdloL7UXIVhaf+c1+onfwwK/7jiA7hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rvCPc2c5q24REZvAP5b624hkXAQXrhiIVcBwmp2D9gU=; b=gzasJgMfv6M2/MBmdvFkbxBu/CANBAmJ+0qP5CobGrXen2yKjckYCXkrWPY051CcUkbLq87+K3ZzWOpu9R983Qn7Ao0jVVMONDeDjR0iY1RLQuwbP61R1zvQ+WyfinfHdacqvUSgzz8wE9F85xnSwvEYaZZkZLLzSu4OL9GSLlc8hUueDkxQ8pKF6e62gMQCCxXh3PEB0Ck8RBNxo+UBvb5RAZHuTTjPiDUZ5Z1t4yPhhGsLBu2mKlnEPZOE1Pew01eIVnya/UihOa8om0Ah8/HuyByfS4DUryyXHYQ/sJ2THnFI3dDxW8r+eN25tUk1UWBXw+I+vlhRVKy8iUNuoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rvCPc2c5q24REZvAP5b624hkXAQXrhiIVcBwmp2D9gU=; b=TcWWkH1N9X7ZGBTOrNmRm9p756uGk6CVBJr2Xn4l3OcfHqgMSE6/0BZ89nhVLKf+lvwd9IAw65uXc46Ean2dbHBAIYdIof2Fx507pR6ckwJYTQqIKtn4L1mVsSN+ujkhKKcy8Gak3BsgVs4hYb7zi1+jCEqMn6KcCkcRdvdbYSc= Received: from SJ1PR21MB3457.namprd21.prod.outlook.com (2603:10b6:a03:453::5) by BY5PR21MB1411.namprd21.prod.outlook.com (2603:10b6:a03:238::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.24; Fri, 22 Mar 2024 19:32:14 +0000 Received: from SJ1PR21MB3457.namprd21.prod.outlook.com ([fe80::70f:687e:92e6:45b7]) by SJ1PR21MB3457.namprd21.prod.outlook.com ([fe80::70f:687e:92e6:45b7%4]) with mapi id 15.20.7430.013; Fri, 22 Mar 2024 19:32:14 +0000 From: Long Li To: =?iso-8859-1?Q?Mattias_R=F6nnblom?= , Tyler Retzlaff , "dev@dpdk.org" CC: =?iso-8859-1?Q?Mattias_R=F6nnblom?= , =?iso-8859-1?Q?Morten_Br=F8rup?= , Abdullah Sevincer , Ajit Khaparde , Alok Prasad , Anatoly Burakov , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Byron Marohn , Chenbo Xia , Chengwen Feng , Ciara Loftus , Ciara Power , Dariusz Sosnowski , David Hunt , Devendra Singh Rawat , Erik Gabriel Carrillo , Guoyang Zhou , Harman Kalra , Harry van Haaren , Honnappa Nagarahalli , Jakub Grajciar , Jerin Jacob , Jeroen de Borst , Jian Wang , Jiawen Wu , Jie Hai , Jingjing Wu , Joshua Washington , Joyce Kong , Junfeng Guo , Kevin Laatz , Konstantin Ananyev , Liang Ma , Maciej Czekaj , Matan Azrad , Maxime Coquelin , Nicolas Chautru , Ori Kam , Pavan Nikhilesh , Peter Mccarthy , Rahul Lakkireddy , Reshma Pattan , Rosen Xu , Ruifeng Wang , Rushil Gupta , Sameh Gobriel , Sivaprasad Tummala , Somnath Kotur , stephen , Suanming Mou , Sunil Kumar Kori , Sunil Uttarwar , Tetsuya Mukawa , Vamsi Attunuru , Slava Ovsiienko , Vladimir Medvedkin , Xiaoyun Wang , Yipeng Wang , Yisen Zhuang , Yuying Zhang , Ziyang Xuan Subject: RE: [PATCH v2 38/45] bus/vmbus: use rte stdatomic API Thread-Topic: [PATCH v2 38/45] bus/vmbus: use rte stdatomic API Thread-Index: AQHae8R3MKoDKzEXH0+JTMW/GUGoZbFCsWkAgAAFk9CAAJ/ZAIAAz3Jw Date: Fri, 22 Mar 2024 19:32:14 +0000 Message-ID: References: <1710967892-7046-1-git-send-email-roretzla@linux.microsoft.com> <1711048652-7512-1-git-send-email-roretzla@linux.microsoft.com> <1711048652-7512-39-git-send-email-roretzla@linux.microsoft.com> <281eabd4-6adc-44df-a5be-0d2b5cee9ba8@lysator.liu.se> In-Reply-To: <281eabd4-6adc-44df-a5be-0d2b5cee9ba8@lysator.liu.se> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=e44c9f7f-a0df-425a-8465-0a9e92bbc9c2; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-03-22T19:26:58Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ1PR21MB3457:EE_|BY5PR21MB1411:EE_ x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N9//6Fq81azHqt1JmIzZo5zDWihdCBom7trvpzcTq6JbFoJwYgUBBdQdoV0+YfoBLRS5WDXGZrmpK6W/Pk9xcBegI9fn9VgQPT/wak7Os6rymS4wM8MKrqTlzK0oX0TF8kkZFw5nfeYbPV9L8PUQD0OVs8wxuFJIkWXnzSIQChcKGRZDyHGL+A2tZUxjUA9Fz55icq+MHJyK5+WKV/sxcmMwdBPYEUr+IKD5tg9C9GuIRF4Zn84w8DAOqBPD4ZLpsn7yJogiKO38uMPPN7D2ORUQaM6aDueZ1rW3GcN0lJSzKPCEAp387H5r4UQ+faPqOnSKsPYEGgJ8gRLbyZnNQt3ICThUkM6Obel3COm6PAWCfg1KhfB6uqmkbZJ8+SyLmwye2o7Gth3QqkmuGkisjiYrARQ4ZFcdno+iHBoh355FX0FNz0A7fenUSf2skkc9fSZeBEVvYk2Z4n3VUyg2LjcstWEwA8y2cBaUYYq80Tb4uyrcNhGsFSosEDpxI9IqPo0N2IZsW8Buen6OUfwpcdH8BsFPHg08Xpc9IZrbiwHzKc+1TtMBtVzvUnnYT1u1ThM0Bh+7/8QbwndW99IPLuhOVIpG2aoguc1ktscrQ7H/OAqLrg1iiLo863l4kJ9HL9+WpNgs+V9Xy8a6dR54K349eab2MBlSXLnxI77tuPk= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ1PR21MB3457.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(7416005)(366007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?w03FPgQQ7q1mcEq/tGqhmsccPPMbXl0dN4Tm7LTrafbJSfw6Px+Sc8ZAtP?= =?iso-8859-1?Q?Tvu0dMouVj3RVFREY0IxQ7oD+oSy4MJzruxtLgtCXUl5MmqsRKxXh6kHRr?= =?iso-8859-1?Q?b13j4ASzqh1SsDvbMu6f83UEYaQa/3MEzGe66KOEZoQvAHtL1vn2BzKxj9?= =?iso-8859-1?Q?3OA1HEaKjFEBJRXjHSlVMTCiNrnMTu8z+AIS+yQaSdJTnd4XZrzeX1Q7Kd?= =?iso-8859-1?Q?/d+pMaJE8dIQbLNdCLJl+bZa4iD9CF0QARl/34tbaBVjX5674CHm+bZCqz?= =?iso-8859-1?Q?GY2MDDx6wSG5FzZ1Qo6JtMpa2RAFzEH+UcNrEfn8xXwsu9Gvl/03Yd3I5J?= =?iso-8859-1?Q?JS+/KheWgSVuEMsKT/zjuKzGMAgGcVFpLDJURxW8iRHtOo+d582s0wzE8W?= =?iso-8859-1?Q?7CJBAbQZwMQEU405WuPGpx4VX3jVgCyxR6WW1oME5UVPIErYpgqf85xrmt?= =?iso-8859-1?Q?Ai0fFwGlWFIpjFVyIBO6MLoB79swgYHcvKmuUEsbk6xgI3JZ5XHDH3/G+d?= =?iso-8859-1?Q?b1t1/4kVcutKyS/Kl5+O7MdQG/FE9va/hmGvPXXUV6iTWarKETLLDgRWy3?= =?iso-8859-1?Q?ecp61IXvBIkgfe0Y1hBtwBIZRfTO12Xiz6ghlH/57A7+M+sL5EujjTBRMd?= =?iso-8859-1?Q?7NZahaCUZErXlgGu93VZOraBzoF3lvcC1jD1jIU3788JR0mPdu4h8aR4hz?= =?iso-8859-1?Q?DLUnpyqDmb9jSZdXdcbJivALa7yoITsoKoho5lHW9KAW2rBrEppR72NF43?= =?iso-8859-1?Q?nI16ngUsBy/5yxQgkvk+rL2PhI+TDpvI3Jqlwv2Rb6xchffQZVGs0Gm1gf?= =?iso-8859-1?Q?hEucYkQWpRaX+o68J4bt/KR4U/9thE+e8GZRs3FNcSE6rjFZSNquMQbsbi?= =?iso-8859-1?Q?LO6IcIQSQmh6Xb2UA7xU0n+ycHdB7INVkIDGS2Y9NIeh/wMt26D9mHtpyq?= =?iso-8859-1?Q?dqdsajv5TiOSp8j9Saugagh9gKomQBwksGqWXQEbXremrUnJaV2pK6+7Kg?= =?iso-8859-1?Q?zmHiTpSiw8r54L7y5evqtFZ5ZLulPBj7ujyyfb3M0sHD506wTNtuz/y3j6?= =?iso-8859-1?Q?xS8dCYB/gASCy3qMLLD48r3R3VnW94d3B9JAQ1g2nB6DTmIzGfCZWv+2v3?= =?iso-8859-1?Q?kEyDVTuou4Ssgri54Jt7lDj0NbX5CjuLWwDGjc3Dg1GWVpvUjW4KqzNIHZ?= =?iso-8859-1?Q?/DMFzgnxy5m3U7FB4xM01azMNrBoToDDV3Fae67F7P2TgUxdBudMEGAudx?= =?iso-8859-1?Q?eFwvJAjanZyswtXMfG12HwILP6CASB74f5p5+srj8r92I1jBqQGpqGrsdy?= =?iso-8859-1?Q?HP9b4f9t+EXhWxFsNrd0mSFcZJAJF0axh3fwzul1/JE6PyFJBxOORUlYls?= =?iso-8859-1?Q?bqqVSacsiknRz5eMdLI6RqmXscPiVSYdAT/GdxFaxKvAKz4E6Nea1cJJPY?= =?iso-8859-1?Q?6+GuISQtnY+vdb4xxEqUpanDOt6m/BIG8vuo0Yxbf+poJmZmHA8D3v0l5X?= =?iso-8859-1?Q?C1Tnq/+vuILypCWopnLSxZxBZUPxzvCtfr3iFhrVdIQ01dTc7Zi01V2JTZ?= =?iso-8859-1?Q?RYWZ+g5nYBMfSaIH27xfWZB+iUgj4jkxz6eqyEh6n1pMWdH/hZv5Feai8h?= =?iso-8859-1?Q?y7HzMBEG1/lDGKXrUSbfcjDlrPWpBIgd7Z?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ1PR21MB3457.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50e2c06c-1ef9-4f6a-6354-08dc4aa6c729 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2024 19:32:14.5637 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HXrxZPxGi+/p0Fo5hj0l6oap9RO1nP9vmkQI9bNEZE7AosgQ2gQ7b/3urKoTvRUD13tv8ZY99VnnLh89fqjmpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR21MB1411 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > The usage is okay. The value is used to notify the VSP (Hyper-V). It's = always set > (no read) from DPDK. > > >=20 > OK, so my question was not "does it need to be atomic", but rather "why i= sn't it > marked RTE_ATOMIC() when it's treated as atomic". >=20 > But what you are saying is that it need not be atomic? Just the equivalen= t of > WRITE_ONCE()? Or a relaxed atomic store? Sorry I misunderstood your question. Yes, it will be a good idea to make "p= ending" as RTE_ATOMIC. This value needs to be atomic. However, the existing code is still correct = in that updating is done in atomic.