From: "Mark-YW Chen (陳揚文)" <Mark-YW.Chen@mediatek.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
Sean Wang <Sean.Wang@mediatek.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"michaelfsun@google.com" <michaelfsun@google.com>,
"mcchou@chromium.org" <mcchou@chromium.org>
Subject: RE: [PATCH 1/2] Bluetooth: btusb: Support public address configuration for MediaTek Chip.
Date: Tue, 31 Aug 2021 09:42:15 +0000 [thread overview]
Message-ID: <SL2PR03MB4457513693916CBA07BE450BB3CC9@SL2PR03MB4457.apcprd03.prod.outlook.com> (raw)
In-Reply-To: <CF258C9C-BB3C-4C10-88B0-F6F3A03303D5@holtmann.org>
Hi Marcel,
> > The MediaTek chip support vendor specific HCI command(0xfc1a) to
> > change the public address. Add hdev->set_bdaddr handler for MediaTek
> > Chip.
> >
> > Signed-off-by: mark-yw.chen <mark-yw.chen@mediatek.com>
> > ---
> > drivers/bluetooth/btusb.c | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index 60d2fce59a71..41e7c9f28d82 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -2200,6 +2200,23 @@ struct btmtk_section_map {
> > };
> > } __packed;
> >
> > +static int btusb_set_bdaddr_mtk(struct hci_dev *hdev, const bdaddr_t
> > +*bdaddr) {
> > + struct sk_buff *skb;
> > + long ret;
> > +
> > + skb = __hci_cmd_sync(hdev, 0xfc1a, sizeof(bdaddr), bdaddr,
> HCI_INIT_TIMEOUT);
> > + if (IS_ERR(skb)) {
> > + ret = PTR_ERR(skb);
> > + bt_dev_err(hdev, "changing Mediatek device address failed
> (%ld)",
> > + ret);
> > + return ret;
> > + }
> > + kfree_skb(skb);
> > +
> > + return 0;
> > +}
> > +
>
> this is not a permanent change, correct? Meaning a power cycle will bring back
> the original BD_ADDR?
>
Yes, it's not a permanent change.
After doing a power cycle or Mediatek specific Bluetooth reset, Mediatek Chips will bring back the original BD_ADDRESS.
With best regards,
Mark
next prev parent reply other threads:[~2021-08-31 9:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 15:44 [PATCH 1/2] Bluetooth: btusb: Support public address configuration for MediaTek Chip mark-yw.chen
2021-08-24 15:44 ` [PATCH 2/2] Bluetooth: btusb: Add protocol for MediaTek bluetooth devices(MT7922) mark-yw.chen
2021-08-30 15:04 ` Marcel Holtmann
2021-08-30 15:04 ` Marcel Holtmann
2021-08-30 15:03 ` [PATCH 1/2] Bluetooth: btusb: Support public address configuration for MediaTek Chip Marcel Holtmann
2021-08-30 15:03 ` Marcel Holtmann
2021-08-31 9:42 ` Mark-YW Chen (陳揚文) [this message]
2021-08-31 12:31 ` Marcel Holtmann
2021-08-31 12:31 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SL2PR03MB4457513693916CBA07BE450BB3CC9@SL2PR03MB4457.apcprd03.prod.outlook.com \
--to=mark-yw.chen@mediatek.com \
--cc=Sean.Wang@mediatek.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=marcel@holtmann.org \
--cc=mcchou@chromium.org \
--cc=michaelfsun@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.