From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Amrani, Ram" Subject: RE: [RFC 08/11] Add support for data path Date: Wed, 14 Sep 2016 10:16:50 +0000 Message-ID: References: <1473696465-27986-1-git-send-email-Ram.Amrani@qlogic.com> <1473696465-27986-9-git-send-email-Ram.Amrani@qlogic.com> <40a9df9e-a0aa-9020-c523-6042baf729d1@grimberg.me> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <40a9df9e-a0aa-9020-c523-6042baf729d1@grimberg.me> Content-Language: en-US Sender: netdev-owner@vger.kernel.org To: Sagi Grimberg Cc: "Yuval.Mintz@qlogic.com" , "Ariel.Elior@qlogic.com" , "Michal.Kalderon@qlogic.com" , "rajesh.borundia@qlogic.com" , "linux-rdma@vger.kernel.org" , "netdev@vger.kernel.org" , "dledford@redhat.com" , "davem@davemloft.net" List-Id: linux-rdma@vger.kernel.org > > + pbe =3D (struct regpair *)pbl_table->va; > > + num_pbes =3D 0; > > + > > + for (i =3D 0; i < mr->npages && > > + (total_num_pbes !=3D mr->info.pbl_info.num_pbes); i++) { > > + u64 buf_addr =3D mr->pages[i]; > > + > > + pbe->lo =3D cpu_to_le32((u32)buf_addr); > > + pbe->hi =3D cpu_to_le32((u32)upper_32_bits(buf_addr)); >=20 > Thats a shame... you could have easily set the buf_addr correctly in > qedr_set_page... >=20 > I think you could have also set the pbe directly from set_page if you hav= e access > to pbl_table from your mr context (and if I understand correctly I think = you do, > mr->info.pbl_table)... I see what you mean, we can surely improve here and will. Thanks.