From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755418AbdLUU0o (ORCPT ); Thu, 21 Dec 2017 15:26:44 -0500 Received: from mail-by2nam01on0093.outbound.protection.outlook.com ([104.47.34.93]:12931 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752543AbdLUU0n (ORCPT ); Thu, 21 Dec 2017 15:26:43 -0500 From: Casey Leedom To: Dmitry Torokhov CC: Greg Kroah-Hartman , Eric Dumazet , Eric Dumazet , Tariq Toukan , "David S . Miller" , "Komali Katari" , "Luis R. Rodriguez" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink Thread-Topic: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink Thread-Index: AQHTdGkfcsnV1jK2KE+O7UiPv0BG86NDRuq8gAAFjICAABE0noAAAwuAgAAFyPeAAVDHQoAAC9EAgAAAyuWABMGMbYAAB339gAGn7IeAAhc+gIAA/NNC Date: Thu, 21 Dec 2017 20:26:40 +0000 Message-ID: References: <20171213232122.5ztmwume5kylh4mz@dtor-ws> , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [12.32.117.8] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY4PR12MB1224;6:qeBJvQBFSfzm61PKKlDD0UzrUtUpdsNNEDYO3w2VIv4loh5lWZoRjtsA95GP9WPosvtGH3TcaUCoz1SKtyhXTdg4aoFyNctmiBMZZKof5dSsGqtkvABMa/jcYKKQeZdE+Qt/H7vYXxHOizIsdKpbcIWODaRBF/0KnFGM6++ZJfImQcgaOm2Rtnmf0T7SP0c4lJyWwuf/S2ldi9dL5pl5pbeDeukJPTYjFh0MawSn+gYvEFI56Z30lEcW/P7p1gHbCg9+bciCp9tsAhX2j8JdxHrCx9rqfVc5THV89xsMNQEIj7cjIDnxRGJJGeY4bXDlk1Tb6fyc/BS0IyjltFzOIzCKDXkZNwDfRRD18qdWiEg=;5:hUaU3nibeGbatMR04+S9XTyVYLn83ez1Zg4RQImTgBc/InpLon1MhwGhqhm1yAqsDz8jJlgSS/LMsBIeWoGwvMIyASPVEIWPejV5cy1vy4vGYeY0eNiI11o1Jn23fn9rMb1+877/R9yNPYzdtZULqTTUtwbWVPMpWGNUGLIrENY=;24:z3qD+OMdCJ6evMDiFs2uxwULA6j4+SLxk0Q2NKsRve7X45/dPW3Od9ekKoFWORBDtub9sOHxwcE3m2yG7R2mFq5qx3wuO5OondE0VqfExeg=;7:2yRx8fEQ3s/mIc42DBZzvS/qi5aO0UoZmO5PhdKmX0MyACPlO10rW88o0PAQotj0Hudzux7qt7PixWwGz6RmPhgx2riWoUeblpKjUyO5iKEAXK34IldAykLqbOioxn38zwQRD+QB8pACc8os8m7h/9N5gi8P68dx782vWUMp7o7qEH7bz3FEL/TPI4FZNeg7g0O1m9fwQMo/UhqpRwGXV9rEcdbthzc89l91OocywuJP6EuOgdydxJsJk3Fnz2yB x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10019020)(376002)(396003)(39840400004)(39380400002)(366004)(346002)(199004)(189003)(4326008)(3660700001)(25786009)(7696005)(76176011)(59450400001)(74316002)(6506007)(305945005)(7736002)(66066001)(97736004)(8936002)(966005)(3280700002)(102836004)(2906002)(39060400002)(99286004)(14454004)(54906003)(6436002)(229853002)(68736007)(77096006)(478600001)(6306002)(55016002)(53936002)(9686003)(33656002)(86362001)(575784001)(2950100002)(2900100001)(6916009)(5660300001)(6116002)(106356001)(3846002)(81166006)(81156014)(105586002)(316002)(8676002)(6246003)(93886005);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR12MB1224;H:SN1PR12MB0352.namprd12.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-ms-office365-filtering-correlation-id: 74100c13-31c0-4923-d20c-08d548b12491 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4603075)(4627115)(201702281549075)(5600026)(4604075)(3008031)(2017052603307)(7153060);SRVR:CY4PR12MB1224; x-ms-traffictypediagnostic: CY4PR12MB1224: authentication-results: spf=none (sender IP is ) smtp.mailfrom=leedom@chelsio.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(166708455590820); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231023)(944501030)(6041268)(2016111802025)(20161123562045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6043046)(6072148)(201708071742011);SRVR:CY4PR12MB1224;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:CY4PR12MB1224; x-forefront-prvs: 0528942FD8 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 X-OriginatorOrg: chelsio.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74100c13-31c0-4923-d20c-08d548b12491 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2017 20:26:40.0865 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 065db76d-a7ae-4c60-b78a-501e8fc17095 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1224 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id vBLKQmGm006193 | From: Dmitry Torokhov | Sent: Wednesday, December 20, 2017 9:13 PM | | The 2nd issue is that Casey is seeing cxgb4vf driver being loaded. | This happens because vfio-pci driver binds to the device, which causes | KOBJ_BIND to get emitted, which causes all modules that match the PCI | device ID that was bound to load [again]. | | While we could fix the issue by putting another bandaid and zapping | the modalias on KOBJ_BIND as well, I am not sure we need to do that, | as I do not see a harm in having cxgb4vf module loaded. Rather than | patching the kernel I'd recommend Casey simply update the udev scripts | to only load module on KOBJ_ADD event: | | https://github.com/systemd/systemd/commit/9b32afa9f241fe8febc0a754850f1e7331caf6e3#diff-0e123aabb4420b8b95088699179f3416 | | https://avatars3.githubusercontent.com/u/1047950?s=200&v=4 | | rules: load drivers only on "add" systemd/systemd@9b32afa | github.com | | Previously we were loading kernel modules on all device events save for | "remove". With the introduction of KOBJ_BIND/KOBJ_UNBIND this causes issues, | as driver modules that have devices bound to the... Thanks Dmitry. Now I understand why your kernel.org:1455cf8 changed this behavior. It added new BIND/UNBIND events and the current udev rules treated that as a load event. I'm not familiar with the format of /etc/udev/rules.d/ files. Komali's system doesn't have a 80-drivers.rules entry. It looks like she can just add the file with the diff to test this out. (Although I'm not sure what "tifm_sd" is ... it looks like a specific driver ...) Casey