From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751726AbdKMDnY (ORCPT ); Sun, 12 Nov 2017 22:43:24 -0500 Received: from mail-sn1nam01on0058.outbound.protection.outlook.com ([104.47.32.58]:32920 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751241AbdKMDnW (ORCPT ); Sun, 12 Nov 2017 22:43:22 -0500 From: "Liu, Monk" To: "Chen, Horace" , Colin King , "Deucher, Alexander" , "Koenig, Christian" , David Airlie , "Yu, Xiangliang" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" CC: "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver Thread-Topic: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver Thread-Index: AQHTWuNhhwwnWvhtmEOZIRvcPk3C/KMRrTyw Importance: high X-Priority: 1 Date: Mon, 13 Nov 2017 03:43:17 +0000 Message-ID: References: <20171111115110.3026-1-colin.king@canonical.com> In-Reply-To: <20171111115110.3026-1-colin.king@canonical.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Monk.Liu@amd.com; x-originating-ip: [116.228.147.243] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BN6PR12MB1651;20:nQQhAbTftst1OqVpYkM4BR4q6WuHdDrSj2BEcCBrMj9k7ZJe0VSEVB14JbcMw6HMZh75DUqR9BkLCP0aY6mQ75TjsMQDsMqwFS6hi6bBsl/G/YPx4soZ6YLPUgRbEKJfXWuUtpX5vIQmc4OM6OWOPV5nTdgB2XVZuXKRuzbE23qn4UiyhxyvYopwPH7OX4mbZT7J7aWnCF+ObVzZk1dj+4Yr+Ul8kwWqQwHQdmNYxjdL2/vsbj1CEA0rInUMeLxZ x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10009020)(6009001)(346002)(376002)(39860400002)(189002)(13464003)(199003)(53936002)(316002)(54906003)(110136005)(101416001)(81686999)(54356999)(50986999)(76176999)(6246003)(9686003)(189998001)(4326008)(55016002)(2501003)(99286004)(102836003)(3846002)(6116002)(97736004)(3660700001)(2906002)(3280700002)(53546010)(2201001)(68736007)(106356001)(6506006)(6436002)(77096006)(86362001)(2900100001)(2950100002)(7696004)(5660300001)(229853002)(72206003)(14454004)(33656002)(478600001)(8936002)(66066001)(7736002)(305945005)(25786009)(81166006)(74316002)(81156014)(105586002)(8676002)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1651;H:SN1PR12MB0462.namprd12.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-ms-office365-filtering-correlation-id: 0903e662-694b-4496-75dc-08d52a48ad92 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:BN6PR12MB1651; x-ms-traffictypediagnostic: BN6PR12MB1651: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(767451399110)(217544274631240)(198206253151910); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3231022)(6055026)(6041248)(20161123558100)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN6PR12MB1651;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN6PR12MB1651; x-forefront-prvs: 0490BBA1F0 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0903e662-694b-4496-75dc-08d52a48ad92 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2017 03:43:17.9768 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1651 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vAD3hUBB021782 + Horace -----Original Message----- From: Colin King [mailto:colin.king@canonical.com] Sent: 2017年11月11日 19:51 To: Deucher, Alexander ; Koenig, Christian ; David Airlie ; Liu, Monk ; Yu, Xiangliang ; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org Subject: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver From: Colin Ian King Variable pf2vf_ver is assigned but never read, it is redundant and hence can be removed. Cleans up clang warning: drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:310:3: warning: Value stored to 'pf2vf_ver' is never read Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c index 6738df836a70..b1cc179512fa 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c @@ -296,7 +296,6 @@ int amdgpu_virt_fw_reserve_get_checksum(void *obj, void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev) { - uint32_t pf2vf_ver = 0; uint32_t pf2vf_size = 0; uint32_t checksum = 0; uint32_t checkval; @@ -309,7 +308,6 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev) adev->virt.fw_reserve.p_pf2vf = (struct amdgim_pf2vf_info_header *)( adev->fw_vram_usage.va + AMDGIM_DATAEXCHANGE_OFFSET); - pf2vf_ver = adev->virt.fw_reserve.p_pf2vf->version; AMDGPU_FW_VRAM_PF2VF_READ(adev, header.size, &pf2vf_size); AMDGPU_FW_VRAM_PF2VF_READ(adev, checksum, &checksum); -- 2.14.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Liu, Monk" Date: Mon, 13 Nov 2017 03:43:17 +0000 Subject: RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver Message-Id: List-Id: References: <20171111115110.3026-1-colin.king@canonical.com> In-Reply-To: <20171111115110.3026-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Chen, Horace" , Colin King , "Deucher, Alexander" , "Koenig, Christian" , David Airlie , "Yu, Xiangliang" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" Cc: "kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" KyBIb3JhY2UNCg0KLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IENvbGluIEtpbmcg W21haWx0bzpjb2xpbi5raW5nQGNhbm9uaWNhbC5jb21dIA0KU2VudDogMjAxN+W5tDEx5pyIMTHm l6UgMTk6NTENClRvOiBEZXVjaGVyLCBBbGV4YW5kZXIgPEFsZXhhbmRlci5EZXVjaGVyQGFtZC5j b20+OyBLb2VuaWcsIENocmlzdGlhbiA8Q2hyaXN0aWFuLktvZW5pZ0BhbWQuY29tPjsgRGF2aWQg QWlybGllIDxhaXJsaWVkQGxpbnV4LmllPjsgTGl1LCBNb25rIDxNb25rLkxpdUBhbWQuY29tPjsg WXUsIFhpYW5nbGlhbmcgPFhpYW5nbGlhbmcuWXVAYW1kLmNvbT47IGFtZC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnOyBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnDQpDYzoga2VybmVs LWphbml0b3JzQHZnZXIua2VybmVsLm9yZzsgbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZw0K U3ViamVjdDogW1BBVENIXSBkcm0vYW1kZ3B1L3ZpcnQ6IHJlbW92ZSByZWR1bmRhbnQgdmFyaWFi bGUgcGYydmZfdmVyDQoNCkZyb206IENvbGluIElhbiBLaW5nIDxjb2xpbi5raW5nQGNhbm9uaWNh bC5jb20+DQoNClZhcmlhYmxlIHBmMnZmX3ZlciBpcyBhc3NpZ25lZCBidXQgbmV2ZXIgcmVhZCwg aXQgaXMgcmVkdW5kYW50IGFuZCBoZW5jZSBjYW4gYmUgcmVtb3ZlZC4NCg0KQ2xlYW5zIHVwIGNs YW5nIHdhcm5pbmc6DQpkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdmlydC5jOjMx MDozOiB3YXJuaW5nOiBWYWx1ZSBzdG9yZWQgdG8gJ3BmMnZmX3ZlcicgaXMgbmV2ZXIgcmVhZA0K DQpTaWduZWQtb2ZmLWJ5OiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29t Pg0KLS0tDQogZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZpcnQuYyB8IDIgLS0N CiAxIGZpbGUgY2hhbmdlZCwgMiBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92aXJ0LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9hbWRncHVfdmlydC5jDQppbmRleCA2NzM4ZGY4MzZhNzAuLmIxY2MxNzk1MTJmYSAxMDA2 NDQNCi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92aXJ0LmMNCisrKyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92aXJ0LmMNCkBAIC0yOTYsNyArMjk2 LDYgQEAgaW50IGFtZGdwdV92aXJ0X2Z3X3Jlc2VydmVfZ2V0X2NoZWNrc3VtKHZvaWQgKm9iaiwN CiANCiB2b2lkIGFtZGdwdV92aXJ0X2luaXRfZGF0YV9leGNoYW5nZShzdHJ1Y3QgYW1kZ3B1X2Rl dmljZSAqYWRldikgIHsNCi0JdWludDMyX3QgcGYydmZfdmVyID0gMDsNCiAJdWludDMyX3QgcGYy dmZfc2l6ZSA9IDA7DQogCXVpbnQzMl90IGNoZWNrc3VtID0gMDsNCiAJdWludDMyX3QgY2hlY2t2 YWw7DQpAQCAtMzA5LDcgKzMwOCw2IEBAIHZvaWQgYW1kZ3B1X3ZpcnRfaW5pdF9kYXRhX2V4Y2hh bmdlKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQ0KIAkJYWRldi0+dmlydC5md19yZXNlcnZl LnBfcGYydmYgPQ0KIAkJCShzdHJ1Y3QgYW1kZ2ltX3BmMnZmX2luZm9faGVhZGVyICopKA0KIAkJ CWFkZXYtPmZ3X3ZyYW1fdXNhZ2UudmEgKyBBTURHSU1fREFUQUVYQ0hBTkdFX09GRlNFVCk7DQot CQlwZjJ2Zl92ZXIgPSBhZGV2LT52aXJ0LmZ3X3Jlc2VydmUucF9wZjJ2Zi0+dmVyc2lvbjsNCiAJ CUFNREdQVV9GV19WUkFNX1BGMlZGX1JFQUQoYWRldiwgaGVhZGVyLnNpemUsICZwZjJ2Zl9zaXpl KTsNCiAJCUFNREdQVV9GV19WUkFNX1BGMlZGX1JFQUQoYWRldiwgY2hlY2tzdW0sICZjaGVja3N1 bSk7DQogDQotLQ0KMi4xNC4xDQoNCg= From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Liu, Monk" Subject: RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver Date: Mon, 13 Nov 2017 03:43:17 +0000 Message-ID: References: <20171111115110.3026-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171111115110.3026-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Chen, Horace" , Colin King , "Deucher, Alexander" , "Koenig, Christian" , David Airlie , "Yu, Xiangliang" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" Cc: "kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: dri-devel@lists.freedesktop.org KyBIb3JhY2UNCg0KLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IENvbGluIEtpbmcg W21haWx0bzpjb2xpbi5raW5nQGNhbm9uaWNhbC5jb21dIA0KU2VudDogMjAxN+W5tDEx5pyIMTHm l6UgMTk6NTENClRvOiBEZXVjaGVyLCBBbGV4YW5kZXIgPEFsZXhhbmRlci5EZXVjaGVyQGFtZC5j b20+OyBLb2VuaWcsIENocmlzdGlhbiA8Q2hyaXN0aWFuLktvZW5pZ0BhbWQuY29tPjsgRGF2aWQg QWlybGllIDxhaXJsaWVkQGxpbnV4LmllPjsgTGl1LCBNb25rIDxNb25rLkxpdUBhbWQuY29tPjsg WXUsIFhpYW5nbGlhbmcgPFhpYW5nbGlhbmcuWXVAYW1kLmNvbT47IGFtZC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnOyBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnDQpDYzoga2VybmVs LWphbml0b3JzQHZnZXIua2VybmVsLm9yZzsgbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZw0K U3ViamVjdDogW1BBVENIXSBkcm0vYW1kZ3B1L3ZpcnQ6IHJlbW92ZSByZWR1bmRhbnQgdmFyaWFi bGUgcGYydmZfdmVyDQoNCkZyb206IENvbGluIElhbiBLaW5nIDxjb2xpbi5raW5nQGNhbm9uaWNh bC5jb20+DQoNClZhcmlhYmxlIHBmMnZmX3ZlciBpcyBhc3NpZ25lZCBidXQgbmV2ZXIgcmVhZCwg aXQgaXMgcmVkdW5kYW50IGFuZCBoZW5jZSBjYW4gYmUgcmVtb3ZlZC4NCg0KQ2xlYW5zIHVwIGNs YW5nIHdhcm5pbmc6DQpkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdmlydC5jOjMx MDozOiB3YXJuaW5nOiBWYWx1ZSBzdG9yZWQgdG8gJ3BmMnZmX3ZlcicgaXMgbmV2ZXIgcmVhZA0K DQpTaWduZWQtb2ZmLWJ5OiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29t Pg0KLS0tDQogZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZpcnQuYyB8IDIgLS0N CiAxIGZpbGUgY2hhbmdlZCwgMiBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92aXJ0LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9hbWRncHVfdmlydC5jDQppbmRleCA2NzM4ZGY4MzZhNzAuLmIxY2MxNzk1MTJmYSAxMDA2 NDQNCi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92aXJ0LmMNCisrKyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92aXJ0LmMNCkBAIC0yOTYsNyArMjk2 LDYgQEAgaW50IGFtZGdwdV92aXJ0X2Z3X3Jlc2VydmVfZ2V0X2NoZWNrc3VtKHZvaWQgKm9iaiwN CiANCiB2b2lkIGFtZGdwdV92aXJ0X2luaXRfZGF0YV9leGNoYW5nZShzdHJ1Y3QgYW1kZ3B1X2Rl dmljZSAqYWRldikgIHsNCi0JdWludDMyX3QgcGYydmZfdmVyID0gMDsNCiAJdWludDMyX3QgcGYy dmZfc2l6ZSA9IDA7DQogCXVpbnQzMl90IGNoZWNrc3VtID0gMDsNCiAJdWludDMyX3QgY2hlY2t2 YWw7DQpAQCAtMzA5LDcgKzMwOCw2IEBAIHZvaWQgYW1kZ3B1X3ZpcnRfaW5pdF9kYXRhX2V4Y2hh bmdlKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQ0KIAkJYWRldi0+dmlydC5md19yZXNlcnZl LnBfcGYydmYgPQ0KIAkJCShzdHJ1Y3QgYW1kZ2ltX3BmMnZmX2luZm9faGVhZGVyICopKA0KIAkJ CWFkZXYtPmZ3X3ZyYW1fdXNhZ2UudmEgKyBBTURHSU1fREFUQUVYQ0hBTkdFX09GRlNFVCk7DQot CQlwZjJ2Zl92ZXIgPSBhZGV2LT52aXJ0LmZ3X3Jlc2VydmUucF9wZjJ2Zi0+dmVyc2lvbjsNCiAJ CUFNREdQVV9GV19WUkFNX1BGMlZGX1JFQUQoYWRldiwgaGVhZGVyLnNpemUsICZwZjJ2Zl9zaXpl KTsNCiAJCUFNREdQVV9GV19WUkFNX1BGMlZGX1JFQUQoYWRldiwgY2hlY2tzdW0sICZjaGVja3N1 bSk7DQogDQotLQ0KMi4xNC4xDQoNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1k LWdmeAo=