All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Greathouse, Joseph" <Joseph.Greathouse@amd.com>
To: "Kasiviswanathan, Harish" <Harish.Kasiviswanathan@amd.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: RE: [PATCH] drm/amdkfd: Add Aldebaran gws support
Date: Tue, 27 Apr 2021 22:17:49 +0000	[thread overview]
Message-ID: <SN1PR12MB23824BFFAD356C491C63F430F9419@SN1PR12MB2382.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210427195647.2212603-1-Harish.Kasiviswanathan@amd.com>

> -----Original Message-----
> From: Kasiviswanathan, Harish <Harish.Kasiviswanathan@amd.com>
> Sent: Tuesday, April 27, 2021 2:57 PM
> To: amd-gfx@lists.freedesktop.org; Greathouse, Joseph <Joseph.Greathouse@amd.com>
> Cc: Kasiviswanathan, Harish <Harish.Kasiviswanathan@amd.com>
> Subject: [PATCH] drm/amdkfd: Add Aldebaran gws support
> 
> v2: updated MEC FW version after validating gws with debugger
> 
> Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>

Reviewed-by: Joseph Greathouse <Joseph.Greathouse@amd.com>

> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_device.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> index 348fd3e49017..ae3cabb47a26 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> @@ -699,7 +699,9 @@ static int kfd_gws_init(struct kfd_dev *kfd)
>  			&& kfd->device_info->asic_family <= CHIP_RAVEN
>  			&& kfd->mec2_fw_version >= 0x1b3)
>  		|| (kfd->device_info->asic_family == CHIP_ARCTURUS
> -			&& kfd->mec2_fw_version >= 0x30))
> +			&& kfd->mec2_fw_version >= 0x30)
> +		|| (kfd->device_info->asic_family == CHIP_ALDEBARAN
> +			&& kfd->mec2_fw_version >= 0x28))
>  		ret = amdgpu_amdkfd_alloc_gws(kfd->kgd,
>  				amdgpu_amdkfd_get_num_gws(kfd->kgd), &kfd->gws);
> 
> --
> 2.25.1


_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  reply	other threads:[~2021-04-27 22:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27 19:56 [PATCH] drm/amdkfd: Add Aldebaran gws support Harish Kasiviswanathan
2021-04-27 22:17 ` Greathouse, Joseph [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-04-22  2:01 Harish Kasiviswanathan
2021-04-22  2:11 ` Felix Kuehling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN1PR12MB23824BFFAD356C491C63F430F9419@SN1PR12MB2382.namprd12.prod.outlook.com \
    --to=joseph.greathouse@amd.com \
    --cc=Harish.Kasiviswanathan@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.