From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Anand Jain <anand.jain@oracle.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v7 3/5] btrfs: create read policy sysfs attribute, pid
Date: Tue, 19 May 2020 10:07:39 +0000 [thread overview]
Message-ID: <SN4PR0401MB3598EF0DF22C63F087969E8D9BB90@SN4PR0401MB3598.namprd04.prod.outlook.com> (raw)
In-Reply-To: 1586173871-5559-4-git-send-email-anand.jain@oracle.com
On 06/04/2020 13:51, Anand Jain wrote:
> +static ssize_t btrfs_read_policy_store(struct kobject *kobj,
> + struct kobj_attribute *a,
> + const char *buf, size_t len)
> +{
> + int i;
> + struct btrfs_fs_devices *fs_devices = to_fs_devs(kobj);
> +
> + for (i = 0; i < BTRFS_NR_READ_POLICY; i++) {
> + if (btrfs_strmatch(buf, btrfs_read_policy_name[i]) == 0) {
> + if (i != fs_devices->read_policy) {
> + fs_devices->read_policy = i;
> + btrfs_info(fs_devices->fs_info,
> + "read policy set to '%s'",
> + btrfs_read_policy_name[i]);
> + }
> + return len;
> + }
> + }
Naive question, what's the advantage over sysfs_match_string()?
next prev parent reply other threads:[~2020-05-19 10:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 11:51 [PATCH v7 rebased 0/5] readmirror feature (sysfs and in-memory only approach; with new read_policy device) Anand Jain
2020-04-06 11:51 ` [PATCH v7 1/5] btrfs: add btrfs_strmatch helper Anand Jain
2020-04-06 11:51 ` [PATCH v7 2/5] btrfs: create read policy framework Anand Jain
2020-04-06 11:51 ` [PATCH v7 3/5] btrfs: create read policy sysfs attribute, pid Anand Jain
2020-05-19 10:07 ` Johannes Thumshirn [this message]
2020-05-20 8:54 ` Anand Jain
2020-05-20 8:55 ` Johannes Thumshirn
2020-04-06 11:51 ` [PATCH v7 4/5] btrfs: introduce new device-state read_preferred Anand Jain
2020-04-06 11:51 ` [PATCH v7 5/5] btrfs: introduce new read_policy device Anand Jain
2020-04-30 9:02 ` [PATCH v7 rebased 0/5] readmirror feature (sysfs and in-memory only approach; with new read_policy device) Anand Jain
2020-05-15 19:58 ` David Sterba
2020-05-19 10:02 ` Anand Jain
2020-05-22 13:46 ` David Sterba
2020-05-26 7:23 ` Anand Jain
2020-06-01 15:07 ` David Sterba
2020-05-22 19:15 ` Steven Davies
-- strict thread matches above, loose matches on Subject: below --
2020-02-21 6:15 [PATCH v7 " Anand Jain
2020-02-21 6:15 ` [PATCH v7 3/5] btrfs: create read policy sysfs attribute, pid Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN4PR0401MB3598EF0DF22C63F087969E8D9BB90@SN4PR0401MB3598.namprd04.prod.outlook.com \
--to=johannes.thumshirn@wdc.com \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.