From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D6FBC433C1 for ; Tue, 23 Mar 2021 08:08:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 260CC619BD for ; Tue, 23 Mar 2021 08:08:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229437AbhCWIIS (ORCPT ); Tue, 23 Mar 2021 04:08:18 -0400 Received: from mail-bn8nam11on2047.outbound.protection.outlook.com ([40.107.236.47]:5493 "EHLO NAM11-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229494AbhCWIIE (ORCPT ); Tue, 23 Mar 2021 04:08:04 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gQFkbfNgi8eRnPNNAHn6edwPFGyBSK/+URA5a8TvsLHRHHBLXgv5pvcmoNwyQ/MofacQChZEei+PIZ3o9ZzRhje6Lfj5Ou7RzNgT0/O85JIY/HIKErFb0k3sk7XBn9TEZ56DjrQIwqfd+k/iHGXFHBNMmCZCUe1x3Lfro2oyN2iCVvJ9jAxqJAbRLB7sf03xn60Vhigr9TdEdk1H+mzWdokP+S2zxWzBQUQxb0eqNj6KXKdRPkHcgF5COgzAjf+TxZ5Yh6Vua3kwB9LpGRgDG3tlNCKN295QqKVClDidxmovJTNAifWDAxy4+2OuzukVV8fU/4RbhcBJoD3oMI7EcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lp420zV6IVNgryveUjQqbKDskXKAsVBww21Pd5FNeyQ=; b=BB1/CEc4NElRtCJfXuRGLurU0bmVbN6KrK6Jk+JIoYva1KssLqakM2e+zDTquR/cHDgIjA8Wy30UmTuEh6VacPsuXnn9kbfYzL3/QfceIkHX+6pI3EoX77cekQYa2NK+hroVlC5mEEuHCrZysVPA0TEKnZNXgAo/ERmJ2Z6JF0VKCuAQaOn3Waxtyd0RN4lKbUG3yRxSLyjatlpDlVRbJHelBMNfFDiQaPh3hl2wrGLrlxs4otW4qUUq2IGTJM8+eiwO68X/FR4vbMlOXiWL/3O2cTKMXBz8wyKhE4pmxGSK87qPsT8D5deIryYAJkTfu50RbCSrBnNQwEnFFP0Hfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xilinx.com; dmarc=pass action=none header.from=xilinx.com; dkim=pass header.d=xilinx.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lp420zV6IVNgryveUjQqbKDskXKAsVBww21Pd5FNeyQ=; b=ZCmbgrwHL6iijzdcFe8Q9WO/HQIGW2tCbexhQ4r75HRwyxbiTeQDUNuaJHCQdxuM5Krj/3qlf0mJvWoY0J6Rf4VsXlRdoKWBNCpvIo7a/XxPlZ1H/QtuCyVBi4Intx8+B8R/FnN4s8rafILMTcHttBrCt5IZ/uwujCDO4VbeWYM= Received: from SN6PR02MB3917.namprd02.prod.outlook.com (2603:10b6:805:2e::26) by SN1PR02MB3839.namprd02.prod.outlook.com (2603:10b6:802:31::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Tue, 23 Mar 2021 08:08:00 +0000 Received: from SN6PR02MB3917.namprd02.prod.outlook.com ([fe80::68cc:492b:dd78:daba]) by SN6PR02MB3917.namprd02.prod.outlook.com ([fe80::68cc:492b:dd78:daba%4]) with mapi id 15.20.3955.025; Tue, 23 Mar 2021 08:08:00 +0000 From: Sai Krishna Potthuri To: Andy Shevchenko CC: Linus Walleij , Rob Herring , Michal Simek , Greg Kroah-Hartman , linux-arm Mailing List , Linux Kernel Mailing List , devicetree , "open list:GPIO SUBSYSTEM" , git , "saikrishna12468@gmail.com" Subject: RE: [PATCH v4 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support Thread-Topic: [PATCH v4 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support Thread-Index: AQHXGwdloppct9WdF06D8lw8GDUKq6qII6IAgAEUy/CAAeU9gIAE1ayQgABU24CAAMTl4A== Date: Tue, 23 Mar 2021 08:08:00 +0000 Message-ID: References: <1615969516-87663-1-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> <1615969516-87663-4-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=xilinx.com; x-originating-ip: [149.199.50.128] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: fcaa513f-1726-4839-df09-08d8edd2c6a4 x-ms-traffictypediagnostic: SN1PR02MB3839: x-ld-processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wHJtiKzm0wrF7dK1bVz/8NPmlH3HpZiMbmiI3aIYuaZqTP4KlIIzrr4W9GGHS9K4lwUm7IXZaMT3tZy/J8dY62hWvvubGewfCfmLcQ9NURUR8FIske5ch5r0pUDKEQTJoKna46VFYXlBlEytFG1NQRvW/yH5Z5kHIlmiLn/9mOXjKun2Rlxu1kY6EcSYeOfelN4P3OopvCDWXXpObO1wScuTbIAQmPtgjaR/9v4knNLGco5dTuoh90pgbczlsk7F+sbaTzAxCauQsV6eNfiFJWoHLDXgytqw8elZXviHZgv+qpda/RpkbQj/Sek5w0Sbbxw5BCr60gF0wK5rLMwGRz+fRZvrIPR/wuoRpr157NEukfoTnfgwNMwl4SpUeqrf8Afz/sR91NVmJa4gNbk/Pi6fNDY/KUP2xHWsnwdZRtGd1Rw2oywR7C4Bs+BWzRQWXGwaylYxgCgt5I2jiZWv+Au265SRDOISbSR/tC6fePjmvyY00rEL3xTas2nXCDyQTZRsyxI0+hCi31vkUH8J8UNERJX0nWDcDpx27ivNkVc1YW4AiN3RHbm8TLhBiKp8Ulk23CAEu6AULb/ihKTYPR9/sjOdx/uCdeHXacxktcOFJk8PEVp5aeExOkkwaiqiGIFJS2i14Onyrip4sKselSkViW7k2ZXFOFHzqwkX0oM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR02MB3917.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(39860400002)(366004)(396003)(136003)(376002)(8936002)(7416002)(4326008)(8676002)(6916009)(33656002)(54906003)(26005)(186003)(71200400001)(83380400001)(53546011)(64756008)(316002)(2906002)(9686003)(66446008)(66476007)(5660300002)(52536014)(66556008)(66946007)(38100700001)(76116006)(86362001)(6506007)(7696005)(478600001)(55016002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?SzNDR1Izb0xoQTZnR0ZBQzlaQ0FZTkFnVHZsMlhVamJGWUpwSkJMYStWeEIz?= =?utf-8?B?Y2VpRFZFdm0vcFlEWEpqTlVuNVlMNTQ3Um85d28xSldGQXN3RUMrdlFzb2R1?= =?utf-8?B?c1Z1RHpCaTJEVlZqWm1qT0VaTExjWEJYVS9ONDNrQjJuUno3MXpJYjFRbGxn?= =?utf-8?B?c01pUjlkb1lnUGozSjdQWWs3NFlKZ28yWWpJNXFESW1Uc243N1NOcko3YmFy?= =?utf-8?B?SjFMcmxqcGs0ZTJyN1NFZUVtR2VxcEpsVXFXR05GUmFVMWducHlrd2d4RXlP?= =?utf-8?B?b3JNZVF5RGdiYmNQMWZZSmVtcjBwVkdaLzVOUkVQbDZzbEdqeHVaUzFuNzBi?= =?utf-8?B?U0dRdk10UHBuZTRkMk5pbXRydDJRZ0p6aUJmZ0txQWo0aFJoeDFYU05FMXNB?= =?utf-8?B?akdmQTV6MnhLcDBYcUZ2STJpdmZ4RWdjYjQ3eGtUTTlGK2RsVFNVdE4yMS9t?= =?utf-8?B?TGtoSHZjMnFBd05jcEFXVXJXTllwZktTdkZBTFdhNjFadmxFajBDYVlUd0gv?= =?utf-8?B?V3pLNURjb1ovUkFnNEhSZEFoZHM3SkRzNkIzYUw1VnF6TUVqM2h3ZThndzdD?= =?utf-8?B?c0FFanNwa0xmbmw5MUdxTWo2bzZSZjNqOXY0SUN0bkpZVjdHRzhHcjh2RmpP?= =?utf-8?B?UklCMHZDZG9zTUpkRjJsOXNXUjVaaERHa3FGUVpDWHRTQTk1UUFSOHFHaG02?= =?utf-8?B?b01WNnlTVlpRRjlMZHhDby9LekN0blV4c256NVJ5U3l0bVRwMkNHelN6OTlC?= =?utf-8?B?dmI3bm1pZVlBK1N4ditqWHZXWjlzY0J4TlRPYjgxbHdnK0I1djM1OWJqUWRI?= =?utf-8?B?anNVcWZ2MmNwUlJxazB6cTNENFhsV3EySHBtRk83d1Zoa1JkVzFKNjBGR2ta?= =?utf-8?B?VmNEUDRDQjQrTEpNVkUrVkJJVlNqYW9FTkFRZzRGRkZmK2VwWHR0eE9tWUk3?= =?utf-8?B?N1hBRC93ZEhzTUc3S1BCdGhTOVFOL21zUWpLQVlOc0NpNHdoOFpDc1RzZ3I1?= =?utf-8?B?SHRGRXVFUWVmK1ZEcmdJRUFOdEhsNFh6Nm41Z05YUGhZMWY3V1dkdGRHRm4v?= =?utf-8?B?REVZZFVjQ2k0bDZnWkg4Wk5BeXdaenJGS0RPTmhrVlNKQWV5Z3lXcnpaTHdS?= =?utf-8?B?cjFQb0ljeWhJcVZMN3V2ZWxHNjFxaFJMME0vVzFtTVNMQ2RDRU1HenVOVzdE?= =?utf-8?B?ZVh1YUdmU1NaSFJyQ1hvUHpWdnAxR3BScUxoVUJscjRPcjdxak5Fb2RvUjhz?= =?utf-8?B?cThBWHd1cjl3Q2lQcW1MZFh2aGlveVNQZmRPSVRpK3BWUkx5NlJPaDcxVmhP?= =?utf-8?B?ZElIS0EyNjZsM294MXhWMUhWWEtvOVpydnRKMWQxYVYxd3Via2x2c3JSK0FU?= =?utf-8?B?ekUzSWsvV0l2ejZNZnVQZ1NBUDE2YnF5cjhuUDN3eml4dC9BNWM4QndlcE04?= =?utf-8?B?ZGpqbUdRa1ZRWjdqWmtDT0xlQXdaa2xyUk5xbGM2WkkwbWkrVFlEd1lJUGVn?= =?utf-8?B?ZnV1YlhsUnZCWDdBRll5cmNjcGM5TFUzUTh5T0lzdyt2cno1OXVQUFBpWVlo?= =?utf-8?B?RUdWTmt6eXVmOWJETEsySEVta2ZFcWtDbUd2OXFXVk1RaXNvVlhkSmtJNThR?= =?utf-8?B?Zm55RE5mUDNKbHludnpSdEs1SzR1WWlXRGZ5V3I5TTNzV1U4eE9PdWRid0Zy?= =?utf-8?B?KzY3MnVLcWdLRmxHdk1GTTVtWngzc0I5UDFTTDFiVExwRGFZMjdoWFd2YXh6?= =?utf-8?Q?Q0RGuyC+5Xtpsvv7DOu45WDWrwfkuxB8cJUNmV7?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB3917.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fcaa513f-1726-4839-df09-08d8edd2c6a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2021 08:08:00.3134 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FhVaaEzjkPOucSut61F4VY4EhcLzItdBUOfvGDv5jWDfboSIZBKYD4kynHKh0nWm+OT1hUnwYljSUgOIJCRzlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR02MB3839 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org SGkgQW5keSBTaGV2Y2hlbmtvLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZy b206IEFuZHkgU2hldmNoZW5rbyA8YW5keS5zaGV2Y2hlbmtvQGdtYWlsLmNvbT4NCj4gU2VudDog TW9uZGF5LCBNYXJjaCAyMiwgMjAyMSAxMDo0NyBQTQ0KPiBUbzogU2FpIEtyaXNobmEgUG90dGh1 cmkgPGxha3NobWlzQHhpbGlueC5jb20+DQo+IENjOiBMaW51cyBXYWxsZWlqIDxsaW51cy53YWxs ZWlqQGxpbmFyby5vcmc+OyBSb2IgSGVycmluZw0KPiA8cm9iaCtkdEBrZXJuZWwub3JnPjsgTWlj aGFsIFNpbWVrIDxtaWNoYWxzQHhpbGlueC5jb20+OyBHcmVnIEtyb2FoLQ0KPiBIYXJ0bWFuIDxn cmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz47IGxpbnV4LWFybSBNYWlsaW5nIExpc3QgPGxpbnV4 LWFybS0NCj4ga2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc+OyBMaW51eCBLZXJuZWwgTWFpbGlu ZyBMaXN0IDxsaW51eC0NCj4ga2VybmVsQHZnZXIua2VybmVsLm9yZz47IGRldmljZXRyZWUgPGRl dmljZXRyZWVAdmdlci5rZXJuZWwub3JnPjsgb3Blbg0KPiBsaXN0OkdQSU8gU1VCU1lTVEVNIDxs aW51eC1ncGlvQHZnZXIua2VybmVsLm9yZz47IGdpdCA8Z2l0QHhpbGlueC5jb20+Ow0KPiBzYWlr cmlzaG5hMTI0NjhAZ21haWwuY29tDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjQgMy8zXSBwaW5j dHJsOiBBZGQgWGlsaW54IFp5bnFNUCBwaW5jdHJsIGRyaXZlciBzdXBwb3J0DQo+IA0KPiBPbiBN b24sIE1hciAyMiwgMjAyMSBhdCA1OjI1IFBNIFNhaSBLcmlzaG5hIFBvdHRodXJpDQo+IDxsYWtz aG1pc0B4aWxpbnguY29tPiB3cm90ZToNCj4gPiA+IEZyb206IEFuZHkgU2hldmNoZW5rbyA8YW5k eS5zaGV2Y2hlbmtvQGdtYWlsLmNvbT4NCj4gPiA+IFNlbnQ6IEZyaWRheSwgTWFyY2ggMTksIDIw MjEgMzo1MyBQTSBPbiBUaHUsIE1hciAxOCwgMjAyMSBhdCA0OjQyIFBNDQo+ID4gPiBTYWkgS3Jp c2huYSBQb3R0aHVyaSA8bGFrc2htaXNAeGlsaW54LmNvbT4NCj4gPiA+IHdyb3RlOg0KPiA+ID4g PiA+IEZyb206IEFuZHkgU2hldmNoZW5rbyA8YW5keS5zaGV2Y2hlbmtvQGdtYWlsLmNvbT4NCj4g PiA+ID4gPiBTZW50OiBXZWRuZXNkYXksIE1hcmNoIDE3LCAyMDIxIDY6MjYgUE0gT24gV2VkLCBN YXIgMTcsIDIwMjEgYXQNCj4gPiA+ID4gPiAxMDoyNyBBTSBTYWkgS3Jpc2huYSBQb3R0aHVyaQ0K PiA+ID4gPiA+IDxsYWtzaG1pLnNhaS5rcmlzaG5hLnBvdHRodXJpQHhpbGlueC5jb20+IHdyb3Rl Og0KPiANCj4gLi4uDQo+IA0KPiA+ID4gPiAjaW5jbHVkZSA8ZHQtYmluZGluZ3MvcGluY3RybC9w aW5jdHJsLXp5bnFtcC5oPg0KPiA+ID4NCj4gPiA+IExvb2tpbmcgaW50byBvdGhlciBkcml2ZXJz IHdpdGggc2ltaWxhciBpbmNsdWRlcywgc2hvdWxkbid0IGl0IGdvDQo+ID4gPiBmaXJzdCBpbiB0 aGUgZmlsZSBiZWZvcmUgYW55IG90aGVyIGxpbnV4LyogYXNtLyogZXRjPw0KPiA+IEkgc2VlIHNv bWUgZHJpdmVycyBhcmUgaW5jbHVkaW5nIHRoaXMgaGVhZGVyIGJlZm9yZSBsaW51eC8qIGFuZCBz b21lDQo+ID4gYXJlIHVzaW5nIGFmdGVyIGxpbnV4LyouDQo+IA0KPiBUaGUgcnVsZSBvZiB0aHVt YiBpcyB0aGF0OiBtb3JlIGdlbmVyaWMgaGVhZGVycyBhcmUgZ29pbmcgZmlyc3QuDQo+IA0KPiBJ IGNvbnNpZGVyIGR0Lyogb25lcyBhcmUgbW9yZSBnZW5lcmljIHRoYW4gbGludXgvKiBvbmVzIGJl Y2F1c2UgdGhleSBhcmUNCj4gY292ZXJpbmcgbW9yZSB0aGFuIGp1c3QgdGhlIExpbnV4IGtlcm5l bC4NCk9rLCBJIHdpbGwgcmVvcmRlciBhY2NvcmRpbmdseS4NCj4gDQo+IC4uLg0KPiANCj4gPiA+ ID4gPiBJJ20gbG9zdCBoZXJlLiBXaGF0IGlzIElPIHN0YW5kYXJkIGV4YWN0bHk/IFdoeSBpdCBj YW4ndCBiZSBpbg0KPiA+ID4gPiA+IGdlbmVyaWMgaGVhZGVycz8NCj4gPiA+ID4gSXQgcmVwcmVz ZW50cyBMVkNNT1MgMy4zIHZvbHRzLyBMVkNNT1MgMS44IHZvbHRzLg0KPiA+ID4gPiBTaW5jZSB0 aGlzIGlzIHNwZWNpZmljIHRvIFhpbGlueCBaeW5xTVAgcGxhdGZvcm0sIGNvbnNpZGVyZWQgdG8g YmUNCj4gPiA+ID4gYWRkZWQgaW4gdGhlIGRyaXZlciBmaWxlLg0KPiA+ID4NCj4gPiA+IFNvLCB3 aHkgY2FuJ3Qgd2UgY3JlYXRlIGEgY291cGxlIG9mIGJpdHMgdG8gcmVwcmVzZW50IHRoaXMgdm9s dGFnZXMNCj4gPiA+IGluIHRoZSBnZW5lcmljIGhlYWRlciBhbmQgZ2FpbiB1c2FiaWxpdHkgZm9y IG90aGVycyBhcyB3ZWxsPw0KPiA+IEkgc2VlIHNvbWUgZHJpdmVycyBhcmUgbWFpbnRhaW5pbmcg dGhlIGNvbmZpZ3VyYXRpb24gbGlzdCBpbiB0aGUNCj4gPiBkcml2ZXIgZmlsZSwgaWYgdGhlIGNv bmZpZ3VyYXRpb24gaXMgc3BlY2lmaWMgdG8gdGhlIGRyaXZlci4NCj4gDQo+IFllcywgbXkgcG9p bnQgaXMgdGhhdCB0aGlzIGNhc2UgZG9lc24ndCBzb3VuZCB0b28gc3BlY2lmaWMgdG8gdGhlIGRy aXZlci4gTWFueQ0KPiBwaW4gY29udHJvbCBidWZmZXJzIChpbiBoYXJkd2FyZSB3YXkgb2Ygc3Bl YWtpbmcpIGhhdmUgcHJvcGVydGllcyB0byBiZQ0KPiBkaWZmZXJlbnQgdm9sdGFnZSB0b2xlcmFu dCAvIHByb2R1Y2UuDQpPaywgeW91IHdhbnQgbWUgdG8gcHJvY2VlZCB3aXRoIHRoaXMgY2hhbmdl IG9yIHNoYWxsIHdlIHdhaXQgZm9yDQpMaW51cyB0byBjb21tZW50Pw0KPiANCj4gPiBXZSBjYW4g bW92ZSB0aGlzIHRvIGdlbmVyaWMgaGVhZGVyIGlmIGl0IGlzIHVzZWQgYnkgb3RoZXJzIGFzIHdl bGwuDQo+ID4gT2ssIHdpbGwgd2FpdCBmb3IgTGludXMgdG8gY29tbWVudC4NCj4gPiA+DQo+ID4g PiBMaW51cz8NCj4gDQo+IC4uLg0KPiANCj4gPiA+ID4gPiA+ICsgICAgICAgcmV0ID0genlucW1w X3BtX3BpbmN0cmxfcmVxdWVzdChwaW4pOw0KPiA+ID4gPiA+ID4gKyAgICAgICBpZiAocmV0KSB7 DQo+ID4gPiA+ID4gPiArICAgICAgICAgICAgICAgZGV2X2VycihwY3RsZGV2LT5kZXYsICJyZXF1 ZXN0IGZhaWxlZCBmb3IgcGluDQo+ID4gPiA+ID4gPiArICV1XG4iLCBwaW4pOw0KPiA+ID4gPiA+ DQo+ID4gPiA+ID4gPiArICAgICAgICAgICAgICAgcmV0dXJuIC1FSU87DQo+ID4gPiA+ID4NCj4g PiA+ID4gPiBXaHkgc2hhZG93aW5nIGVycm9yIGNvZGU/DQo+ID4gPg0KPiA+ID4gU28sIGFueSBj b21tZW50cyBvbiB0aGUgaW5pdGlhbCBRPw0KPiA+IFhpbGlueCBsb3cgbGV2ZWwgc2VjdXJlIGZp cm13YXJlIGVycm9yIGNvZGVzIGFyZSBkaWZmZXJlbnQgZnJvbSBMaW51eCBlcnJvcg0KPiBjb2Rl cy4NCj4gPiBTZWN1cmUgZmlybXdhcmUgbWFpbnRhaW5zIGxpc3Qgb2YgZXJyb3IgY29kZXMgKHBv c2l0aXZlIHZhbHVlcyBvdGhlciB0aGFuDQo+IHplcm8pLg0KPiA+IEhlbmNlIHdlIHJldHVybiAt RUlPLCBpZiB0aGUgcmV0dXJuIHZhbHVlIGZyb20gZmlybXdhcmUgaXMgbm9uLXplcm8uDQo+IA0K PiBXaHkgdGhlIHp5bnFtcF9wbV9waW5jdHJsX3JlcXVlc3QoKSBjYW4ndCByZXR1cm4gY29kZXMg aW4gTGludXggZXJyb3INCj4gY29kZSBzcGFjZT8NCkkgY3Jvc3MgY2hlY2tlZCB3aXRoIHRoZSBY aWxpbnggZmlybXdhcmUgdGVhbSwgZmlybXdhcmUgZHJpdmVyIGlzIG5vdyByZXR1cm5pbmcNCkxp bnV4IGVycm9yIGNvZGVzIGluIHRoZSBsYXRlc3Qga2VybmVsIGJ1dCB3aGlsZSBkZXZlbG9waW5n IHRoZSBkcml2ZXIgaXQgd2FzIGENCmRpZmZlcmVudCBhcHByb2FjaC4gSSB3aWxsIHVwZGF0ZSB0 aGUgZHJpdmVyIHRvIHNpbXBseSByZXR1cm4gdGhlIHZhbHVlcyBmcm9tDQpmaXJtd2FyZSBjYWxs cy4NCj4gDQo+ID4gPiA+PiAgU2luY2UgaXQncyB0aGUgb25seSBwb3NzaWJsZSBlcnJvciwgd2h5 IGlzIGl0IG5vdA0KPiA+ID4gPiA+IHJlZmxlY3RlZCBpbiB0aGUga2VybmVsIGRvYz8NCj4gPiA+ ID4gSSB3aWxsIHVwZGF0ZSB0aGUga2VybmVsIGRvYyB3aXRoIHRoZSBlcnJvciB2YWx1ZSBmb3Ig c3VjaCBjYXNlcy4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gKyAgICAgICB9DQo+IA0KPiAtLQ0K PiBXaXRoIEJlc3QgUmVnYXJkcywNCj4gQW5keSBTaGV2Y2hlbmtvDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A243C433C1 for ; Tue, 23 Mar 2021 08:10:04 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 860D7619BF for ; Tue, 23 Mar 2021 08:10:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 860D7619BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KNFYQxe98zgRyeBjkcilJpTiq5h1JspAaB+URkRk9fM=; b=JhYgLFh0QJHwgpq97a0ZLCdet 1dRNLKx2vpVVnFKSEvw3Js9vsPxQTe5/TVAAwEriGfS0OJBlFxUDuPXOUgGRDyxOItpKKa6BrRd0r 6AgbaoeClkP7QCMXDnYMhA4lqqMOvxOevV2JtFhBL88GDCt880hXlaRASpuWMZdc1sVTzX0ivTeNq rtmsD4r2g9TNa6Yae22a9O6kmX21BzseVNjl6F9v56uWCxOAUqBfAvUfkN4dwt/fA11iXqk7K1r+u PAouEC8hoZ13tZK4crd+LbR6RqjAu/mmhZp2/C5k7oRM2IxrFs7Qdo5kiORAF+4EZQsEdccS6y+iq Q7QxrFjFQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOc5B-00EGXr-Uh; Tue, 23 Mar 2021 08:08:10 +0000 Received: from mail-bn8nam11on2041.outbound.protection.outlook.com ([40.107.236.41] helo=NAM11-BN8-obe.outbound.protection.outlook.com) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lOc57-00EGX2-7v for linux-arm-kernel@lists.infradead.org; Tue, 23 Mar 2021 08:08:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gQFkbfNgi8eRnPNNAHn6edwPFGyBSK/+URA5a8TvsLHRHHBLXgv5pvcmoNwyQ/MofacQChZEei+PIZ3o9ZzRhje6Lfj5Ou7RzNgT0/O85JIY/HIKErFb0k3sk7XBn9TEZ56DjrQIwqfd+k/iHGXFHBNMmCZCUe1x3Lfro2oyN2iCVvJ9jAxqJAbRLB7sf03xn60Vhigr9TdEdk1H+mzWdokP+S2zxWzBQUQxb0eqNj6KXKdRPkHcgF5COgzAjf+TxZ5Yh6Vua3kwB9LpGRgDG3tlNCKN295QqKVClDidxmovJTNAifWDAxy4+2OuzukVV8fU/4RbhcBJoD3oMI7EcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lp420zV6IVNgryveUjQqbKDskXKAsVBww21Pd5FNeyQ=; b=BB1/CEc4NElRtCJfXuRGLurU0bmVbN6KrK6Jk+JIoYva1KssLqakM2e+zDTquR/cHDgIjA8Wy30UmTuEh6VacPsuXnn9kbfYzL3/QfceIkHX+6pI3EoX77cekQYa2NK+hroVlC5mEEuHCrZysVPA0TEKnZNXgAo/ERmJ2Z6JF0VKCuAQaOn3Waxtyd0RN4lKbUG3yRxSLyjatlpDlVRbJHelBMNfFDiQaPh3hl2wrGLrlxs4otW4qUUq2IGTJM8+eiwO68X/FR4vbMlOXiWL/3O2cTKMXBz8wyKhE4pmxGSK87qPsT8D5deIryYAJkTfu50RbCSrBnNQwEnFFP0Hfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xilinx.com; dmarc=pass action=none header.from=xilinx.com; dkim=pass header.d=xilinx.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lp420zV6IVNgryveUjQqbKDskXKAsVBww21Pd5FNeyQ=; b=ZCmbgrwHL6iijzdcFe8Q9WO/HQIGW2tCbexhQ4r75HRwyxbiTeQDUNuaJHCQdxuM5Krj/3qlf0mJvWoY0J6Rf4VsXlRdoKWBNCpvIo7a/XxPlZ1H/QtuCyVBi4Intx8+B8R/FnN4s8rafILMTcHttBrCt5IZ/uwujCDO4VbeWYM= Received: from SN6PR02MB3917.namprd02.prod.outlook.com (2603:10b6:805:2e::26) by SN1PR02MB3839.namprd02.prod.outlook.com (2603:10b6:802:31::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Tue, 23 Mar 2021 08:08:00 +0000 Received: from SN6PR02MB3917.namprd02.prod.outlook.com ([fe80::68cc:492b:dd78:daba]) by SN6PR02MB3917.namprd02.prod.outlook.com ([fe80::68cc:492b:dd78:daba%4]) with mapi id 15.20.3955.025; Tue, 23 Mar 2021 08:08:00 +0000 From: Sai Krishna Potthuri To: Andy Shevchenko CC: Linus Walleij , Rob Herring , Michal Simek , Greg Kroah-Hartman , linux-arm Mailing List , Linux Kernel Mailing List , devicetree , "open list:GPIO SUBSYSTEM" , git , "saikrishna12468@gmail.com" Subject: RE: [PATCH v4 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support Thread-Topic: [PATCH v4 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support Thread-Index: AQHXGwdloppct9WdF06D8lw8GDUKq6qII6IAgAEUy/CAAeU9gIAE1ayQgABU24CAAMTl4A== Date: Tue, 23 Mar 2021 08:08:00 +0000 Message-ID: References: <1615969516-87663-1-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> <1615969516-87663-4-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=xilinx.com; x-originating-ip: [149.199.50.128] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: fcaa513f-1726-4839-df09-08d8edd2c6a4 x-ms-traffictypediagnostic: SN1PR02MB3839: x-ld-processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wHJtiKzm0wrF7dK1bVz/8NPmlH3HpZiMbmiI3aIYuaZqTP4KlIIzrr4W9GGHS9K4lwUm7IXZaMT3tZy/J8dY62hWvvubGewfCfmLcQ9NURUR8FIske5ch5r0pUDKEQTJoKna46VFYXlBlEytFG1NQRvW/yH5Z5kHIlmiLn/9mOXjKun2Rlxu1kY6EcSYeOfelN4P3OopvCDWXXpObO1wScuTbIAQmPtgjaR/9v4knNLGco5dTuoh90pgbczlsk7F+sbaTzAxCauQsV6eNfiFJWoHLDXgytqw8elZXviHZgv+qpda/RpkbQj/Sek5w0Sbbxw5BCr60gF0wK5rLMwGRz+fRZvrIPR/wuoRpr157NEukfoTnfgwNMwl4SpUeqrf8Afz/sR91NVmJa4gNbk/Pi6fNDY/KUP2xHWsnwdZRtGd1Rw2oywR7C4Bs+BWzRQWXGwaylYxgCgt5I2jiZWv+Au265SRDOISbSR/tC6fePjmvyY00rEL3xTas2nXCDyQTZRsyxI0+hCi31vkUH8J8UNERJX0nWDcDpx27ivNkVc1YW4AiN3RHbm8TLhBiKp8Ulk23CAEu6AULb/ihKTYPR9/sjOdx/uCdeHXacxktcOFJk8PEVp5aeExOkkwaiqiGIFJS2i14Onyrip4sKselSkViW7k2ZXFOFHzqwkX0oM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR02MB3917.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(366004)(396003)(136003)(376002)(8936002)(7416002)(4326008)(8676002)(6916009)(33656002)(54906003)(26005)(186003)(71200400001)(83380400001)(53546011)(64756008)(316002)(2906002)(9686003)(66446008)(66476007)(5660300002)(52536014)(66556008)(66946007)(38100700001)(76116006)(86362001)(6506007)(7696005)(478600001)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?SzNDR1Izb0xoQTZnR0ZBQzlaQ0FZTkFnVHZsMlhVamJGWUpwSkJMYStWeEIz?= =?utf-8?B?Y2VpRFZFdm0vcFlEWEpqTlVuNVlMNTQ3Um85d28xSldGQXN3RUMrdlFzb2R1?= =?utf-8?B?c1Z1RHpCaTJEVlZqWm1qT0VaTExjWEJYVS9ONDNrQjJuUno3MXpJYjFRbGxn?= =?utf-8?B?c01pUjlkb1lnUGozSjdQWWs3NFlKZ28yWWpJNXFESW1Uc243N1NOcko3YmFy?= =?utf-8?B?SjFMcmxqcGs0ZTJyN1NFZUVtR2VxcEpsVXFXR05GUmFVMWducHlrd2d4RXlP?= =?utf-8?B?b3JNZVF5RGdiYmNQMWZZSmVtcjBwVkdaLzVOUkVQbDZzbEdqeHVaUzFuNzBi?= =?utf-8?B?U0dRdk10UHBuZTRkMk5pbXRydDJRZ0p6aUJmZ0txQWo0aFJoeDFYU05FMXNB?= =?utf-8?B?akdmQTV6MnhLcDBYcUZ2STJpdmZ4RWdjYjQ3eGtUTTlGK2RsVFNVdE4yMS9t?= =?utf-8?B?TGtoSHZjMnFBd05jcEFXVXJXTllwZktTdkZBTFdhNjFadmxFajBDYVlUd0gv?= =?utf-8?B?V3pLNURjb1ovUkFnNEhSZEFoZHM3SkRzNkIzYUw1VnF6TUVqM2h3ZThndzdD?= =?utf-8?B?c0FFanNwa0xmbmw5MUdxTWo2bzZSZjNqOXY0SUN0bkpZVjdHRzhHcjh2RmpP?= =?utf-8?B?UklCMHZDZG9zTUpkRjJsOXNXUjVaaERHa3FGUVpDWHRTQTk1UUFSOHFHaG02?= =?utf-8?B?b01WNnlTVlpRRjlMZHhDby9LekN0blV4c256NVJ5U3l0bVRwMkNHelN6OTlC?= =?utf-8?B?dmI3bm1pZVlBK1N4ditqWHZXWjlzY0J4TlRPYjgxbHdnK0I1djM1OWJqUWRI?= =?utf-8?B?anNVcWZ2MmNwUlJxazB6cTNENFhsV3EySHBtRk83d1Zoa1JkVzFKNjBGR2ta?= =?utf-8?B?VmNEUDRDQjQrTEpNVkUrVkJJVlNqYW9FTkFRZzRGRkZmK2VwWHR0eE9tWUk3?= =?utf-8?B?N1hBRC93ZEhzTUc3S1BCdGhTOVFOL21zUWpLQVlOc0NpNHdoOFpDc1RzZ3I1?= =?utf-8?B?SHRGRXVFUWVmK1ZEcmdJRUFOdEhsNFh6Nm41Z05YUGhZMWY3V1dkdGRHRm4v?= =?utf-8?B?REVZZFVjQ2k0bDZnWkg4Wk5BeXdaenJGS0RPTmhrVlNKQWV5Z3lXcnpaTHdS?= =?utf-8?B?cjFQb0ljeWhJcVZMN3V2ZWxHNjFxaFJMME0vVzFtTVNMQ2RDRU1HenVOVzdE?= =?utf-8?B?ZVh1YUdmU1NaSFJyQ1hvUHpWdnAxR3BScUxoVUJscjRPcjdxak5Fb2RvUjhz?= =?utf-8?B?cThBWHd1cjl3Q2lQcW1MZFh2aGlveVNQZmRPSVRpK3BWUkx5NlJPaDcxVmhP?= =?utf-8?B?ZElIS0EyNjZsM294MXhWMUhWWEtvOVpydnRKMWQxYVYxd3Via2x2c3JSK0FU?= =?utf-8?B?ekUzSWsvV0l2ejZNZnVQZ1NBUDE2YnF5cjhuUDN3eml4dC9BNWM4QndlcE04?= =?utf-8?B?ZGpqbUdRa1ZRWjdqWmtDT0xlQXdaa2xyUk5xbGM2WkkwbWkrVFlEd1lJUGVn?= =?utf-8?B?ZnV1YlhsUnZCWDdBRll5cmNjcGM5TFUzUTh5T0lzdyt2cno1OXVQUFBpWVlo?= =?utf-8?B?RUdWTmt6eXVmOWJETEsySEVta2ZFcWtDbUd2OXFXVk1RaXNvVlhkSmtJNThR?= =?utf-8?B?Zm55RE5mUDNKbHludnpSdEs1SzR1WWlXRGZ5V3I5TTNzV1U4eE9PdWRid0Zy?= =?utf-8?B?KzY3MnVLcWdLRmxHdk1GTTVtWngzc0I5UDFTTDFiVExwRGFZMjdoWFd2YXh6?= =?utf-8?Q?Q0RGuyC+5Xtpsvv7DOu45WDWrwfkuxB8cJUNmV7?= MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB3917.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fcaa513f-1726-4839-df09-08d8edd2c6a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2021 08:08:00.3134 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FhVaaEzjkPOucSut61F4VY4EhcLzItdBUOfvGDv5jWDfboSIZBKYD4kynHKh0nWm+OT1hUnwYljSUgOIJCRzlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR02MB3839 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210323_080805_786675_6B00FD85 X-CRM114-Status: GOOD ( 41.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andy Shevchenko, > -----Original Message----- > From: Andy Shevchenko > Sent: Monday, March 22, 2021 10:47 PM > To: Sai Krishna Potthuri > Cc: Linus Walleij ; Rob Herring > ; Michal Simek ; Greg Kroah- > Hartman ; linux-arm Mailing List kernel@lists.infradead.org>; Linux Kernel Mailing List kernel@vger.kernel.org>; devicetree ; open > list:GPIO SUBSYSTEM ; git ; > saikrishna12468@gmail.com > Subject: Re: [PATCH v4 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support > > On Mon, Mar 22, 2021 at 5:25 PM Sai Krishna Potthuri > wrote: > > > From: Andy Shevchenko > > > Sent: Friday, March 19, 2021 3:53 PM On Thu, Mar 18, 2021 at 4:42 PM > > > Sai Krishna Potthuri > > > wrote: > > > > > From: Andy Shevchenko > > > > > Sent: Wednesday, March 17, 2021 6:26 PM On Wed, Mar 17, 2021 at > > > > > 10:27 AM Sai Krishna Potthuri > > > > > wrote: > > ... > > > > > #include > > > > > > Looking into other drivers with similar includes, shouldn't it go > > > first in the file before any other linux/* asm/* etc? > > I see some drivers are including this header before linux/* and some > > are using after linux/*. > > The rule of thumb is that: more generic headers are going first. > > I consider dt/* ones are more generic than linux/* ones because they are > covering more than just the Linux kernel. Ok, I will reorder accordingly. > > ... > > > > > > I'm lost here. What is IO standard exactly? Why it can't be in > > > > > generic headers? > > > > It represents LVCMOS 3.3 volts/ LVCMOS 1.8 volts. > > > > Since this is specific to Xilinx ZynqMP platform, considered to be > > > > added in the driver file. > > > > > > So, why can't we create a couple of bits to represent this voltages > > > in the generic header and gain usability for others as well? > > I see some drivers are maintaining the configuration list in the > > driver file, if the configuration is specific to the driver. > > Yes, my point is that this case doesn't sound too specific to the driver. Many > pin control buffers (in hardware way of speaking) have properties to be > different voltage tolerant / produce. Ok, you want me to proceed with this change or shall we wait for Linus to comment? > > > We can move this to generic header if it is used by others as well. > > Ok, will wait for Linus to comment. > > > > > > Linus? > > ... > > > > > > > + ret = zynqmp_pm_pinctrl_request(pin); > > > > > > + if (ret) { > > > > > > + dev_err(pctldev->dev, "request failed for pin > > > > > > + %u\n", pin); > > > > > > > > > > > + return -EIO; > > > > > > > > > > Why shadowing error code? > > > > > > So, any comments on the initial Q? > > Xilinx low level secure firmware error codes are different from Linux error > codes. > > Secure firmware maintains list of error codes (positive values other than > zero). > > Hence we return -EIO, if the return value from firmware is non-zero. > > Why the zynqmp_pm_pinctrl_request() can't return codes in Linux error > code space? I cross checked with the Xilinx firmware team, firmware driver is now returning Linux error codes in the latest kernel but while developing the driver it was a different approach. I will update the driver to simply return the values from firmware calls. > > > > >> Since it's the only possible error, why is it not > > > > > reflected in the kernel doc? > > > > I will update the kernel doc with the error value for such cases. > > > > > > > > > > > + } > > -- > With Best Regards, > Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel