From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF758C28CC0 for ; Thu, 30 May 2019 22:57:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C516262CB for ; Thu, 30 May 2019 22:57:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=daktronics.com header.i=@daktronics.com header.b="olgOCW6c" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726693AbfE3W5O (ORCPT ); Thu, 30 May 2019 18:57:14 -0400 Received: from mail-eopbgr690056.outbound.protection.outlook.com ([40.107.69.56]:52365 "EHLO NAM04-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726658AbfE3W5N (ORCPT ); Thu, 30 May 2019 18:57:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daktronics.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5g9ZwTLXGjepc9eOg/poUrw+d5nxerqqHIj9Je2W+/g=; b=olgOCW6cnS+J3M7uxe07VHVB/xFdhIKF75ENcCLOLqpwfAknYIm6yHkFekE2YMX4Lv3ku6OQTT/jsYtWVtjlF0jNCXEJm+eMOL1mFR9sHRHeJNJyGSz1McCYjbbc5AO1r389pVHkVIgZYsTLnnSNyhwgtsG4ZcgHH9ywY91QzbM= Received: from SN6PR02MB4016.namprd02.prod.outlook.com (52.135.69.145) by SN6PR02MB4174.namprd02.prod.outlook.com (52.135.70.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1922.16; Thu, 30 May 2019 22:57:09 +0000 Received: from SN6PR02MB4016.namprd02.prod.outlook.com ([fe80::60d8:13ef:ed32:4a6f]) by SN6PR02MB4016.namprd02.prod.outlook.com ([fe80::60d8:13ef:ed32:4a6f%5]) with mapi id 15.20.1922.021; Thu, 30 May 2019 22:57:09 +0000 From: Matt Sickler To: Greg KH , =?iso-8859-1?Q?Simon_Sandstr=F6m?= CC: "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 1/4] staging: kpc2000: add spaces around operators in core.c Thread-Topic: [PATCH 1/4] staging: kpc2000: add spaces around operators in core.c Thread-Index: AQHVEiEBEpaijJrwzEWx+f59/zurvaaEMrIAgAAb5vA= Date: Thu, 30 May 2019 22:57:09 +0000 Message-ID: References: <20190524110802.2953-1-simon@nikanor.nu> <20190524110802.2953-2-simon@nikanor.nu> <20190530210558.GA21455@kroah.com> In-Reply-To: <20190530210558.GA21455@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Matt.Sickler@daktronics.com; x-originating-ip: [63.85.214.4] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ee045381-928e-4e6d-8d07-08d6e5522539 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:SN6PR02MB4174; x-ms-traffictypediagnostic: SN6PR02MB4174: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 00531FAC2C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(346002)(136003)(366004)(39860400002)(396003)(189003)(199004)(81156014)(8936002)(71190400001)(53936002)(5660300002)(81166006)(446003)(476003)(3846002)(11346002)(71200400001)(478600001)(66446008)(66574012)(7736002)(76116006)(486006)(6246003)(73956011)(66946007)(68736007)(66556008)(64756008)(25786009)(66476007)(8676002)(256004)(26005)(4326008)(52536014)(74316002)(86362001)(14444005)(305945005)(186003)(76176011)(102836004)(9686003)(33656002)(55016002)(99286004)(229853002)(6506007)(54906003)(110136005)(6116002)(6436002)(7696005)(66066001)(14454004)(316002)(2906002)(72206003);DIR:OUT;SFP:1101;SCL:1;SRVR:SN6PR02MB4174;H:SN6PR02MB4016.namprd02.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: daktronics.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 6xkqsidjrTcET8Arn8LOB8/7Cq2kjAfJ8vme4jZmLYo3EP1bzm6MIU6HKeKNRFjN0CcmGZzRT7neySRUunFs40oTVLMEkxUJs0HmVHU+jJoPxJBWrmfnF/lWtpT4QxnYDwTsHv/DWUZ/B4PE5B6ZDbGbki9K2QZe7qk0hG7x6mBCCzxXpgiFdFy066L5IJf2HPHRz7WWN08AdMXhQlRmPfFZJ8TgkLEPTAaQf0KjY4pouxAdw8HLQ9PXS3CZLcKWtex5rszoPbev3yHH5b3BUfwM7lhABmn5SW106ayjmM1vUzfV4YmpbPZIJTZxTGNQLL3MeHLMiZzWHvH09BD7C8zMOadFZ4Vvu3Lr/OouFebY6WZmzQViDmL7ifR8btx+3eOVhV/NtpWvX1fZRjYu1vQ1VB/VHDQUzu+GKLujvpk= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: daktronics.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee045381-928e-4e6d-8d07-08d6e5522539 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2019 22:57:09.2872 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be88af81-0945-42aa-a3d2-b122777351a2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: matt.sickler@daktronics.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR02MB4174 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >From: devel On Behalf Of >Greg KH >On Fri, May 24, 2019 at 01:07:59PM +0200, Simon Sandstr=F6m wrote: >> --- a/drivers/staging/kpc2000/kpc2000/core.c >> +++ b/drivers/staging/kpc2000/kpc2000/core.c >> @@ -276,18 +276,18 @@ static ssize_t kp2000_cdev_read(struct file *filp, > >This whole function just needs to be deleted, it's a horrible hack. >From the outside, I would definitely agree with you. On the inside though,= we rely on this function to quickly identify what kind and version is running = on a given piece of hardware. Since that same information is provided by an i= octl, I could be convinced to remove this API and write a userspace application t= hat uses the ioctl to get the information and pretty prints it. I'd be more inclined to agree with the deletion if it means the whole char = dev interface can be removed from the kpc2000 driver. That won't be straightfo= rward as the ioctl is exposed through this interface. We could remove the ioctl,= but we'd need to ensure that all the same information is exposed via sysfs. Ou= r userspace side is all funneled through a single class, so changing it to us= e sysfs wouldn't be too difficult. I'd support that change if someone wants = to make it.