RE: [PATCH v1 08/25] gitlab: add build-user-hexagon test

[Brian Cain <bcain@quicinc.com>]

> -----Original Message-----
> From: Alex Bennée <alex.bennee@linaro.org>
...
> Which leads to the compiler complaining:
> 
>   hexagon-unknown-linux-musl-clang  -Wno-incompatible-pointer-types -
> Wno-undefined-internal -fno-unroll-loops -Wall -Werror -O0 -g -fno-strict-
> aliasing -mv67 -O2 -static /home
>   /alex.bennee/lsrc/qemu.git/tests/tcg/hexagon/circ.c -o circ  -static
>   /home/alex.bennee/lsrc/qemu.git/tests/tcg/hexagon/circ.c:257:1: error:
> unknown register name 'cs0' in asm
>   TEST_LOAD_IMM(b,  char,           bbuf, NBYTES, 1, d)
>   ^
>   /home/alex.bennee/lsrc/qemu.git/tests/tcg/hexagon/circ.c:242:9: note:
> expanded from macro 'TEST_LOAD_IMM'
>           CIRC_LOAD_IMM_##SZ(element, p, BUF, size * sizeof(TYPE), (INC)); \
>           ^
>   <scratch space>:9:1: note: expanded from here
>   CIRC_LOAD_IMM_b
>   ^
>   /home/alex.bennee/lsrc/qemu.git/tests/tcg/hexagon/circ.c:75:5: note:
> expanded from macro 'CIRC_LOAD_IMM_b'
>       CIRC_LOAD_IMM(b, RES, ADDR, START, LEN, INC)
>       ^
>   /home/alex.bennee/lsrc/qemu.git/tests/tcg/hexagon/circ.c:73:23: note:
> expanded from macro 'CIRC_LOAD_IMM'
>           : "r4", "m0", "cs0")
> 
> I suspect the easiest thing to do is to drop the patches again so I don't hold up
> the rest of testing/next. I can include the initial docker image patch but I
> won't enable it in configure.sh/gitlab.

Sorry -- I sent along a patch to update the LLVM_SRC_URL so that we would have the support we need for this test case.

> Would one of the hexagon guys be able to send a new image and verify it
> works with the current tests in master?

Sure, can do.  Do I need to update the container registry in gitlab somehow?  Or just share the patch to update the Dockerfile?

> >
> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> > Message-Id: <20210305092328.31792-7-alex.bennee@linaro.org>
> > ---
> >  .gitlab-ci.yml | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index
> > 52d65d6c04..87d1172b03 100644
> > --- a/.gitlab-ci.yml
> > +++ b/.gitlab-ci.yml
> > @@ -413,6 +413,17 @@ build-user-static:
> >      CONFIGURE_ARGS: --disable-tools --disable-system --static
> >      MAKE_CHECK_ARGS: check-tcg
> >
> > +# Because the hexagon cross-compiler takes so long to build we don't
> > +rely # on the CI system to build it and hence this job has no
> > +dependency # declared. The image is manually uploaded.
> > +build-user-hexagon:
> > +  <<: *native_build_job_definition
> > +  variables:
> > +    IMAGE: debian-hexagon-cross
> > +    TARGETS: hexagon-linux-user
> > +    CONFIGURE_ARGS: --disable-tools --disable-docs --enable-debug-tcg
> > +    MAKE_CHECK_ARGS: check-tcg
> > +
> >  # Only build the softmmu targets we have check-tcg tests for
> >  build-some-softmmu:
> >    <<: *native_build_job_definition
> 
> 
> --
> Alex Bennée