All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Boyer <Charles.Boyer@fii-usa.com>
To: "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Cc: "venture@google.com" <venture@google.com>,
	Mustafa Shehabi <Mustafa.Shehabi@fii-na.com>,
	"krellan@google.com" <krellan@google.com>,
	"edtanous@google.com" <edtanous@google.com>,
	"vveerach@google.com" <vveerach@google.com>,
	Lancelot Kao <Lancelot.Kao@fii-usa.com>
Subject: phosphor-pid-control: PWM not changing back from Manual to Auto mode
Date: Mon, 15 Nov 2021 23:20:56 +0000	[thread overview]
Message-ID: <SN6PR08MB40321BF3F391E7CFDEEBC2C4B6989@SN6PR08MB4032.namprd08.prod.outlook.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]

Hello Josh and Ed,

I used the OEM IPMI command to enter Manual mode of phosphor-pid-control, and then I set the PWM value. After leaving Manual mode, I would expect swampd to bring the PWM back to the value from before entering Manual mode. However, the PWM remains the value I set in Manual mode. Although, when I induced a temperature sensor to approach its setpoint, I observed the PWM to change.

I believe the reason is because of https://github.com/openbmc/phosphor-pid-control/blob/cca9c659889d149c06e95bab4b8808db4f1e3eab/dbus/dbuswrite.cpp#L69. My system uses DBus fan sensors, so the fan controller will call upon DbusWritePercent::write, which writes the calculated output value (ovalue) if it is different than the oldValue. When I enter Manual mode and set the PWM, the oldValue does not change; when I exit Manual mode, the ovalue and oldValue are the same as before Manual mode, so it skips the PWM write.

How can the PWM "immediately" return to its original value from before Manual mode?

Thanks,
Charles


[-- Attachment #2: Type: text/html, Size: 2677 bytes --]

             reply	other threads:[~2021-11-16  2:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15 23:20 Charles Boyer [this message]
2021-11-15 23:31 ` phosphor-pid-control: PWM not changing back from Manual to Auto mode Ed Tanous

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR08MB40321BF3F391E7CFDEEBC2C4B6989@SN6PR08MB4032.namprd08.prod.outlook.com \
    --to=charles.boyer@fii-usa.com \
    --cc=Lancelot.Kao@fii-usa.com \
    --cc=Mustafa.Shehabi@fii-na.com \
    --cc=edtanous@google.com \
    --cc=krellan@google.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=venture@google.com \
    --cc=vveerach@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.