Re: [dpdk-dev] [PATCH v2 09/11] examples/l3fwd: add event em main loop

From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
	"Jerin Jacob Kollanukkaran" <jerinj@marvell.com>,
	"Kovacevic, Marko" <marko.kovacevic@intel.com>,
	Ori Kam <orika@mellanox.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"Nicolau, Radu" <radu.nicolau@intel.com>,
	Akhil Goyal <akhil.goyal@nxp.com>,
	"Kantecki, Tomasz" <tomasz.kantecki@intel.com>,
	Sunil Kumar Kori <skori@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 09/11] examples/l3fwd: add event em main loop
Date: Mon, 6 Jan 2020 12:27:05 +0000	[thread overview]
Message-ID: <SN6PR11MB2558129A635FF10BB07AA8CD9A3C0@SN6PR11MB2558.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CY4PR1801MB18637BF5D227B25C602A04B5DE3C0@CY4PR1801MB1863.namprd18.prod.outlook.com>

> 
> >> Add em main loop for handling events based on capabilities of the
> >> event device.
> >>
> >> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >> ---
> >>  examples/l3fwd/l3fwd.h               |  10 ++
> >>  examples/l3fwd/l3fwd_em.c            | 177
> >+++++++++++++++++++++++++++
> >>  examples/l3fwd/l3fwd_em.h            | 159 +++++++++++++++++-------
> >>  examples/l3fwd/l3fwd_em_hlm.h        | 131
> >++++++++++++++++++++
> >>  examples/l3fwd/l3fwd_em_sequential.h |  26 ++++
> >>  examples/l3fwd/l3fwd_event.c         |   9 ++
> >>  examples/l3fwd/main.c                |   5 +-
> >>  7 files changed, 470 insertions(+), 47 deletions(-)
> >>
> >> diff --git a/examples/l3fwd/l3fwd.h b/examples/l3fwd/l3fwd.h
> >> index 8f2e4be23..2d02fa731 100644
> >> --- a/examples/l3fwd/l3fwd.h
> >> +++ b/examples/l3fwd/l3fwd.h
> >> @@ -221,6 +221,16 @@
> >lpm_event_main_loop_tx_q(__attribute__((unused)) void *dummy);
> >>  int
> >>  lpm_event_main_loop_tx_q_burst(__attribute__((unused)) void
> >*dummy);
> >>
> >> +int
> >> +em_event_main_loop_tx_d(__attribute__((unused)) void
> >*dummy);
> >> +int
> >> +em_event_main_loop_tx_d_burst(__attribute__((unused)) void
> >*dummy);
> >> +int
> >> +em_event_main_loop_tx_q(__attribute__((unused)) void
> >*dummy);
> >> +int
> >> +em_event_main_loop_tx_q_burst(__attribute__((unused)) void
> >*dummy);
> >
> >Same question as for lpm: if your functions don't need params,
> >why not to define them as ones without params?
> 
> Need to satisfy the prototype requirements for
> rte_eal_mp_remote_launch(l3fwd_lkp.main_loop, NULL, CALL_MASTER);

Ok.

> 
> >
> >> +
> >> +
> >>  /* Return ipv4/ipv6 fwd lookup struct for LPM or EM. */
> >>  void *
> >>  em_get_ipv4_l3fwd_lookup_struct(const int socketid);