RE: [PATCH 1/2] dt-bindings: net: Add bindings for Intel Keem Bay

["G Jaya Kumaran, Vineetha" <vineetha.g.jaya.kumaran@intel.com>]

> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Tuesday, July 7, 2020 9:08 PM
> To: G Jaya Kumaran, Vineetha <vineetha.g.jaya.kumaran@intel.com>
> Cc: davem@davemloft.net; kuba@kernel.org; mcoquelin.stm32@gmail.com;
> robh+dt@kernel.org; netdev@vger.kernel.org; devicetree@vger.kernel.org;
> Voon, Weifeng <weifeng.voon@intel.com>; Kweh, Hock Leong
> <hock.leong.kweh@intel.com>; Ong, Boon Leong <boon.leong.ong@intel.com>
> Subject: Re: [PATCH 1/2] dt-bindings: net: Add bindings for Intel Keem Bay
> 
> > +        mdio0 {
> > +            #address-cells = <1>;
> > +            #size-cells = <0>;
> > +            compatible = "snps,dwmac-mdio";
> > +
> > +            ethernet-phy@0 {
> > +                compatible = "ethernet-phy-id0141.0dd0",
> > +                              "ethernet-phy-ieee802.3-c22";
> 
> You only need to provide the phy-id when the PHY is broken and registers 2 and
> 3 don't contain a valid ID. And c22 is the default, so also not needed. The
> Marvell 88E1510 will work without these compatible strings.
> 
> 	   Andrew

Thanks Andrew, I will change this in v2.