All of lore.kernel.org
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Akhil Goyal <akhil.goyal@nxp.com>,
	"Doherty, Declan" <declan.doherty@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 3/3] crypto/aesni_mb: support Chacha20-Poly1305
Date: Fri, 9 Oct 2020 18:33:32 +0000	[thread overview]
Message-ID: <SN6PR11MB310109C422EC569232A7C66584080@SN6PR11MB3101.namprd11.prod.outlook.com> (raw)
In-Reply-To: <VI1PR04MB31687711282619FA589691FDE6080@VI1PR04MB3168.eurprd04.prod.outlook.com>

Hi Akhil,

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Friday, October 9, 2020 2:33 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 3/3] crypto/aesni_mb: support Chacha20-
> Poly1305
> 
> > +#if IMB_VERSION(0, 54, 3) <= IMB_VERSION_NUM
> > +	{	/* CHACHA20-POLY1305 */
> > 	\
> > +		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
> > 	\
> > +		{.sym = {						\
> > +			.xform_type = RTE_CRYPTO_SYM_XFORM_AEAD,
> > 	\
> > +			{.aead = {					\
> > +				.algo =
> > RTE_CRYPTO_AEAD_CHACHA20_POLY1305, \
> > +				.block_size = 64,			\
> > +				.key_size = {				\
> > +					.min = 32,			\
> > +					.max = 32,			\
> > +					.increment = 0			\
> > +				},					\
> > +				.digest_size = {			\
> > +					.min = 16,			\
> > +					.max = 16,			\
> > +					.increment = 0			\
> > +				},					\
> > +				.aad_size = {				\
> > +					.min = 0,			\
> > +					.max = 240,			\
> > +					.increment = 1			\
> > +				},					\
> > +				.iv_size = {				\
> > +					.min = 12,			\
> > +					.max = 12,			\
> > +					.increment = 0			\
> > +				},					\
> > +			}, }						\
> > +		}, }							\
> > +	},
> >  #endif
> >  	RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
> >  };
> 
> These line breaks are not needed. Rest of the caps are also not having it.

You are right, sorry. I got this from QAT PMD and I forgot to remove these line breaks.
Can you remove them when applying it?

Thanks!
Pablo

  reply	other threads:[~2020-10-09 18:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-06 10:59 [dpdk-dev] [PATCH 1/3] crypto/aesni_mb: fix CCM digest size check Pablo de Lara
2020-10-06 10:59 ` [dpdk-dev] [PATCH 2/3] crypto/aesni_mb: fix GCM " Pablo de Lara
2020-10-06 10:59 ` [dpdk-dev] [PATCH 3/3] crypto/aesni_mb: support Chacha20-Poly1305 Pablo de Lara
2020-10-09 12:05 ` [dpdk-dev] [PATCH v2 1/3] crypto/aesni_mb: fix CCM digest size check Pablo de Lara
2020-10-09 12:05   ` [dpdk-dev] [PATCH v2 2/3] crypto/aesni_mb: fix GCM " Pablo de Lara
2020-10-09 12:05   ` [dpdk-dev] [PATCH v2 3/3] crypto/aesni_mb: support Chacha20-Poly1305 Pablo de Lara
2020-10-09 13:32     ` Akhil Goyal
2020-10-09 18:33       ` De Lara Guarch, Pablo [this message]
2020-10-09 18:51         ` Akhil Goyal
2020-10-12 14:59           ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB310109C422EC569232A7C66584080@SN6PR11MB3101.namprd11.prod.outlook.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.