All of lore.kernel.org
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>,
	Tomasz Duszynski <tdu@semihalf.com>,
	Michael Shamis <michaelsh@marvell.com>,
	Liron Himi <lironh@marvell.com>,
	"Pattan, Reshma" <reshma.pattan@intel.com>,
	"Naga Suresh Somarowthu" <naga.sureshx.somarowthu@intel.com>,
	"Agalya Babu RadhaKrishnan"
	<agalyax.babu.radhakrishnan@intel.com>,
	"Mrozowicz, SlawomirX" <slawomirx.mrozowicz@intel.com>,
	"Doherty, Declan" <declan.doherty@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] drivers/crypto: move logtype variables to source files
Date: Fri, 17 Apr 2020 08:22:40 +0000	[thread overview]
Message-ID: <SN6PR11MB3101519E09A22A054F4B980C84D90@SN6PR11MB3101.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200415062216.22220-1-l.wojciechow@partner.samsung.com>



> -----Original Message-----
> From: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
> Sent: Wednesday, April 15, 2020 7:22 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Tomasz Duszynski
> <tdu@semihalf.com>; Michael Shamis <michaelsh@marvell.com>; Liron Himi
> <lironh@marvell.com>; Pattan, Reshma <reshma.pattan@intel.com>; Naga
> Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>; Agalya Babu
> RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>; Mrozowicz,
> SlawomirX <slawomirx.mrozowicz@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>
> Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] drivers/crypto: move logtype variables to source files
> 
> The four crypto drivers: kasumi, mvsam, snow3g and zuc define logtype
> variables in their header file. As the header files are included in more than one
> compilation unit, it might cause appearance of multiple instances of the variable
> and a linker error.
> Such situation can occur, when no common section is allowed by the compiler
> settings and tentative definitions are placed in BSS section.
> 
> Fixes: 2cba3814932e ("crypto/kasumi: add dynamic logging")
> Cc: naga.sureshx.somarowthu@intel.com
> Fixes: a05a450f42fd ("crypto/mvsam: add dynamic logging")
> Cc: tdu@semihalf.com
> Fixes: f3af5f9d1325 ("crypto/zuc: add dynamic logging")
> Cc: agalyax.babu.radhakrishnan@intel.com
> Fixes: a3277ad47feb ("cryptodev: remove crypto device driver name")
> Cc: slawomirx.mrozowicz@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

  reply	other threads:[~2020-04-17  8:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200410173223eucas1p270fdaa5dc11d4516514b5317dd331958@eucas1p2.samsung.com>
2020-04-10 17:27 ` [dpdk-dev] [PATCH] drivers: fix gcc 10 errors due to logtype var in header Bruce Richardson
     [not found]   ` <CGME20200415062247eucas1p2819f2f9045a51287706d3fced5362f9e@eucas1p2.samsung.com>
2020-04-15  6:22     ` [dpdk-dev] [PATCH] drivers/crypto: move logtype variables to source files Lukasz Wojciechowski
2020-04-17  8:22       ` De Lara Guarch, Pablo [this message]
2020-04-17 21:00         ` Akhil Goyal
2020-04-15  6:29   ` [dpdk-dev] [PATCH] drivers: fix gcc 10 errors due to logtype var in header Lukasz Wojciechowski
2020-04-15  9:31     ` Bruce Richardson
2020-04-17 21:02       ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB3101519E09A22A054F4B980C84D90@SN6PR11MB3101.namprd11.prod.outlook.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=agalyax.babu.radhakrishnan@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=l.wojciechow@partner.samsung.com \
    --cc=lironh@marvell.com \
    --cc=michaelsh@marvell.com \
    --cc=naga.sureshx.somarowthu@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=slawomirx.mrozowicz@intel.com \
    --cc=stable@dpdk.org \
    --cc=tdu@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.