From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12AC0C433EF for ; Mon, 11 Oct 2021 17:07:18 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 1608360E90 for ; Mon, 11 Oct 2021 17:07:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1608360E90 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 820C5410F6; Mon, 11 Oct 2021 19:07:14 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 29919410F5 for ; Mon, 11 Oct 2021 19:07:12 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10134"; a="290417744" X-IronPort-AV: E=Sophos;i="5.85,365,1624345200"; d="scan'208";a="290417744" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2021 10:07:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,365,1624345200"; d="scan'208";a="490556719" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP; 11 Oct 2021 10:07:05 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 11 Oct 2021 10:07:04 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 11 Oct 2021 10:07:04 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 11 Oct 2021 10:07:04 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 11 Oct 2021 10:07:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ivD83F/B+Cfh5mHHaTb5EylB0sb35dyguhorVIuIqBGHKa528U//NkMS40X8fl3+Sm2CU8SkSi5ebohqvX8KroTo6JXe+mz4jluUG9rtO6edspJ76VEq0GCbG03QKNyn+beV2RUohHbO3wwWQxg7eQ5yHnogxLDdM3lleZzPikNWLwTEbsmjB9m75XxFog6r4briI8ehDLF3DRXre24qHwgEcIhClN2MvItoaThn5WolHUdC8suX4jgnNlFvvWCagxDqRh+yJmiWeXxGaeap19Ng8yTlndHMCfdel+V4Ma+A79g1vMZPaoqbjj0xZiftv2BW/Fb2o3oia7bjKaLCVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i5bwv8rU9yR8IE9HtYTPqguZia5GTcAnaZ8jwOTxfuE=; b=cN1bhs/u00qozN+qHbzVPqI50X4XpcK6IqkBjQx0pNz/9FVoVXpjkepdOdp68EAzjpw4OuRZ4+9LQiww+HYVX/3Jx3Iqlu2DhNRq5wqTVhwkfuG12E4usmtv7VnvLi/+J0hHSNQde0t94R22pom+FJQMRFiE7ArB5UnOyQAoMLlW3PVGEluGhPJwsVzWaYW8D3kNM+g0dHXga7BdeHWSM49K2oJYoKHrddI4THIDBOEaNRbAiFaJRfy4I6pgADEjh46ySWZ/d2qTd++DfxlpMCTigteo1yowxLWtA5QwHcPM9/QIBTJcqSN+ZHjvX7y7Ssctp5pWhYNil/y9QOspBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i5bwv8rU9yR8IE9HtYTPqguZia5GTcAnaZ8jwOTxfuE=; b=W1exhSQkGHX5FoMGPmzpbpKQKBwZ3Uv6sDQt6Kpk+/n0jIDUc/3U1DIwROWuBEaUttVPU7ANX77FKbhT0JKrI/ar4CQKtdRJkt/0A+G4TsvvgxWS8iPxbrN3vWn3Y4G6fOrPwdlCdul9zUpCwrEv2rGjAquuO1xMu3/QKd4MaYw= Received: from SN6PR11MB3408.namprd11.prod.outlook.com (2603:10b6:805:bc::22) by SN6PR11MB2560.namprd11.prod.outlook.com (2603:10b6:805:55::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Mon, 11 Oct 2021 17:07:03 +0000 Received: from SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::bce9:d2c0:7c06:ff95]) by SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::bce9:d2c0:7c06:ff95%4]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021 17:07:03 +0000 From: "Ji, Kai" To: "Zhang, Roy Fan" , Akhil Goyal , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , "anoobj@marvell.com" , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "g.singh@nxp.com" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "Ananyev, Konstantin" , "Nicolau, Radu" , "ajit.khaparde@broadcom.com" , "rnagadheeraj@marvell.com" , "adwivedi@marvell.com" , "Power, Ciara" Thread-Topic: [PATCH v2 0/5] cryptodev: hide internal structures Thread-Index: AQHXvrpB8xUN3SZi7UOJud61JlMP4qvOA8jw Date: Mon, 11 Oct 2021 17:07:02 +0000 Message-ID: References: <20210829125139.2173235-1-gakhil@marvell.com> <20211011124309.4066491-1-gakhil@marvell.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 47167b70-5cf0-43fe-4027-08d98cd98bc4 x-ms-traffictypediagnostic: SN6PR11MB2560: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9jTSMMyYn/gxHJ4U5KEGb3AgW+Z88TBhP9p7KEZh69Bdlt4JtSt49fx7kdR5lhQcbK1vdAVAT+L5HueevSHELsVju9CumSff+d8r/CG3dKJEv3x3DQNDl6eH47wPXjx/Imun15Pn2LJ5J9qKMfnz0Xb91VtSulHKiRGVsKaMBMftU4DiwZJ1lh/ubMUEmSUBOC+XVxWE7FshSclr1DEhDSowSKRKEPekbz8A8Kdxbfw0E3bODY5qBhX/9DXa09Y632AdN0uOimt+qYK9zCrwEHGKVD0Mx5kUAAQPrRmteFpc1NVn1eK+L5tBLu9vh8ojp2uBm67eQE/3o4hWwKNcFyjFWT8YC0rcM5f0wqhNs5dnngcIlqvI3EzeRJaGy1ad3linC8qpRPLyAc7Zve3p7cn88n1T7A/MKijdFCSWCfWHyBPoUrvGep1ZOodHKva/C3p2vttaen6zKuoDvsIRYcElKu781maH+InzC0WCZ5U5CHCg6vWZnr2KXtEXk4fp6e9NZ5SfyovlB85Z3sEqKLOel/KUzt8i/Fiikv6gqC5kUwTssJ/ZMGbogaRkMxvmhuWAcumRU776TrpJcDGx4XcDl2eKN7Pry1KKwMSzioXuHXpxfJy0DU6ecWxPaqooLkQtIVkOsPL9ZjtWW2LJEGIXoBeNNlrOtYnq3rQIVt5pIvA02CdQG6Du5QyXUE1o7Y5E9ZB3c4TADxveFPC0nQANNbj3dH8UKG7unpWzle3/YCCnhY81dk7n3k1ShEyqQlVzZ6hDwrLCvjoatdFr92O/aqfH9USxjrPUVQlGy1VbmQ9h0lqujAM6wgk3tIuBdfN9RiundW3vh7QNs9XNqw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3408.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8676002)(4326008)(5660300002)(122000001)(316002)(38100700002)(9686003)(52536014)(55016002)(508600001)(26005)(54906003)(38070700005)(110136005)(83380400001)(33656002)(2906002)(186003)(71200400001)(53546011)(66556008)(66476007)(7416002)(6506007)(107886003)(66946007)(8936002)(966005)(86362001)(76116006)(64756008)(66446008)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fg5Bl2ICyNEJYoNLRTz/MvfkQ+BOuR+dTjC5XdN6Sap+gn5hd+ANkA2/QZk5?= =?us-ascii?Q?CGmWUtyBb4z4UIkw3YNvoey58qKKJH2OfvdRM278EASwUv9uA9fhRAsZKEBg?= =?us-ascii?Q?2vC4XkEgGyVxp4svczH8OljWd4r5Nr5unI7/JOwJ8xBNGxylbED4Rcssw2x+?= =?us-ascii?Q?Gi6mMnnJ+d+PTLoQlI0j/Ke6qllSuOk2dm0vyxqiQcb00QSIB/jzfapmCpPA?= =?us-ascii?Q?h43XdiAOFMZJlnlnbFKvGvQQlRm1RJHvZgHROM1TI07T4tdHJCYtb9JuZgJT?= =?us-ascii?Q?jDpa7VExyX2LwTZgbOFXHNNgBDhSYxCzH3F9A7jYabw87pCJBbeoUzxKEqMF?= =?us-ascii?Q?RXSnVBxNmGnF4Ly76wbJ7OKekCIXTSFL+/tWT3pixkoi+h+D/13CeZitz0mL?= =?us-ascii?Q?s6Hy8M8VzpUjWI9seKnxykkg66Hvfl7yPQ6j3OJVOXVAuhK+cRPBroe20ACi?= =?us-ascii?Q?ShILS9OdqktvDQBwp07OJ2sA4cPJm1+toHmoHqr7lzKMpX+azxgZL1JNDNWK?= =?us-ascii?Q?DQyIcRs5btai18X8FPccL5A/Ei76/Aqx1ugVQXXsXQwyTQVThNOYaLTQmZRN?= =?us-ascii?Q?+StqwsRTKOXmEMOezh7q/02y4V9tM5SYzucJdkFW1oLD9hjfHnT0bJcgH5dn?= =?us-ascii?Q?kYftwOg3s7p/9A6ZePkeIyNAqxNB46taRUM0c6Zuj81HVmwtA06xNF8ICTDL?= =?us-ascii?Q?3iJMPKG/GjIS5wO8MVhvkyiWJQ5VpA/s5N6vZNXoTWPTA8oaXEZwNXp4EC33?= =?us-ascii?Q?okGM4GfFydiVvIv5LbdnOhk4rKnRwfbmf9vc2o3GXeSvbR3d9SouqLwiqqs3?= =?us-ascii?Q?RHM20sqyo9L6sSvfa7F6livBy9Ej6TCpttJaWjzLcR/t10f6hLCBWQZG5oMe?= =?us-ascii?Q?KlK9/rxY9Ql9i9kudpYN3R2i+/elO3LTPER6UdU+mWcaBsurvnrbfCdhihGH?= =?us-ascii?Q?DU/znSrBY0LB0NNsLb7Pk8DmDi+EXbFYs8NUmuFyyos00GQQe4O+kjvquqoY?= =?us-ascii?Q?EhA3Ql3E/Nag7vSvlgC/4yzyf/PqvvYlZnleK6oXLTOit35Bx5XAkk4GPhAd?= =?us-ascii?Q?B4olFrFOtE/q/ZYTBNc+/PeOhgij3v+Vr78VT/KdgXtihdJurmHKHC0iPAf/?= =?us-ascii?Q?wYKbe+FJlUnQw1jrxIgHeaxN4xd5FI0McDBEajG+xJskorhAo/tiQ2rkk1EJ?= =?us-ascii?Q?q2AgElGUlWbml2Nr5t2DjOCvprEC88GmN8FDxtsIcpXGOqYYKCDfgCRqwRk1?= =?us-ascii?Q?BzjVthIYJD91yj4QlKeUjGPXv416OGrAd6jfpw9BqM+eWZ6GrwC8GC7F9Ppt?= =?us-ascii?Q?59A6sFizN0DWK2OKLYqguYBp?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3408.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47167b70-5cf0-43fe-4027-08d98cd98bc4 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2021 17:07:02.8533 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GvfqDnu+X/ARLB+RmQcJzgGAXtgd001gLM72UBR8I+hvo9eNlIHxVTOnouP5Bk3Y7zTOOd/ZmbVEkbZT96UDkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2560 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 0/5] cryptodev: hide internal structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, Just ran a quick mutli process test against the patch set, unfortunately it= failed on the secondary process enqueue or dequeue. USER1: Configuring vector 0, using session 0 USER1: Start enqueuing packets on dev 0 qp 0 USER1: Start dequeuing packets on dev 0 qp 0 USER1: Enqueuing - Dequeueing -Segmentation fault (core dumped) It will happen on any PMD type. Regards Kai=20 =20 > -----Original Message----- > From: dev On Behalf Of Zhang, Roy Fan > Sent: Monday, October 11, 2021 5:03 PM > To: Akhil Goyal ; dev@dpdk.org > Cc: thomas@monjalon.net; david.marchand@redhat.com; > hemant.agrawal@nxp.com; anoobj@marvell.com; De Lara Guarch, Pablo > ; Trahe, Fiona ; > Doherty, Declan ; matan@nvidia.com; > g.singh@nxp.com; jianjay.zhou@huawei.com; asomalap@amd.com; > ruifeng.wang@arm.com; Ananyev, Konstantin > ; Nicolau, Radu ; > ajit.khaparde@broadcom.com; rnagadheeraj@marvell.com; > adwivedi@marvell.com; Power, Ciara > Subject: Re: [dpdk-dev] [PATCH v2 0/5] cryptodev: hide internal structure= s >=20 > Hi Akhil, >=20 > The approach looks great but we may have to check if it works in multi- > process environment - since all enqueue/dequeue handlers are set by > primary process the secondary process may not recognize the fp_ops data. >=20 > We will run a quick test to see if it is true. >=20 > Regards, > Fan >=20 > > -----Original Message----- > > From: Akhil Goyal > > Sent: Monday, October 11, 2021 1:43 PM > > To: dev@dpdk.org > > Cc: thomas@monjalon.net; david.marchand@redhat.com; > > hemant.agrawal@nxp.com; anoobj@marvell.com; De Lara Guarch, Pablo > > ; Trahe, Fiona > > ; Doherty, Declan ; > > matan@nvidia.com; g.singh@nxp.com; Zhang, Roy Fan > > ; jianjay.zhou@huawei.com; > asomalap@amd.com; > > ruifeng.wang@arm.com; Ananyev, Konstantin > > ; Nicolau, Radu > > ; ajit.khaparde@broadcom.com; > > rnagadheeraj@marvell.com; adwivedi@marvell.com; Power, Ciara > > ; Akhil Goyal > > Subject: [PATCH v2 0/5] cryptodev: hide internal structures > > > > Structures rte_cryptodev and rte_cryptodev_data are not supposed to be > > directly used by the application. These are made public as they are > > used by inline datapath public APIs. > > This patchset, creates a new rte_cryptodev_core.h file which helps in > > defining a data structure to hold datapath APIs in a flat array based > > on the device identifier which is filled by the PMD. > > > > Similar series for ethdev and eventdev are also floated on ML. > > https://patchwork.dpdk.org/project/dpdk/list/?series=3D19428 > > https://patchwork.dpdk.org/project/dpdk/list/?series=3D19405 > > > > changes in v2: align with the latest versions of above series. > > > > Akhil Goyal (5): > > cryptodev: separate out internal structures > > cryptodev: allocate max space for internal qp array > > cryptodev: move inline APIs into separate structure > > cryptodev: update fast path APIs to use new flat array > > cryptodev: move device specific structures > > > > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 1 - > > drivers/crypto/ccp/ccp_dev.h | 2 +- > > drivers/crypto/cnxk/cn10k_ipsec.c | 2 +- > > drivers/crypto/cnxk/cn9k_ipsec.c | 2 +- > > .../crypto/cnxk/cnxk_cryptodev_capabilities.c | 2 +- > > drivers/crypto/cnxk/cnxk_cryptodev_sec.c | 2 +- > > drivers/crypto/nitrox/nitrox_sym_reqmgr.c | 2 +- > > drivers/crypto/octeontx/otx_cryptodev.c | 1 - > > .../crypto/octeontx/otx_cryptodev_hw_access.c | 2 +- > > .../crypto/octeontx/otx_cryptodev_hw_access.h | 2 +- > > drivers/crypto/octeontx/otx_cryptodev_ops.h | 2 +- > > .../crypto/octeontx2/otx2_cryptodev_mbox.c | 2 +- > > drivers/crypto/scheduler/scheduler_failover.c | 2 +- > > .../crypto/scheduler/scheduler_multicore.c | 2 +- > > .../scheduler/scheduler_pkt_size_distr.c | 2 +- > > .../crypto/scheduler/scheduler_roundrobin.c | 2 +- > > drivers/event/cnxk/cnxk_eventdev.h | 2 +- > > drivers/event/dpaa/dpaa_eventdev.c | 2 +- > > drivers/event/dpaa2/dpaa2_eventdev.c | 2 +- > > drivers/event/octeontx/ssovf_evdev.c | 2 +- > > .../event/octeontx2/otx2_evdev_crypto_adptr.c | 2 +- > > lib/cryptodev/cryptodev_pmd.c | 51 +++ > > lib/cryptodev/cryptodev_pmd.h | 82 +++- > > lib/cryptodev/meson.build | 4 +- > > lib/cryptodev/rte_cryptodev.c | 50 ++- > > lib/cryptodev/rte_cryptodev.h | 367 +++++++----------- > > lib/cryptodev/rte_cryptodev_core.h | 62 +++ > > lib/cryptodev/version.map | 7 +- > > 28 files changed, 398 insertions(+), 265 deletions(-) create mode > > 100644 lib/cryptodev/rte_cryptodev_core.h > > > > -- > > 2.25.1