From: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>,
Isaac Vaughn <isaac.vaughn@Knights.ucf.edu>
Cc: "trivial@kernel.org" <trivial@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Subject: RE: [PATCH] amd64_edac - Add Family 17h Model 70h PCI IDs
Date: Wed, 4 Sep 2019 22:21:49 +0000 [thread overview]
Message-ID: <SN6PR12MB2639900DEABC70E0AD0CB8D5F8B80@SN6PR12MB2639.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20190904215308.GA12374@zn.tnic>
> -----Original Message-----
> From: linux-edac-owner@vger.kernel.org <linux-edac-owner@vger.kernel.org> On Behalf Of Borislav Petkov
> Sent: Wednesday, September 4, 2019 4:53 PM
> To: Isaac Vaughn <isaac.vaughn@Knights.ucf.edu>; Ghannam, Yazen <Yazen.Ghannam@amd.com>
> Cc: trivial@kernel.org; linux-edac@vger.kernel.org
> Subject: Re: [PATCH] amd64_edac - Add Family 17h Model 70h PCI IDs
>
> Hi Isaac,
>
> On Wed, Sep 04, 2019 at 09:13:47PM +0000, Isaac Vaughn wrote:
> > I noticed the current EDAC driver doesn't support the new Zen 2 (model
> > 70h) processors, so I patched the new device ids in. The changes are
> > minimal, I merely extended the existing enums with information from
> > the new models.
>
> Makes sense to me.
>
> @Yazen, ACK?
The new PCI IDs are correct. However, we also need Device 18h Function 3
for amd64_edac_mod to function. I don't see a commit upstream that adds
this.
Isaac,
Could you please add the Function 3 as well? Please see the following for
reference.
be3518a16ef2 ("x86/amd_nb: Add PCI device IDs for family 17h, model 30h")
Thank you!
-Yazen
next prev parent reply other threads:[~2019-09-04 22:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 21:13 [PATCH] amd64_edac - Add Family 17h Model 70h PCI IDs Isaac Vaughn
2019-09-04 21:53 ` Borislav Petkov
2019-09-04 22:21 ` Ghannam, Yazen [this message]
2019-09-05 1:21 ` Isaac Vaughn
2019-09-05 7:09 ` Borislav Petkov
2019-09-05 13:17 ` Isaac Vaughn
2019-09-05 13:54 ` Borislav Petkov
2019-09-06 1:01 ` [PATCH] Add PCI device IDs for family 17h, model 70h Isaac Vaughn
2019-09-06 1:41 ` Ghannam, Yazen
2019-09-06 1:56 ` Isaac Vaughn
2019-09-06 9:12 ` Borislav Petkov
[not found] ` <20190906075729.9e2faf7147da62fc26006833@knights.ucf.edu>
2019-09-06 12:14 ` Borislav Petkov
2019-09-06 13:02 ` Guenter Roeck
2019-09-06 13:09 ` Boris Petkov
[not found] ` <B08C8E54-43FA-4E29-8D7D-5F9C4AF20CCF@Knights.ucf.edu>
2019-09-06 14:50 ` Borislav Petkov
2019-09-06 23:27 ` Isaac Vaughn
2019-09-06 16:11 ` Guenter Roeck
2019-09-06 16:22 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR12MB2639900DEABC70E0AD0CB8D5F8B80@SN6PR12MB2639.namprd12.prod.outlook.com \
--to=yazen.ghannam@amd.com \
--cc=bp@alien8.de \
--cc=isaac.vaughn@Knights.ucf.edu \
--cc=linux-edac@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.