All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregory Etelson <getelson@nvidia.com>
To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
Cc: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>, Matan Azrad <matan@nvidia.com>,
	Raslan Darawsheh <rasland@nvidia.com>,
	Dmitry Kozlyuk <dkozlyuk@oss.nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] examples/multi_process: fix RX packets distribution
Date: Tue, 9 Nov 2021 09:35:53 +0000	[thread overview]
Message-ID: <SN6PR12MB2639FB3C365932BD9AC4B6C5A5929@SN6PR12MB2639.namprd12.prod.outlook.com> (raw)
In-Reply-To: <2000101.8nMyBBQigM@thomas>

Hello Thomas,


> > > 28/10/2021 17:35, Burakov, Anatoly:
> > > > On 28-Oct-21 4:14 PM, Gregory Etelson
> wrote:
> > > > >>> -     uint8_t client = 0;
> > > > >>> +     static uint8_t client = 0;
> > > >
> > > > Acked-by: Anatoly Burakov
> > > <anatoly.burakov@intel.com>
> > >
> > > checkpatch has a message for you:
> > > ERROR:INITIALISED_STATIC: do not initialise
> > > statics to 0
> > >
> >
> > Turning the `client` variable to static ensured
> that the next time
> > the function will be called it will proceed
> iterating clients instead of
> > starting a loop from the beginning - that's the
> main idea of that patch.
> > The variable must be initialized to 0 because
> the application model
> > requires at least a single client with index 0.
> > ANSI C allows static variables initialization to
> any valid value.
> > Do you know why the checkpatch utility denied
> such initialization ?
> 
> ANSI C makes static variables iniatilized to 0 by
> default.
> 


I'll post updated patch

Regards,
Gregory


  reply	other threads:[~2021-11-09  9:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26  9:50 [dpdk-dev] [PATCH] examples/multi_process: fix RX packets distribution Gregory Etelson
2021-10-28 14:29 ` Burakov, Anatoly
2021-10-28 15:14   ` Gregory Etelson
2021-10-28 15:35     ` Burakov, Anatoly
2021-11-08 21:27       ` Thomas Monjalon
2021-11-09  6:42         ` Gregory Etelson
2021-11-09  7:30           ` Thomas Monjalon
2021-11-09  9:35             ` Gregory Etelson [this message]
2021-11-09  9:58 ` [dpdk-dev] [PATCH v2] examples/multi_proces: fix Rx " Gregory Etelson
2021-11-09 11:35   ` Thomas Monjalon
2021-11-09 11:49     ` Gregory Etelson
2021-11-09 14:17       ` Thomas Monjalon
2021-11-10 16:52 ` [PATCH v3] " Gregory Etelson
2021-11-10 16:57 ` [PATCH v4] examples/multi_process: " Gregory Etelson
2021-11-16 15:07   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR12MB2639FB3C365932BD9AC4B6C5A5929@SN6PR12MB2639.namprd12.prod.outlook.com \
    --to=getelson@nvidia.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=dkozlyuk@oss.nvidia.com \
    --cc=matan@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.