From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: Content-Type: multipart/alternative; boundary="_2bbb2527-2a1e-4373-afe9-eade7371016c_" From: HarryCiao To: , Stephen Smalley , , CC: selinux-mailing-list Subject: RE: [PATCH 1/1] Fix arguments when expanding user_datum_t.roles Date: Fri, 27 May 2011 02:13:45 +0000 In-Reply-To: <1306315569-5432-2-git-send-email-qingtao.cao@windriver.com> References: <1306315569-5432-1-git-send-email-qingtao.cao@windriver.com>,<1306315569-5432-2-git-send-email-qingtao.cao@windriver.com> MIME-Version: 1.0 Sender: owner-selinux@tycho.nsa.gov List-Id: selinux@tycho.nsa.gov --_2bbb2527-2a1e-4373-afe9-eade7371016c_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: 8bit Please ignore this patch, I have integrated it in those patches to add role attribute support. Thanks, Harry > From: qingtao.cao@windriver.com > To: sds@tycho.nsa.gov; jmorris@namei.org; eparis@parisplace.org > CC: selinux@tycho.nsa.gov > Subject: [PATCH 1/1] Fix arguments when expanding user_datum_t.roles > Date: Wed, 25 May 2011 17:26:09 +0800 > > When expanding user_datum_t.roles role_set_t, the policydb_t of > the out module should be passed rather than that of the base module! > > Signed-off-by: Harry Ciao > --- > libsepol/src/expand.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libsepol/src/expand.c b/libsepol/src/expand.c > index da084ec..3308c3f 100644 > --- a/libsepol/src/expand.c > +++ b/libsepol/src/expand.c > @@ -977,7 +977,7 @@ static int user_copy_callback(hashtab_key_t key, hashtab_datum_t datum, > ebitmap_init(&tmp_union); > > /* get global roles for this user */ > - if (role_set_expand(&user->roles, &tmp_union, state->base, state->rolemap)) { > + if (role_set_expand(&user->roles, &tmp_union, state->out, state->rolemap)) { > ERR(state->handle, "Out of memory!"); > ebitmap_destroy(&tmp_union); > return -1; > -- > 1.7.0.4 > > > -- > This message was distributed to subscribers of the selinux mailing list. > If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with > the words "unsubscribe selinux" without quotes as the message. --_2bbb2527-2a1e-4373-afe9-eade7371016c_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: 8bit Please ignore this patch, I have integrated it in those patches to add role attribute support.

Thanks,
Harry

> From: qingtao.cao@windriver.com
> To: sds@tycho.nsa.gov; jmorris@namei.org; eparis@parisplace.org
> CC: selinux@tycho.nsa.gov
> Subject: [PATCH 1/1] Fix arguments when expanding user_datum_t.roles
> Date: Wed, 25 May 2011 17:26:09 +0800
>
> When expanding user_datum_t.roles role_set_t, the policydb_t of
> the out module should be passed rather than that of the base module!
>
> Signed-off-by: Harry Ciao <qingtao.cao@windriver.com>
> ---
> libsepol/src/expand.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/libsepol/src/expand.c b/libsepol/src/expand.c
> index da084ec..3308c3f 100644
> --- a/libsepol/src/expand.c
> +++ b/libsepol/src/expand.c
> @@ -977,7 +977,7 @@ static int user_copy_callback(hashtab! _key_t key, hashtab_datum_t datum,
> ebitmap_init(&tmp_union);
>
> /* get global roles for this user */
> - if (role_set_expand(&user->roles, &tmp_union, state->base, state->rolemap)) {
> + if (role_set_expand(&user->roles, &tmp_union, state->out, state->rolemap)) {
> ERR(state->handle, "Out of memory!");
> ebitmap_destroy(&tmp_union);
> return -1;
> --
> 1.7.0.4
>
>
> --
> This message was distributed to subscribers of the selinux mailing list.
> If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
> the words "unsubscribe selinux" without quotes as the message.
--_2bbb2527-2a1e-4373-afe9-eade7371016c_-- -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with the words "unsubscribe selinux" without quotes as the message.