From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED3B0C7EE23 for ; Mon, 12 Jun 2023 05:32:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E6DCD8591B; Mon, 12 Jun 2023 07:32:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=unsw.edu.au Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=unsw.edu.au header.i=@unsw.edu.au header.b="jS/RsVKy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 82ED385C5A; Mon, 12 Jun 2023 07:32:13 +0200 (CEST) Received: from AUS01-SY4-obe.outbound.protection.outlook.com (mail-sy4aus01on2071a.outbound.protection.outlook.com [IPv6:2a01:111:f403:7005::71a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F2D43846D8 for ; Mon, 12 Jun 2023 07:32:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=unsw.edu.au Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=d.antliff@unsw.edu.au ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H47tpGTmRUdU/Cv5eq1KkE/ZzR7JPnrW3AlJ9f493TCFRCwVPd9ISGCqlgLtNcpjX1OPjfKf/sbI/M+VunUBr/wV/B31pF4YnETncS+a2lHeCs+/tsWVzb+prqNlWmqOJw5SiOgC1Bhgf5jCxC300ZJiazCZr4dlLRpfxvkkm2ogTZkCVxk7Ud1CvcX/ld0a+mrtrZofI5V6IIZPEoye3MIrHkD2znZYQRn6PEDz1X6/ZUTA1AeTForVbvfEyDa5wj2HlA+VGcjMJUOJNIvI2Obgnmy6mI0rILY+Cuaqcxu55JMHoPiQFGVqWEEdGc4VUODyWLim6MyuL9XANvkJPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V1FwmxBs6/Te3DbtAReI8pgdLaoBN8UHziKLeafiq3U=; b=WfYLJ4RE0DT4jMWUkxDBUcCtdGk5tSvZRcMGufWrEeaDhuaJzz/e93FUuZ4CAlvvUNXj8py05kB88VLsxr9BIrjBEa8RwBZW9OEZGRXw5vrq98AAeWAk0R98cc73sfFHBKQFhqvLWmmzNBYDtIGOH0sQTcyv/Q+JLQp07LCcGrQGjmzx3P4n3Im7UhtV5hlR+VLSQJIXy49ja+GbISnEkn5F45c/pphGZP3I5AhjxbJeWSerukTO+OWuFFgqPMwtoQms00F+7VdlEkqHjZjhcmHsVrAJf5dltjpb5/QaUQ6+RixS3OqDMN8XRpy+HYl3bZdpweVSPsmGfypq/6b2NA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=unsw.edu.au; dmarc=pass action=none header.from=unsw.edu.au; dkim=pass header.d=unsw.edu.au; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unsw.edu.au; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V1FwmxBs6/Te3DbtAReI8pgdLaoBN8UHziKLeafiq3U=; b=jS/RsVKy+SgqdFcMz1B2Fxaz84FqKq7rMKGaPswe89isbxFv1DlXr3WKst/q3OjqPXSYe5hrNiJqe1dDdYWFERkvLZJoCBXY5Zc98cONugMX0MuI4Kgs66JiuDNvULEg7KBTcAQD9ZpyqpDZDsFsZ0YJ9XdOge31so820sTtciM= Received: from SY4PR01MB6797.ausprd01.prod.outlook.com (2603:10c6:10:136::13) by MEYPR01MB7437.ausprd01.prod.outlook.com (2603:10c6:220:161::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.29; Mon, 12 Jun 2023 05:32:02 +0000 Received: from SY4PR01MB6797.ausprd01.prod.outlook.com ([fe80::d22e:de5f:c4b3:882c]) by SY4PR01MB6797.ausprd01.prod.outlook.com ([fe80::d22e:de5f:c4b3:882c%7]) with mapi id 15.20.6477.028; Mon, 12 Jun 2023 05:32:02 +0000 From: David Antliff To: Sean Anderson , "u-boot@lists.denx.de" Subject: Re: Setting MAC address from I2C EEPROM - debug / commands? (Xilinx) Thread-Topic: Setting MAC address from I2C EEPROM - debug / commands? (Xilinx) Thread-Index: AQHY/tWe8sM51023SUG9YFE8iUUXcK5L1byAgTvgEx+AABGqAIAAAOGYgAAIgUY= Date: Mon, 12 Jun 2023 05:32:02 +0000 Message-ID: References: <7b864725-2ed2-29b8-b5fd-9233434b8c80@gmail.com> <17482435-1690-7c0d-772e-09daf8417ca4@gmail.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=unsw.edu.au; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SY4PR01MB6797:EE_|MEYPR01MB7437:EE_ x-ms-office365-filtering-correlation-id: 472341d7-4486-45ba-b035-08db6b0659de x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WIpQuflSxl5hSoCuImsnvMiBIZrZuUvke32L1TWmyWym/TDMSPcEBf3/Y+VCYB2lNR7JPstwn6DRm/YvdNHSpnfFgKkQIcgwVSXWcoBBk0tpyHC7l+Y3rQgPDNdai3sO7deyA8DBmz0A+pBaHztb2eyMRcUbO7kJ+aifcCA7qXq2oeoKjNuvd587Y9z25z9EDNtp3PzjEHuz8eXSONVKFL8c2CY2A9Y3SrDJC1rwMkiE/XAj9InzkbAxnsmVvaVSxrSAfAQo6dK1hUUgQRXKdV7+dGWKeIvYkzdrzB01c+s3sPQfOa49FcTBb7jFWDjF+dekS4m3HmwK+TJkXftkyQIoWBT4YqhCuPSLTstdBFKE9p/jFvBbuwQOWNCaOioEaL+xsufWlV8PafeDC0P/3MB1Q1GXzj/lBfl7uxZB5NGkK6QlZXoZKX2Ew59w8z2mt4XmFMBdAlVpUp6Q8AK0hTp2R6C3cRM2oFKXnkiWfYy2ZtHrSgx6c/Nv9nCkYUkENRH0XREd/TyUzqrmX84evNInkx3kqfWfm+8c7ppo4SO+S1aLCdLJ/5OJ/8b7n86idSeJGFG5s2v4XUoy+JNANJLsUkR9Y11cicGkeTcwyuA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SY4PR01MB6797.ausprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(346002)(366004)(396003)(39860400002)(376002)(451199021)(786003)(316002)(7696005)(41300700001)(86362001)(9686003)(6506007)(53546011)(38070700005)(186003)(41320700001)(26005)(33656002)(2940100002)(2906002)(122000001)(38100700002)(55016003)(5660300002)(52536014)(8936002)(8676002)(64756008)(66946007)(66556008)(76116006)(66446008)(110136005)(71200400001)(478600001)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?wTq79MhRweaxaA3NjazKcWsgoFSq7GEIZpWcgVYULF11z0nNjh/vUrW4E2?= =?iso-8859-1?Q?xU+uJKqglKzsiZad6hqiEQlHu/PUDg3lPlPx+mZhiItd/LL8a+O6CS0S21?= =?iso-8859-1?Q?OMgJ+CHRg5biAUJDdMOofeD+ExZ7LkJkCSXIIi61A1CwcOnPg0hm7TeyEY?= =?iso-8859-1?Q?8cA8RzOPweqGynQu2sTxHdeFnis/TjiSOXLQU8MIQYN8+yFfthrYSdTJ+d?= =?iso-8859-1?Q?qOCLhzLAGlH07gc1Iv+OSJeHVBOqiusq5u1nyFmKzpuOuu1Fis4f/Swgrv?= =?iso-8859-1?Q?f7jgD6U/mmpvDIwVYY4FI5QdaQz1eEx2zyqCQ6YcojL2kaOrMDFEI/6GFh?= =?iso-8859-1?Q?l2cRMxlW2qQvHQEnZhbD142ooGrW7ldf8424/CQJq8cElS+vrLrMQc3NiU?= =?iso-8859-1?Q?knXT2O+WpYpXdIAvNAjZOh8D3oBrO5hVOdH+kwRfegnPfJEbjjM4CoUPB+?= =?iso-8859-1?Q?oxaSFIl1YghQJf9VtRgZ4TDvDqVRyzDsQGeJNuhuxFQuVEGlPPOhVHmz3d?= =?iso-8859-1?Q?Gq89AIcSZfgwkkpQmmloW3ZMDfVXOQEeJEJbdJddhZ4KIdqrtSsX7EC+tZ?= =?iso-8859-1?Q?krHsv+fx4q+cncF8ERAa75fUYNY1MShWGvjl6Eor7RtJcNhfhfGEmLGBDm?= =?iso-8859-1?Q?QkjIpfcWXnwvl87Zu1qi6IWocwc7nZHuj43Kg9S0p5nouyXxT6dirqbcym?= =?iso-8859-1?Q?sNW5+ZMD2wtuuOIHZrDMyyoCbaXGe5PyVsa7LYEJu7wVgceNB/JmJUWhCg?= =?iso-8859-1?Q?Kf8EZESxZ2SZbxX1V1tCE9S9QqJhO38WcWmERko/EfjY3WobozU5XqvHiy?= =?iso-8859-1?Q?pWq2l0EzIeNR5rWbcj2CNkyugEbEiUe80HvV1Q5EoIux2BjYKNbnycj/1+?= =?iso-8859-1?Q?odvhoUONfI4GqhPHZErV/yOduPGNIbpY4kx/oV4oHzidiYQxjPEGFTsm8/?= =?iso-8859-1?Q?lhJElesfVMA2Fpf/CUtM+HPUMN6VbYZfcXFDeTL+ogMDGNFFiOPPGux5Cm?= =?iso-8859-1?Q?+0fsuMxz3WobRw5YxL98c2+weeDZT0VJ+K44UbdWVbwzvw/xthpUjA+Gsu?= =?iso-8859-1?Q?kC6sxdUCzwdNqOWaQEtyGKYJ/Tj2cu35/be7q88xx0Vf7oR96hd9hTJl/i?= =?iso-8859-1?Q?o38amsLo3mXrLCth1JgvtA+iviD5ydHA/slmelH7aJkQI9olV+FnAqe53a?= =?iso-8859-1?Q?1LLT2EKzjZHybm2shRK7m2Cdvhw1uN7KVjxDFB87SUKkMJOSeZydIEDgh+?= =?iso-8859-1?Q?qFWJ+bs9tZiboo8MwEA5VO9EFEgwbUCXR/csRKAWC0j2R3C/CzWtMtVlx2?= =?iso-8859-1?Q?LPuf1U9TAb80Ow8ga1mxArNkbqXjdKlZE4HpY7GHvJT82SsxCcE4saV8NR?= =?iso-8859-1?Q?LG3I22GZxWQP3oFMwdC0QUSO7/Uy/4QgdK8YCRUWnFe8mg0Cq+9B4byZ1x?= =?iso-8859-1?Q?6wc3Qir15ucNhakKynG+h63QSOXpcBTmllrZg8W9Sxc4qEHs+TzCUIU0j6?= =?iso-8859-1?Q?WQ0k15hHVPwEskU/DweWJ1ZpPCtE18htZn4VDqq9yOMQqRWy+/Pey5mhoJ?= =?iso-8859-1?Q?pg0NI2+1rbYOpV5PF3onyaGcLDaZiJVAI6k2adurH0EnfXZ12FI7Tw4N9e?= =?iso-8859-1?Q?PNlJuvKtjHA97hcvwWyzcYt9HobOt3BGIO?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: unsw.edu.au X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SY4PR01MB6797.ausprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 472341d7-4486-45ba-b035-08db6b0659de X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2023 05:32:02.4746 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3ff6cfa4-e715-48db-b8e1-0867b9f9fba3 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mq/CEgtYQ+NO1IzpwXKOzug1Pxo0LgC9kF2ZDxtjhzqvzE+0h4QuDMs27nXATMcFgfWDyekCGMjoTX+Q2znQEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MEYPR01MB7437 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean =0A= On 6/11/23 David Antliff wrote:=0A= >=A0On 6/11/23 Sean Anderson wrote:=0A= >=A0> On 6/11/23 23:25, David Antliff wrote:=0A= >=A0> > On 11/23/22 Sean Anderson wrote:=0A= >=A0> >>=A0 =A0On 11/22/22 20:23, David Antliff wrote:=0A= =0A= [snip]=0A= =0A= >=A0> >=A0 From a little debugging, I see that the call in eth-uclass.c aro= und line 515 returns a null pointer:=0A= >=A0> > =0A= >=A0> >=A0=A0=A0=A0=A0=A0=A0 p =3D dev_read_u8_array_ptr(dev, "mac-address"= , ARP_HLEN);=0A= >=A0> =0A= >=A0> This is expected. If (local-)mac-address is defined then nvmem_cell_g= et_by_name/nvmem_cell_read will not be used.=0A= =0A= This was the hint I needed to solve this - thank you.=0A= =0A= Turns out that PetaLinux (sigh) was injecting the ff:ff:ff... MAC address i= nto the device-tree build, which is where local-mac-address=0A= was coming from. As you mentioned, and as I can now see in eth-uclass.c, th= e NVMEM subsystem isn't used if either of these=0A= nodes are defined.=0A= =0A= Although PetaLinux's own config insists on setting a MAC address, I was abl= e to set it to a blank string which results=0A= in a DT node, but with no value. This seems sufficient to get past the chec= ks for "{local-,}mac-address" and call the NVMEM=0A= functions instead.=0A= =0A= project-spec/configs/config:=0A= =0A= CONFIG_SUBSYSTEM_ETHERNET_PSU_ETHERNET_3_MAC=3D""=0A= =0A= For anyone else coming across this, here's my final DT snippet:=0A= =0A= axi {=0A= i2c@ff030000 {=0A= i2c-mux@74 {=0A= i2c@0 {=0A= eeprom@54 {=0A= #address-cells =3D <1>;=0A= #size-cells =3D <1>;=0A= compatible =3D "atmel,24c128";=0A= reg =3D <0x54>;=0A= =0A= mac_address: mac-address@23 {=0A= reg =3D <0x23 6>;=0A= };=0A= };=0A= };=0A= };=0A= };=0A= =0A= ethernet@ff0e0000 {=0A= nvmem-cells =3D <&mac_address>;=0A= nvmem-cell-names =3D "mac-address";=0A= };=0A= };=0A= =0A= Also, it appears that 'compatible =3D ... , "nvmem-cells";' on the EEPROM n= ode is not required.=0A= =0A= Thank you for the hints!=0A= =0A= -- David.=0A= =0A= =0A=